diff mbox

system: make systemd's kernel headers comment fit

Message ID 1441904157-19302-1-git-send-email-arnout@mind.be
State Accepted
Commit b287378d3c0fca20d7fec4fbf3c097115afcbd5a
Headers show

Commit Message

Arnout Vandecappelle Sept. 10, 2015, 4:55 p.m. UTC
The comment line that explains that systemd needs a glibc toolchain and
kernel headers >= 3.10 doesn't fit in the dialog box, which makes it
look as if headers >= 3.1 are needed.

Abbreviate the comment a little by removing an 'an'. It still doesn't
fit completely (only one trailing * is shown), but at least it's
readable.

While we're at it, change the quoting style to " like we always use.

Reported-by: eschu on IRC
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 system/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yann E. MORIN Sept. 10, 2015, 5:17 p.m. UTC | #1
Arnout, All,

On 2015-09-10 18:55 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly:
> The comment line that explains that systemd needs a glibc toolchain and
> kernel headers >= 3.10 doesn't fit in the dialog box, which makes it
> look as if headers >= 3.1 are needed.
> 
> Abbreviate the comment a little by removing an 'an'. It still doesn't
> fit completely (only one trailing * is shown), but at least it's
> readable.
> 
> While we're at it, change the quoting style to " like we always use.
> 
> Reported-by: eschu on IRC
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  system/Config.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/system/Config.in b/system/Config.in
> index fad829d..03521fd 100644
> --- a/system/Config.in
> +++ b/system/Config.in
> @@ -90,7 +90,7 @@ config BR2_INIT_SYSTEMD
>  	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10
>  	select BR2_PACKAGE_SYSTEMD
>  
> -comment 'systemd needs an (e)glibc toolchain, headers >= 3.10'
> +comment "systemd needs (e)glibc toolchain, headers >= 3.10"
>  	depends on !(BR2_TOOLCHAIN_USES_GLIBC \
>  		&& BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10)
>  
> -- 
> 2.5.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Peter Korsgaard Sept. 10, 2015, 8:07 p.m. UTC | #2
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:

 > The comment line that explains that systemd needs a glibc toolchain and
 > kernel headers >= 3.10 doesn't fit in the dialog box, which makes it
 > look as if headers >= 3.1 are needed.

 > Abbreviate the comment a little by removing an 'an'. It still doesn't
 > fit completely (only one trailing * is shown), but at least it's
 > readable.

 > While we're at it, change the quoting style to " like we always use.

 > Reported-by: eschu on IRC
 > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Committed, thanks.
diff mbox

Patch

diff --git a/system/Config.in b/system/Config.in
index fad829d..03521fd 100644
--- a/system/Config.in
+++ b/system/Config.in
@@ -90,7 +90,7 @@  config BR2_INIT_SYSTEMD
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10
 	select BR2_PACKAGE_SYSTEMD
 
-comment 'systemd needs an (e)glibc toolchain, headers >= 3.10'
+comment "systemd needs (e)glibc toolchain, headers >= 3.10"
 	depends on !(BR2_TOOLCHAIN_USES_GLIBC \
 		&& BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10)