| Message ID | 1430660473-6997-1-git-send-email-thomas.petazzoni@free-electrons.com |
|---|---|
| State | Accepted |
| Commit | bc8423a8d485283e1c5c44026d3777173afb469a |
| Headers | show |
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes: > When configuring poppler, a shell error occurs: > ./configure: line 19741: test: x: unary operator expected > This is due to an invalid configure test, which is fixed by a newly > added patch. We patch the configure script directly because poppler > doesn't autoreconf properly. A patch on configure.ac has been > submitted upstream so that hopefully we can drop our patch in a future > release of poppler. > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Committed, thanks.
diff --git a/package/poppler/0001-Fix-invalid-shell-comparaison-in-libtiff-test.patch b/package/poppler/0001-Fix-invalid-shell-comparaison-in-libtiff-test.patch new file mode 100644 index 0000000..f40bee1 --- /dev/null +++ b/package/poppler/0001-Fix-invalid-shell-comparaison-in-libtiff-test.patch @@ -0,0 +1,23 @@ +Fix syntax issue in configure script + +The change is not done in configure.ac, because the package doesn't +autoreconf properly. + +Patch on configure.ac submitted upstream at +https://bugs.freedesktop.org/show_bug.cgi?id=90292. + +Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> + +Index: b/configure +=================================================================== +--- a/configure ++++ b/configure +@@ -19738,7 +19738,7 @@ + CXXFLAGS="$CXXFLAGS $LIBTIFF_CFLAGS" + LIBS="$LIBS $LIBTIFF_LIBS" + if test x$enable_libtiff = xyes; then +- if test x"$LIBTIFF_LIBS" != ; then ++ if test x"$LIBTIFF_LIBS" != x; then + ac_fn_cxx_check_func "$LINENO" "TIFFOpen" "ac_cv_func_TIFFOpen" + if test "x$ac_cv_func_TIFFOpen" = xyes; then : +
When configuring poppler, a shell error occurs: ./configure: line 19741: test: x: unary operator expected This is due to an invalid configure test, which is fixed by a newly added patch. We patch the configure script directly because poppler doesn't autoreconf properly. A patch on configure.ac has been submitted upstream so that hopefully we can drop our patch in a future release of poppler. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- ...invalid-shell-comparaison-in-libtiff-test.patch | 23 ++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 package/poppler/0001-Fix-invalid-shell-comparaison-in-libtiff-test.patch