diff mbox

[v7,10/13] Vivante drivers: bump to version 3.10.17-1.0.1

Message ID 1430406748-8493-11-git-send-email-jezz@sysmic.org
State Accepted
Headers show

Commit Message

Jérôme Pouiller April 30, 2015, 3:12 p.m. UTC
Tested-by: Gary Bisson <gary.bisson@boundarydevices.com>
Reviewed-by: Gary Bisson <gary.bisson@boundarydevices.com>
Signed-off-by: Jérôme Pouiller <jezz@sysmic.org>
---
 package/freescale-imx/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk           | 5 +++--
 .../x11r7/xdriver_xf86-video-imx-viv/xdriver_xf86-video-imx-viv.mk   | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

Comments

Thomas Petazzoni May 1, 2015, 8:51 p.m. UTC | #1
Dear Jérôme Pouiller,

On Thu, 30 Apr 2015 17:12:25 +0200, Jérôme Pouiller wrote:
> Tested-by: Gary Bisson <gary.bisson@boundarydevices.com>
> Reviewed-by: Gary Bisson <gary.bisson@boundarydevices.com>
> Signed-off-by: Jérôme Pouiller <jezz@sysmic.org>
> ---
>  package/freescale-imx/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk           | 5 +++--
>  .../x11r7/xdriver_xf86-video-imx-viv/xdriver_xf86-video-imx-viv.mk   | 2 +-
>  2 files changed, 4 insertions(+), 3 deletions(-)

Applied, thanks. Is 3.10.17 the latest version of the GPU drivers? I
think my colleague Antoine Ténart used a more recent version with the
3.10.53 Freescale kernel. Antoine, can you clarify?

Thanks,

Thomas
Antoine Tenart May 4, 2015, 3:12 p.m. UTC | #2
Hi,

On Fri, May 01, 2015 at 10:51:09PM +0200, Thomas Petazzoni wrote:
> On Thu, 30 Apr 2015 17:12:25 +0200, Jérôme Pouiller wrote:
> > Tested-by: Gary Bisson <gary.bisson@boundarydevices.com>
> > Reviewed-by: Gary Bisson <gary.bisson@boundarydevices.com>
> > Signed-off-by: Jérôme Pouiller <jezz@sysmic.org>
> > ---
> >  package/freescale-imx/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk           | 5 +++--
> >  .../x11r7/xdriver_xf86-video-imx-viv/xdriver_xf86-video-imx-viv.mk   | 2 +-
> >  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> Applied, thanks. Is 3.10.17 the latest version of the GPU drivers? I
> think my colleague Antoine Ténart used a more recent version with the
> 3.10.53 Freescale kernel. Antoine, can you clarify?

The latest version of the Vivante drivers seems to be the 5.0.11.p4.1
one, at least that's what meta-fsl-arm is using since April, 2nd. I've
tested this new version with a 3.10.53 Freescale kernel, and it's
working fine.

You can see the version scheme does not follow the previous one, and
that's also true for other parts of this release: the binary name is
different and the sources aren't organized the same way.

Also, the package/freescale-imx/gpu-viv-bin-mx6q/0001-correct-HAL-include.patch
patch isn't needed anymore and some other minor modifications can be
done.

I'd be happy to send a patch, but because this isn't just a version bump
it's not (easily) possible to have both 3.10.17 and 5.0.11 versions to
live alongside. What's you thoughts on this?

Antoine
Thomas Petazzoni May 4, 2015, 3:15 p.m. UTC | #3
Hello,

On Mon, 4 May 2015 17:12:27 +0200, Antoine Ténart wrote:

> > Applied, thanks. Is 3.10.17 the latest version of the GPU drivers? I
> > think my colleague Antoine Ténart used a more recent version with the
> > 3.10.53 Freescale kernel. Antoine, can you clarify?
> 
> The latest version of the Vivante drivers seems to be the 5.0.11.p4.1
> one, at least that's what meta-fsl-arm is using since April, 2nd. I've
> tested this new version with a 3.10.53 Freescale kernel, and it's
> working fine.
> 
> You can see the version scheme does not follow the previous one, and
> that's also true for other parts of this release: the binary name is
> different and the sources aren't organized the same way.
> 
> Also, the package/freescale-imx/gpu-viv-bin-mx6q/0001-correct-HAL-include.patch
> patch isn't needed anymore and some other minor modifications can be
> done.
> 
> I'd be happy to send a patch, but because this isn't just a version bump
> it's not (easily) possible to have both 3.10.17 and 5.0.11 versions to
> live alongside. What's you thoughts on this?

Jérôme, Gary, would you be able to test the new version of the GPU
drivers, and see if they work with both 3.10.17 and 3.10.53 ?

Thanks,

Thomas
Gary Bisson May 5, 2015, 8:06 a.m. UTC | #4
Thomas, Antoine, All

On Mon, May 4, 2015 at 5:15 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Mon, 4 May 2015 17:12:27 +0200, Antoine Ténart wrote:
>
>> > Applied, thanks. Is 3.10.17 the latest version of the GPU drivers? I
>> > think my colleague Antoine Ténart used a more recent version with the
>> > 3.10.53 Freescale kernel. Antoine, can you clarify?
>>
>> The latest version of the Vivante drivers seems to be the 5.0.11.p4.1
>> one, at least that's what meta-fsl-arm is using since April, 2nd. I've
>> tested this new version with a 3.10.53 Freescale kernel, and it's
>> working fine.
>>
>> You can see the version scheme does not follow the previous one, and
>> that's also true for other parts of this release: the binary name is
>> different and the sources aren't organized the same way.
>>
>> Also, the package/freescale-imx/gpu-viv-bin-mx6q/0001-correct-HAL-include.patch
>> patch isn't needed anymore and some other minor modifications can be
>> done.
>>
>> I'd be happy to send a patch, but because this isn't just a version bump
>> it's not (easily) possible to have both 3.10.17 and 5.0.11 versions to
>> live alongside. What's you thoughts on this?
>
> Jérôme, Gary, would you be able to test the new version of the GPU
> drivers, and see if they work with both 3.10.17 and 3.10.53 ?

I'll try it out, but why don't we update the package and the kernel
versions at once. A quick glance at the git repos shows that there's a
3.10.53 version for QMX6, Nitrogen6x and all the Freescale boards.
Then the Wandboard doesn't appear to be maintained as it's still using
a 3.0.x kernel and the riotboard uses mainline kernel.

Regards,
Gary
Thomas Petazzoni May 5, 2015, 8:10 a.m. UTC | #5
Gary,

On Tue, 5 May 2015 10:06:11 +0200, Gary Bisson wrote:

> > Jérôme, Gary, would you be able to test the new version of the GPU
> > drivers, and see if they work with both 3.10.17 and 3.10.53 ?
> 
> I'll try it out, but why don't we update the package and the kernel
> versions at once. A quick glance at the git repos shows that there's a
> 3.10.53 version for QMX6, Nitrogen6x and all the Freescale boards.
> Then the Wandboard doesn't appear to be maintained as it's still using
> a 3.0.x kernel and the riotboard uses mainline kernel.

Well, you're only looking at boards that have a defconfig in Buildroot.
But I'm pretty sure there are lots of people using Buildroot on custom
i.MX6 boards, which may not necessarily be supported by all kernel
versions.

That being said, the jump from 3.10.17 to 3.10.53 is probably
relatively easy, so people having such custom i.MX6 boards could just
as well do the jump.

So, I'd indeed suggest to move all i.MX6 defconfigs in Buildroot to
3.10.53, and update the GPU drivers accordingly.

Best regards,

Thomas
Gary Bisson May 5, 2015, 9:07 a.m. UTC | #6
Thomas, All,

On Tue, May 5, 2015 at 10:10 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Gary,
>
> On Tue, 5 May 2015 10:06:11 +0200, Gary Bisson wrote:
>
>> > Jérôme, Gary, would you be able to test the new version of the GPU
>> > drivers, and see if they work with both 3.10.17 and 3.10.53 ?
>>
>> I'll try it out, but why don't we update the package and the kernel
>> versions at once. A quick glance at the git repos shows that there's a
>> 3.10.53 version for QMX6, Nitrogen6x and all the Freescale boards.
>> Then the Wandboard doesn't appear to be maintained as it's still using
>> a 3.0.x kernel and the riotboard uses mainline kernel.
>
> Well, you're only looking at boards that have a defconfig in Buildroot.
> But I'm pretty sure there are lots of people using Buildroot on custom
> i.MX6 boards, which may not necessarily be supported by all kernel
> versions.

Sure but the other way around applies too, like what Antoine had to do
when working on a 3.10.53 kernel.

> That being said, the jump from 3.10.17 to 3.10.53 is probably
> relatively easy, so people having such custom i.MX6 boards could just
> as well do the jump.

Agreed, although Freescale changed quite a few things in the display sub-system.

> So, I'd indeed suggest to move all i.MX6 defconfigs in Buildroot to
> 3.10.53, and update the GPU drivers accordingly.

I'll prepare patches to upgrade every packages to 3.10.53 GA release
and there's a few.

Antoine, do you have a patch ready for the GPU package? Because it
seems that it's not just a version bump:
https://github.com/Freescale/meta-fsl-arm/commit/74c86aa9639f6f20991ab64ea75177a017f8749a

Regards,
Gary
Thomas Petazzoni May 5, 2015, 9:13 a.m. UTC | #7
Gary,

On Tue, 5 May 2015 11:07:59 +0200, Gary Bisson wrote:

> > Well, you're only looking at boards that have a defconfig in Buildroot.
> > But I'm pretty sure there are lots of people using Buildroot on custom
> > i.MX6 boards, which may not necessarily be supported by all kernel
> > versions.
> 
> Sure but the other way around applies too, like what Antoine had to do
> when working on a 3.10.53 kernel.

Absolutely, but if the 3.10.53-compatible GPU drivers also work with
3.10.17, then we would have a situation where one single version of the
GPU drivers can address both 3.10.17 and 3.10.53 based configurations.
While what we have today only works for 3.10.17 based configurations.


> Antoine, do you have a patch ready for the GPU package? Because it
> seems that it's not just a version bump:
> https://github.com/Freescale/meta-fsl-arm/commit/74c86aa9639f6f20991ab64ea75177a017f8749a

Yes, Antoine does have such thing. Can you share it with Gary?

Thanks,

Thomas
Fabrice Mousset | GEOCEPT GmbH May 5, 2015, 9:15 a.m. UTC | #8
Gary,

> I'll try it out, but why don't we update the package and the kernel versions at
> once. A quick glance at the git repos shows that there's a
> 3.10.53 version for QMX6, Nitrogen6x and all the Freescale boards.
> Then the Wandboard doesn't appear to be maintained as it's still using a 3.0.x
> kernel and the riotboard uses mainline kernel.
> 

In fact, the Wandboard Linux kernel 3.10.53 is available on github ==> https://github.com/wandboard-org/linux/tree/wandboard_imx_3.10.53_1.1.0_ga

Best regards

Fabrice
Gary Bisson May 5, 2015, 9:20 a.m. UTC | #9
Hi Fabrice

On Tue, May 5, 2015 at 11:15 AM, Fabrice Mousset | GEOCEPT GmbH
<fabrice.mousset@geocept.com> wrote:
> Gary,
>
>> I'll try it out, but why don't we update the package and the kernel versions at
>> once. A quick glance at the git repos shows that there's a
>> 3.10.53 version for QMX6, Nitrogen6x and all the Freescale boards.
>> Then the Wandboard doesn't appear to be maintained as it's still using a 3.0.x
>> kernel and the riotboard uses mainline kernel.
>>
>
> In fact, the Wandboard Linux kernel 3.10.53 is available on github ==> https://github.com/wandboard-org/linux/tree/wandboard_imx_3.10.53_1.1.0_ga

Thanks for sharing this link! I actually wanted to say that the
Wandboard *defconfig* in Buildroot isn't maintained. Once the packages
will be updated, would you be willing to update the Wandboard
defconfig if you happen to have the board?

Thanks,
Gary
Fabrice Mousset | GEOCEPT GmbH May 5, 2015, 9:58 a.m. UTC | #10
Hi Gary

> Thanks for sharing this link! I actually wanted to say that the Wandboard
> *defconfig* in Buildroot isn't maintained. Once the packages will be updated,
> would you be willing to update the Wandboard defconfig if you happen to
> have the board?

Yes, I've got a Wandboard Quad, so I could upgrade defconfig for the Quad board.
This should also works for Dual and Solo board, there are minimal differences.
I'm a little busy at the moment, so I would do this in the next 2 or 3 days.
Is this okay for you?

Which packages should be integrated into the build/image? 
Of course the Vivante driver, but what else?

Regards

Fabrice
Gary Bisson May 5, 2015, 1:39 p.m. UTC | #11
Hi Fabrice,

On Tue, May 5, 2015 at 11:58 AM, Fabrice Mousset | GEOCEPT GmbH
<fabrice.mousset@geocept.com> wrote:
> Hi Gary
>
>> Thanks for sharing this link! I actually wanted to say that the Wandboard
>> *defconfig* in Buildroot isn't maintained. Once the packages will be updated,
>> would you be willing to update the Wandboard defconfig if you happen to
>> have the board?
>
> Yes, I've got a Wandboard Quad, so I could upgrade defconfig for the Quad board.
> This should also works for Dual and Solo board, there are minimal differences.
> I'm a little busy at the moment, so I would do this in the next 2 or 3 days.
> Is this okay for you?

Don't worry there's no rush, the GPU package isn't updated yet.
However it's great to know you are willing to update the defconfig, we
will ping you as soon as everything is ready.

> Which packages should be integrated into the build/image?
> Of course the Vivante driver, but what else?

Actually the Vivante package is the ultimate test to perform as it
requires a match between the libraries and the kernel driver version.
The rest of the packages (VPU, gstreamer plugins etc...) are good to
test but not mandatory I'd say.

Thanks,
Gary
Fabrice Mousset | GEOCEPT GmbH May 5, 2015, 1:47 p.m. UTC | #12
Hi Gary,

> Don't worry there's no rush, the GPU package isn't updated yet.
> However it's great to know you are willing to update the defconfig, we will
> ping you as soon as everything is ready.

Okay, so this will not be integrated in next BuildRoot release I presume.

 
> > Which packages should be integrated into the build/image?
> > Of course the Vivante driver, but what else?
> 
> Actually the Vivante package is the ultimate test to perform as it requires a
> match between the libraries and the kernel driver version.
> The rest of the packages (VPU, gstreamer plugins etc...) are good to test but
> not mandatory I'd say.

Okay, seems not to be too complicated to check.

> 
> Thanks,
> Gary

Your welcome ;-)

Fabrice
Gary Bisson May 5, 2015, 10:14 p.m. UTC | #13
Thomas, Antoine, Jerome, All

On Tue, May 5, 2015 at 11:13 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Gary,
>
> On Tue, 5 May 2015 11:07:59 +0200, Gary Bisson wrote:
>
>> > Well, you're only looking at boards that have a defconfig in Buildroot.
>> > But I'm pretty sure there are lots of people using Buildroot on custom
>> > i.MX6 boards, which may not necessarily be supported by all kernel
>> > versions.
>>
>> Sure but the other way around applies too, like what Antoine had to do
>> when working on a 3.10.53 kernel.
>
> Absolutely, but if the 3.10.53-compatible GPU drivers also work with
> 3.10.17, then we would have a situation where one single version of the
> GPU drivers can address both 3.10.17 and 3.10.53 based configurations.
> While what we have today only works for 3.10.17 based configurations.

Actually this is not the case, 3.10.53 gpu libs are not compatible
with 3.10.17 kernels, see the meta-fsl mailing list links below.
https://lists.yoctoproject.org/pipermail/meta-freescale/2015-April/013234.html
https://lists.yoctoproject.org/pipermail/meta-freescale/2015-April/013267.html

But the good news is that 3.14.28 and 3.10.53 kernels/libs are
compatible, so we could update to the 3.14.28 GA release directly.

Regards,
Gary
diff mbox

Patch

diff --git a/package/freescale-imx/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk b/package/freescale-imx/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk
index 6885012..0f199f1 100644
--- a/package/freescale-imx/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk
+++ b/package/freescale-imx/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk
@@ -4,10 +4,11 @@ 
 #
 ################################################################################
 
+GPU_VIV_BIN_MX6Q_BASE_VERSION = 3.10.17-1.0.1
 ifeq ($(BR2_ARM_EABIHF),y)
-GPU_VIV_BIN_MX6Q_VERSION = $(FREESCALE_IMX_VERSION)-hfp
+GPU_VIV_BIN_MX6Q_VERSION = $(GPU_VIV_BIN_MX6Q_BASE_VERSION)-hfp
 else
-GPU_VIV_BIN_MX6Q_VERSION = $(FREESCALE_IMX_VERSION)-sfp
+GPU_VIV_BIN_MX6Q_VERSION = $(GPU_VIV_BIN_MX6Q_BASE_VERSION)-sfp
 endif
 GPU_VIV_BIN_MX6Q_SITE = $(FREESCALE_IMX_SITE)
 GPU_VIV_BIN_MX6Q_SOURCE = gpu-viv-bin-mx6q-$(GPU_VIV_BIN_MX6Q_VERSION).bin
diff --git a/package/x11r7/xdriver_xf86-video-imx-viv/xdriver_xf86-video-imx-viv.mk b/package/x11r7/xdriver_xf86-video-imx-viv/xdriver_xf86-video-imx-viv.mk
index 44d98d5..eab7edf 100644
--- a/package/x11r7/xdriver_xf86-video-imx-viv/xdriver_xf86-video-imx-viv.mk
+++ b/package/x11r7/xdriver_xf86-video-imx-viv/xdriver_xf86-video-imx-viv.mk
@@ -4,7 +4,7 @@ 
 #
 ################################################################################
 
-XDRIVER_XF86_VIDEO_IMX_VIV_VERSION = $(FREESCALE_IMX_VERSION)
+XDRIVER_XF86_VIDEO_IMX_VIV_VERSION = 3.10.17-1.0.1
 XDRIVER_XF86_VIDEO_IMX_VIV_SITE = $(FREESCALE_IMX_SITE)
 XDRIVER_XF86_VIDEO_IMX_VIV_SOURCE = xserver-xorg-video-imx-viv-$(XDRIVER_XF86_VIDEO_IMX_VIV_VERSION).tar.gz
 XDRIVER_XF86_VIDEO_IMX_VIV_DEPENDENCIES = gpu-viv-bin-mx6q xserver_xorg-server \