| Message ID | 1428772436-16962-1-git-send-email-bernd.kuhls@t-online.de |
|---|---|
| State | Not Applicable |
| Headers | show |
Dear Bernd Kuhls, On Sat, 11 Apr 2015 19:13:56 +0200, Bernd Kuhls wrote: > > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> > --- > v2: Change default for all toolchain configurations (Thomas) Well, it's not actually changing the default for all toolchain configurations, since the modular X.org variant requires C++ support, while the KDrive variant does not. However, probably this doesn't matter. On such a change, I'd like to have a Acked-by from a few other Buildroot developers. Yann, Arnout, Gustavo, what do you think? Best regards, Thomas
Thomas, Bernd, All, On 2015-04-11 19:58 +0200, Thomas Petazzoni spake thusly: > On Sat, 11 Apr 2015 19:13:56 +0200, Bernd Kuhls wrote: > > > > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> > > --- > > v2: Change default for all toolchain configurations (Thomas) > > Well, it's not actually changing the default for all toolchain > configurations, since the modular X.org variant requires C++ support, > while the KDrive variant does not. > > However, probably this doesn't matter. On such a change, I'd like to > have a Acked-by from a few other Buildroot developers. Yann, Arnout, > Gustavo, what do you think? I would not mind much doing the switch to the modular Xserver by default. But that would mean proper dependency propagation (i.e. C++). However, an alternative solution would be to remove the 'default' clause altogether from the choice: - if C++ is available, the modular Xserver is enabled by default, being the first option in the choice; - if C++ is not enabled, then KDrive is enabled, being the only option in the choice. Regards, Yann E. MORIN.
Dear Yann E. MORIN, On Sat, 11 Apr 2015 20:13:30 +0200, Yann E. MORIN wrote: > I would not mind much doing the switch to the modular Xserver by > default. But that would mean proper dependency propagation (i.e. C++). I don't understand what you mean here. > However, an alternative solution would be to remove the 'default' clause > altogether from the choice: > > - if C++ is available, the modular Xserver is enabled by default, > being the first option in the choice; > > - if C++ is not enabled, then KDrive is enabled, being the only option > in the choice. Well, Bernd's patch is doing that in a perfectly fine way. If C++ is available, the default on modular will work. If C++ is not available, since the modular option will not be available, the only remaining option in the choice will be Kdrive, and it will be the selected option. Am I missing something? Thomas
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote in news:20150411181330.GL4221@free.fr: > - if C++ is available, the modular Xserver is enabled by default, > being the first option in the choice; Hi, my original patch proposal included this http://patchwork.ozlabs.org/patch/400833/ But is was nack´ed by Thomas ;) Regards, Bernd
Thomas, All, On 2015-04-11 20:18 +0200, Thomas Petazzoni spake thusly: > Dear Yann E. MORIN, > > On Sat, 11 Apr 2015 20:13:30 +0200, Yann E. MORIN wrote: > > > I would not mind much doing the switch to the modular Xserver by > > default. But that would mean proper dependency propagation (i.e. C++). > > I don't understand what you mean here. See below... > > However, an alternative solution would be to remove the 'default' clause > > altogether from the choice: > > > > - if C++ is available, the modular Xserver is enabled by default, > > being the first option in the choice; > > > > - if C++ is not enabled, then KDrive is enabled, being the only option > > in the choice. > > Well, Bernd's patch is doing that in a perfectly fine way. If C++ is > available, the default on modular will work. If C++ is not available, > since the modular option will not be available, the only remaining > option in the choice will be Kdrive, and it will be the selected option. > > Am I missing something? No, not really. Even though 'default' in Kconfig is not authoritative, and that's not even a warning to default to an option that has unmet dependencies, I still find it odd to default to that option. And since the default is defaulting to the first entry in the choice, it is no longer needed at all. At best, we could add a comment summarising the situation. Regards, Yann E. MORIN.
On 11/04/15 20:35, Yann E. MORIN wrote: > Thomas, All, > > On 2015-04-11 20:18 +0200, Thomas Petazzoni spake thusly: >> Dear Yann E. MORIN, >> >> On Sat, 11 Apr 2015 20:13:30 +0200, Yann E. MORIN wrote: >> >>> I would not mind much doing the switch to the modular Xserver by >>> default. But that would mean proper dependency propagation (i.e. C++). >> >> I don't understand what you mean here. > > See below... > >>> However, an alternative solution would be to remove the 'default' clause >>> altogether from the choice: >>> >>> - if C++ is available, the modular Xserver is enabled by default, >>> being the first option in the choice; >>> >>> - if C++ is not enabled, then KDrive is enabled, being the only optionhttp://patchwork.ozlabs.org/patch/400833/ >>> in the choice. >> >> Well, Bernd's patch is doing that in a perfectly fine way. If C++ is >> available, the default on modular will work. If C++ is not available, >> since the modular option will not be available, the only remaining >> option in the choice will be Kdrive, and it will be the selected option. >> >> Am I missing something? > > No, not really. > > Even though 'default' in Kconfig is not authoritative, and that's not > even a warning to default to an option that has unmet dependencies, I > still find it odd to default to that option. > > And since the default is defaulting to the first entry in the choice, it > is no longer needed at all. > > At best, we could add a comment summarising the situation. Then it's better to go for Bernd's original patch [1] because it explicitly gives the different defaults for the different situations. ThomasP's comment to that was that it is strange that a choice default depends on the toolchain options. It makes sense to make a default depend on the arch options, because we consider that something that can't be controlled by the user, but changing the default based on toolchain options sounds a bit weird. But of course, we already have a bunch of those, although it's not as explicit as in [1]. E.g. the media backend of dvdrw-tools defaults to cdrkit if kernel-headers >= 3.0, else it defaults to xorriso; gpu-amd-bin-mx51 output defaults to X11 if X11 is selected, else it defaults to framebuffer. So I'm in favour of going back to [1]. Regards, Arnout [1] http://patchwork.ozlabs.org/patch/400833/
diff --git a/package/x11r7/xserver_xorg-server/Config.in b/package/x11r7/xserver_xorg-server/Config.in index 1123f3b..54d7c24 100644 --- a/package/x11r7/xserver_xorg-server/Config.in +++ b/package/x11r7/xserver_xorg-server/Config.in @@ -58,7 +58,7 @@ if BR2_PACKAGE_XSERVER_XORG_SERVER choice prompt "X Window System server type" - default BR2_PACKAGE_XSERVER_XORG_SERVER_KDRIVE + default BR2_PACKAGE_XSERVER_XORG_SERVER_MODULAR help Select the X Window System server to use
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> --- v2: Change default for all toolchain configurations (Thomas) package/x11r7/xserver_xorg-server/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)