diff mbox

dstat: add missing runtime dependency for Python curses

Message ID 1424896278-3731-1-git-send-email-yegorslists@googlemail.com
State Rejected
Headers show

Commit Message

Yegor Yefremov Feb. 25, 2015, 8:31 p.m. UTC 
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 package/dstat/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Peter Korsgaard Feb. 27, 2015, 3:10 p.m. UTC | #1 
>>>>> "Yegor" == Yegor Yefremov <yegorslists@googlemail.com> writes:

 > Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
 > ---
 >  package/dstat/Config.in | 1 +
 >  1 file changed, 1 insertion(+)

 > diff --git a/package/dstat/Config.in b/package/dstat/Config.in
 > index 63db87b..66a9789 100644
 > --- a/package/dstat/Config.in
 > +++ b/package/dstat/Config.in
 > @@ -4,6 +4,7 @@ config BR2_PACKAGE_DSTAT
 >  	depends on BR2_USE_MMU # python
 >  	depends on BR2_TOOLCHAIN_HAS_THREADS # python
 >  	select BR2_PACKAGE_PYTHON
 > +	select BR2_PACKAGE_PYTHON_CURSES # runtime

From the dstat source it seems like python-curses isn't required, so
this is wrong:

def gettermcolor(color=True):
    "Return whether the system can use colors or not"
    if color and sys.stdout.isatty():
        try:
            import curses
            curses.setupterm()
            if curses.tigetnum('colors') < 0:
                return False
        except:
            print >>sys.stderr, 'Color support is disabled, python-curses is not installed.'
            return False
    return color
diff mbox

Patch

diff --git a/package/dstat/Config.in b/package/dstat/Config.in
index 63db87b..66a9789 100644
--- a/package/dstat/Config.in
+++ b/package/dstat/Config.in
@@ -4,6 +4,7 @@  config BR2_PACKAGE_DSTAT
 	depends on BR2_USE_MMU # python
 	depends on BR2_TOOLCHAIN_HAS_THREADS # python
 	select BR2_PACKAGE_PYTHON
+	select BR2_PACKAGE_PYTHON_CURSES # runtime
 	help
 	  Dstat, written in Python, is a versatile replacement for vmstat,
 	  iostat, netstat and ifstat. Dstat overcomes some of their limitations