diff mbox

autoconf-archive: add hash

Message ID 1424874186-10571-1-git-send-email-bgolaszewski@baylibre.com
State Changes Requested
Headers show

Commit Message

Bartosz Golaszewski Feb. 25, 2015, 2:23 p.m. UTC 
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
 package/autoconf-archive/autoconf-archive.hash | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 package/autoconf-archive/autoconf-archive.hash

Comments

Thomas Petazzoni March 4, 2015, 10:44 p.m. UTC | #1 
Dear Bartosz Golaszewski,

On Wed, 25 Feb 2015 15:23:06 +0100, Bartosz Golaszewski wrote:

> diff --git a/package/autoconf-archive/autoconf-archive.hash b/package/autoconf-archive/autoconf-archive.hash
> new file mode 100644
> index 0000000..9abb905
> --- /dev/null
> +++ b/package/autoconf-archive/autoconf-archive.hash
> @@ -0,0 +1 @@
> +sha512 54382adcf55b9dd126de6727c034cae7c72c8217c9979d3b889705c3bfe41ec8329621dea5ff592ebf7e530775ce96faf47baffe36e8fedf9cd78c8dc423932e autoconf-archive-2015.02.04.tar.xz

There should be a comment above that says where the hash was found:
from which URL, or computed locally.

And if it's computed locally, our current rule is to use sha256, not
sha512.

Can you fix and resend? Thanks!

Thomas
Bartosz Golaszewski March 5, 2015, 10:21 a.m. UTC | #2 
2015-03-04 23:44 GMT+01:00 Thomas Petazzoni
<thomas.petazzoni@free-electrons.com>:
> Dear Bartosz Golaszewski,
>
> On Wed, 25 Feb 2015 15:23:06 +0100, Bartosz Golaszewski wrote:
>
>> diff --git a/package/autoconf-archive/autoconf-archive.hash b/package/autoconf-archive/autoconf-archive.hash
>> new file mode 100644
>> index 0000000..9abb905
>> --- /dev/null
>> +++ b/package/autoconf-archive/autoconf-archive.hash
>> @@ -0,0 +1 @@
>> +sha512 54382adcf55b9dd126de6727c034cae7c72c8217c9979d3b889705c3bfe41ec8329621dea5ff592ebf7e530775ce96faf47baffe36e8fedf9cd78c8dc423932e autoconf-archive-2015.02.04.tar.xz
>
> There should be a comment above that says where the hash was found:
> from which URL, or computed locally.
>
> And if it's computed locally, our current rule is to use sha256, not
> sha512.
>
> Can you fix and resend? Thanks!

Sure thing!

Bart
diff mbox

Patch

diff --git a/package/autoconf-archive/autoconf-archive.hash b/package/autoconf-archive/autoconf-archive.hash
new file mode 100644
index 0000000..9abb905
--- /dev/null
+++ b/package/autoconf-archive/autoconf-archive.hash
@@ -0,0 +1 @@ 
+sha512 54382adcf55b9dd126de6727c034cae7c72c8217c9979d3b889705c3bfe41ec8329621dea5ff592ebf7e530775ce96faf47baffe36e8fedf9cd78c8dc423932e autoconf-archive-2015.02.04.tar.xz