| Message ID | 1424516137-5016-1-git-send-email-romain.naour@openwide.fr |
|---|---|
| State | Accepted |
| Headers | show |
Hi all, Le 21/02/2015 11:55, Romain Naour a écrit : > Signed-off-by: Romain Naour <romain.naour@openwide.fr> > --- > package/x11r7/libxcb/libxcb.mk | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/package/x11r7/libxcb/libxcb.mk b/package/x11r7/libxcb/libxcb.mk > index da2f192..f4a3aa9 100644 > --- a/package/x11r7/libxcb/libxcb.mk > +++ b/package/x11r7/libxcb/libxcb.mk > @@ -16,8 +16,8 @@ LIBXCB_DEPENDENCIES = \ > host-libxslt libpthread-stubs xcb-proto xlib_libXdmcp xlib_libXau \ > host-xcb-proto host-python host-pkgconf > > -LIBXCB_CONF_OPTS = --disable-build-docs > -HOST_LIBXCB_CONF_OPTS = --disable-build-docs > +LIBXCB_CONF_OPTS = --with-doxygen=no > +HOST_LIBXCB_CONF_OPTS = --with-doxygen=no > Can we add --with-doxygen=no to pkg-autotools.mk instead ? Best regard, Romain
Dear Romain Naour, On Sat, 21 Feb 2015 11:55:37 +0100, Romain Naour wrote: > Signed-off-by: Romain Naour <romain.naour@openwide.fr> > --- > package/x11r7/libxcb/libxcb.mk | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied to master, thanks. Thomas
Dear Romain Naour,
On Sat, 21 Feb 2015 12:13:40 +0100, Romain Naour wrote:
> Can we add --with-doxygen=no to pkg-autotools.mk instead ?
As Yann said on IRC, it depends on the number of packages that would
benefit from it. And it seems only three packages would benefit from it:
package/libhid/libhid.mk: --without-doxygen \
package/sofia-sip/sofia-sip.mk:SOFIA_SIP_CONF_OPTS = --with-doxygen=no
package/x11r7/libxcb/libxcb.mk:LIBXCB_CONF_OPTS = --with-doxygen=no
package/x11r7/libxcb/libxcb.mk:HOST_LIBXCB_CONF_OPTS = --with-doxygen=no
On the other hand --disable-doxygen-docs, or --disable-doxygen seem to
be used by many more packages:
package/cppunit/cppunit.mk:CPPUNIT_CONF_OPTS = --disable-doxygen
package/dbus-cpp/dbus-cpp.mk:DBUS_CPP_CONF_OPTS = --disable-examples --disable-tests --disable-doxygen-docs \
package/dbus-cpp/dbus-cpp.mk: --disable-doxygen-docs --disable-ecore --disable-glib
package/dbus-glib/dbus-glib.mk: --disable-doxygen-docs \
package/dbus-glib/dbus-glib.mk: --disable-doxygen-docs \
package/dbus/dbus.mk: --disable-doxygen-docs \
package/dbus/dbus.mk: --disable-doxygen-docs \
package/libv4l/libv4l.mk:LIBV4L_CONF_OPTS = --disable-doxygen-doc
package/log4cxx/log4cxx.mk: --disable-doxygen \
package/matchbox/matchbox-lib/matchbox-lib.mk:MATCHBOX_LIB_CONF_OPTS = --enable-expat --disable-doxygen-docs
package/ola/ola.mk: --disable-doxygen-html \
package/ola/ola.mk: --disable-doxygen-doc
package/openocd/openocd.mk: --disable-doxygen-html \
package/openocd/openocd.mk: --disable-doxygen-html \
Bottom line: my preference is to keep this at a per-package level.
Best regards,
Thomas
diff --git a/package/x11r7/libxcb/libxcb.mk b/package/x11r7/libxcb/libxcb.mk index da2f192..f4a3aa9 100644 --- a/package/x11r7/libxcb/libxcb.mk +++ b/package/x11r7/libxcb/libxcb.mk @@ -16,8 +16,8 @@ LIBXCB_DEPENDENCIES = \ host-libxslt libpthread-stubs xcb-proto xlib_libXdmcp xlib_libXau \ host-xcb-proto host-python host-pkgconf -LIBXCB_CONF_OPTS = --disable-build-docs -HOST_LIBXCB_CONF_OPTS = --disable-build-docs +LIBXCB_CONF_OPTS = --with-doxygen=no +HOST_LIBXCB_CONF_OPTS = --with-doxygen=no $(eval $(autotools-package)) $(eval $(host-autotools-package))
Signed-off-by: Romain Naour <romain.naour@openwide.fr> --- package/x11r7/libxcb/libxcb.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)