diff mbox

imx6slevk: fix uImage load address

Message ID 1421578654-11857-1-git-send-email-gilles.talis@gmail.com
State Superseded
Headers show

Commit Message

Gilles Talis Jan. 18, 2015, 10:57 a.m. UTC
i.MX6 SoloLite SoC has a different external memory base address
than the other i.MX6 family SoCs (0x80000000 for i.MX6 SoloLite
vs 0x10000000 for the others).

Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
---
 configs/freescale_imx6sololiteevk_defconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yann E. MORIN Jan. 19, 2015, 10:33 p.m. UTC | #1
Gilles, All,

On 2015-01-18 11:57 +0100, Gilles Talis spake thusly:
> i.MX6 SoloLite SoC has a different external memory base address
> than the other i.MX6 family SoCs (0x80000000 for i.MX6 SoloLite
> vs 0x10000000 for the others).

Could you share a pointer to the reference for this, please?

It is a bit difficult to ACK such a patch without such areference, for
those that do not have the board / the SoC.

Of course, the change is pretty obvious, though, so this gets my:

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

which you can add when you respin with a reference pointer (unless it
gets applied in the meantime).

Regards,
Yann E. MORIN.

> Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
> ---
>  configs/freescale_imx6sololiteevk_defconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configs/freescale_imx6sololiteevk_defconfig b/configs/freescale_imx6sololiteevk_defconfig
> index f8ecc7b..2bb47af 100644
> --- a/configs/freescale_imx6sololiteevk_defconfig
> +++ b/configs/freescale_imx6sololiteevk_defconfig
> @@ -11,7 +11,7 @@ BR2_LINUX_KERNEL_CUSTOM_GIT=y
>  BR2_LINUX_KERNEL_CUSTOM_REPO_URL="git://git.freescale.com/imx/linux-2.6-imx.git"
>  BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="rel_imx_3.10.17_1.0.0_ga"
>  BR2_LINUX_KERNEL_DEFCONFIG="imx_v7"
> -BR2_LINUX_KERNEL_UIMAGE_LOADADDR="0x10008000"
> +BR2_LINUX_KERNEL_UIMAGE_LOADADDR="0x80008000"
>  BR2_LINUX_KERNEL_DTS_SUPPORT=y
>  BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6sl-evk"
>  
> -- 
> 1.7.10.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Gilles Talis Jan. 20, 2015, 3:46 p.m. UTC | #2
Yann, all

2015-01-19 23:33 GMT+01:00 Yann E. MORIN <yann.morin.1998@free.fr>:
> Gilles, All,
>
> On 2015-01-18 11:57 +0100, Gilles Talis spake thusly:
>> i.MX6 SoloLite SoC has a different external memory base address
>> than the other i.MX6 family SoCs (0x80000000 for i.MX6 SoloLite
>> vs 0x10000000 for the others).
>
> Could you share a pointer to the reference for this, please?
Yes, this makes sense. Whilst I was looking for this pointer, I
stumbled across this u-boot mailing list thread where the problem is
actually solved:
http://lists.denx.de/pipermail/u-boot/2014-December/199881.html

Would that be enough? or would you prefer I provide the links to the
i.MX6 processors reference manuals where the DDR controller base
address information is stored.

thanks
Gilles.
Yann E. MORIN Jan. 21, 2015, 5:23 p.m. UTC | #3
Gilles, All,

On 2015-01-20 16:46 +0100, Gilles Talis spake thusly:
> 2015-01-19 23:33 GMT+01:00 Yann E. MORIN <yann.morin.1998@free.fr>:
> > Gilles, All,
> >
> > On 2015-01-18 11:57 +0100, Gilles Talis spake thusly:
> >> i.MX6 SoloLite SoC has a different external memory base address
> >> than the other i.MX6 family SoCs (0x80000000 for i.MX6 SoloLite
> >> vs 0x10000000 for the others).
> >
> > Could you share a pointer to the reference for this, please?
> Yes, this makes sense. Whilst I was looking for this pointer, I
> stumbled across this u-boot mailing list thread where the problem is
> actually solved:
> http://lists.denx.de/pipermail/u-boot/2014-December/199881.html

That's pretty OK to add as a reference (the U-Boot guys probably know
what they are doing! ;-) ).

> Would that be enough? or would you prefer I provide the links to the
> i.MX6 processors reference manuals where the DDR controller base
> address information is stored.

Well, if you have such info, then be free to add, that would be great!
Otherwise, the U-Boot reference should be enough.

Thanks! :-)

Regards,
Yann E. MORIN.
diff mbox

Patch

diff --git a/configs/freescale_imx6sololiteevk_defconfig b/configs/freescale_imx6sololiteevk_defconfig
index f8ecc7b..2bb47af 100644
--- a/configs/freescale_imx6sololiteevk_defconfig
+++ b/configs/freescale_imx6sololiteevk_defconfig
@@ -11,7 +11,7 @@  BR2_LINUX_KERNEL_CUSTOM_GIT=y
 BR2_LINUX_KERNEL_CUSTOM_REPO_URL="git://git.freescale.com/imx/linux-2.6-imx.git"
 BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="rel_imx_3.10.17_1.0.0_ga"
 BR2_LINUX_KERNEL_DEFCONFIG="imx_v7"
-BR2_LINUX_KERNEL_UIMAGE_LOADADDR="0x10008000"
+BR2_LINUX_KERNEL_UIMAGE_LOADADDR="0x80008000"
 BR2_LINUX_KERNEL_DTS_SUPPORT=y
 BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6sl-evk"