diff mbox

[1/1] package/mke2img: "/bin/bash" => "/usr/bin/env bash" shebang

Message ID 1420749079-29099-1-git-send-email-bjorn.forsman@gmail.com
State Accepted
Headers show

Commit Message

Bjørn Forsman Jan. 8, 2015, 8:31 p.m. UTC
For portability. All other Buildroot scripts (i.e. scripts that run on
host) already use the "/usr/bin/env bash" shebang.

This change is needed for NixOS, which lacks a global /bin/bash.

Signed-off-by: Bjørn Forsman <bjorn.forsman@gmail.com>
---
 package/mke2img/mke2img | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Petazzoni Jan. 8, 2015, 8:35 p.m. UTC | #1
Dear Bjørn Forsman,

On Thu,  8 Jan 2015 21:31:19 +0100, Bjørn Forsman wrote:
> For portability. All other Buildroot scripts (i.e. scripts that run on
> host) already use the "/usr/bin/env bash" shebang.
> 
> This change is needed for NixOS, which lacks a global /bin/bash.
> 
> Signed-off-by: Bjørn Forsman <bjorn.forsman@gmail.com>
> ---
>  package/mke2img/mke2img | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks!

(See: we can be fast! :-))

Thomas
Bjørn Forsman Jan. 8, 2015, 8:36 p.m. UTC | #2
On 8 January 2015 at 21:35, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Bjørn Forsman,
>
> On Thu,  8 Jan 2015 21:31:19 +0100, Bjørn Forsman wrote:
>> For portability. All other Buildroot scripts (i.e. scripts that run on
>> host) already use the "/usr/bin/env bash" shebang.
>>
>> This change is needed for NixOS, which lacks a global /bin/bash.
>>
>> Signed-off-by: Bjørn Forsman <bjorn.forsman@gmail.com>
>> ---
>>  package/mke2img/mke2img | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Applied, thanks!
>
> (See: we can be fast! :-))

Indeed! Thanks :-)

- Bjørn
diff mbox

Patch

diff --git a/package/mke2img/mke2img b/package/mke2img/mke2img
index 68da6ed..5e2f62f 100755
--- a/package/mke2img/mke2img
+++ b/package/mke2img/mke2img
@@ -1,4 +1,4 @@ 
-#!/bin/bash
+#!/usr/bin/env bash
 
 # Buildroot wrapper to the collection of ext2/3/4 filesystem tools:
 # - genext2fs, to generate ext2 filesystem images