| Message ID | 1419324901-14003-2-git-send-email-fabio.porcedda@gmail.com |
|---|---|
| State | Rejected |
| Headers | show |
Hello, On Tue, 23 Dec 2014 09:54:58 +0100, Fabio Porcedda wrote: > Rename the variable "QUIET" to "BR_QUIET" accordingly to the convention > that internal variables should be named BR_XXX. > > Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> Do we really want all internal variables to be named BR_* ? Like HOST_CONFIGURE_OPTS, TARGET_CONFIGURE_OPTS, TARGET_MAKE_ENV and al. ? I'm not sure we want to do this, do we? Thomas
On Tue, Dec 23, 2014 at 11:17 AM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Hello, > > On Tue, 23 Dec 2014 09:54:58 +0100, Fabio Porcedda wrote: >> Rename the variable "QUIET" to "BR_QUIET" accordingly to the convention >> that internal variables should be named BR_XXX. >> >> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> > > Do we really want all internal variables to be named BR_* ? Like > HOST_CONFIGURE_OPTS, TARGET_CONFIGURE_OPTS, TARGET_MAKE_ENV and al. ? > I'm not sure we want to do this, do we? On Wed, Nov 26, 2014 at 10:35 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: <snip> > Also, in retrospect, QUIET was not a really good name for this variable > in the Makefile. It would have been better if it were named BR_QUIET. > But that was introduced way before we decided on a variable naming > convention... :-/ So which naming conventions Yann was referring? BR
On Tue, Dec 23, 2014 at 11:51 AM, Fabio Porcedda <fabio.porcedda@gmail.com> wrote: > On Tue, Dec 23, 2014 at 11:17 AM, Thomas Petazzoni > <thomas.petazzoni@free-electrons.com> wrote: >> Hello, >> >> On Tue, 23 Dec 2014 09:54:58 +0100, Fabio Porcedda wrote: >>> Rename the variable "QUIET" to "BR_QUIET" accordingly to the convention >>> that internal variables should be named BR_XXX. >>> >>> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> >> >> Do we really want all internal variables to be named BR_* ? Like >> HOST_CONFIGURE_OPTS, TARGET_CONFIGURE_OPTS, TARGET_MAKE_ENV and al. ? >> I'm not sure we want to do this, do we? > > On Wed, Nov 26, 2014 at 10:35 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > <snip> >> Also, in retrospect, QUIET was not a really good name for this variable >> in the Makefile. It would have been better if it were named BR_QUIET. >> But that was introduced way before we decided on a variable naming >> convention... :-/ > > So which naming conventions Yann was referring? Hi Yann, Can you please explain further your opinion? BR
Fabio, All, On 2014-12-28 17:24 +0100, Fabio Porcedda spake thusly: > On Tue, Dec 23, 2014 at 11:51 AM, Fabio Porcedda > <fabio.porcedda@gmail.com> wrote: > > On Tue, Dec 23, 2014 at 11:17 AM, Thomas Petazzoni > > <thomas.petazzoni@free-electrons.com> wrote: > >> Hello, > >> > >> On Tue, 23 Dec 2014 09:54:58 +0100, Fabio Porcedda wrote: > >>> Rename the variable "QUIET" to "BR_QUIET" accordingly to the convention > >>> that internal variables should be named BR_XXX. > >>> > >>> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> > >> > >> Do we really want all internal variables to be named BR_* ? Like > >> HOST_CONFIGURE_OPTS, TARGET_CONFIGURE_OPTS, TARGET_MAKE_ENV and al. ? > >> I'm not sure we want to do this, do we? > > > > On Wed, Nov 26, 2014 at 10:35 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > <snip> > >> Also, in retrospect, QUIET was not a really good name for this variable > >> in the Makefile. It would have been better if it were named BR_QUIET. > >> But that was introduced way before we decided on a variable naming > >> convention... :-/ > > > > So which naming conventions Yann was referring? > > Hi Yann, > Can you please explain further your opinion? Oh, sorry, it seems I was not explicit enough in my mail... What I said was "QUIET was not a really good name [...] that was introduced way before we decided on a variable naming convention..." I did not want to make it sound like we should rename it, sorry. I agree with Thomas here: we should keep QUIET as-is. Sorry, sorry for the confusion... :-( Regards, Yann E. MORIN.
On Sun, Dec 28, 2014 at 10:57 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: > Fabio, All, > > On 2014-12-28 17:24 +0100, Fabio Porcedda spake thusly: >> On Tue, Dec 23, 2014 at 11:51 AM, Fabio Porcedda >> <fabio.porcedda@gmail.com> wrote: >> > On Tue, Dec 23, 2014 at 11:17 AM, Thomas Petazzoni >> > <thomas.petazzoni@free-electrons.com> wrote: >> >> Hello, >> >> >> >> On Tue, 23 Dec 2014 09:54:58 +0100, Fabio Porcedda wrote: >> >>> Rename the variable "QUIET" to "BR_QUIET" accordingly to the convention >> >>> that internal variables should be named BR_XXX. >> >>> >> >>> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> >> >> >> >> Do we really want all internal variables to be named BR_* ? Like >> >> HOST_CONFIGURE_OPTS, TARGET_CONFIGURE_OPTS, TARGET_MAKE_ENV and al. ? >> >> I'm not sure we want to do this, do we? >> > >> > On Wed, Nov 26, 2014 at 10:35 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: >> > <snip> >> >> Also, in retrospect, QUIET was not a really good name for this variable >> >> in the Makefile. It would have been better if it were named BR_QUIET. >> >> But that was introduced way before we decided on a variable naming >> >> convention... :-/ >> > >> > So which naming conventions Yann was referring? >> >> Hi Yann, >> Can you please explain further your opinion? > > Oh, sorry, it seems I was not explicit enough in my mail... > > What I said was "QUIET was not a really good name [...] that was > introduced way before we decided on a variable naming convention..." > > I did not want to make it sound like we should rename it, sorry. > > I agree with Thomas here: we should keep QUIET as-is. > > Sorry, sorry for the confusion... :-( Ok, I will sent an updated patch set without the renaming patch. BR
On Tue, Dec 30, 2014 at 11:59 AM, Fabio Porcedda <fabio.porcedda@gmail.com> wrote: > On Sun, Dec 28, 2014 at 10:57 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: >> Fabio, All, >> >> On 2014-12-28 17:24 +0100, Fabio Porcedda spake thusly: >>> On Tue, Dec 23, 2014 at 11:51 AM, Fabio Porcedda >>> <fabio.porcedda@gmail.com> wrote: >>> > On Tue, Dec 23, 2014 at 11:17 AM, Thomas Petazzoni >>> > <thomas.petazzoni@free-electrons.com> wrote: >>> >> Hello, >>> >> >>> >> On Tue, 23 Dec 2014 09:54:58 +0100, Fabio Porcedda wrote: >>> >>> Rename the variable "QUIET" to "BR_QUIET" accordingly to the convention >>> >>> that internal variables should be named BR_XXX. >>> >>> >>> >>> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> >>> >> >>> >> Do we really want all internal variables to be named BR_* ? Like >>> >> HOST_CONFIGURE_OPTS, TARGET_CONFIGURE_OPTS, TARGET_MAKE_ENV and al. ? >>> >> I'm not sure we want to do this, do we? >>> > >>> > On Wed, Nov 26, 2014 at 10:35 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote: >>> > <snip> >>> >> Also, in retrospect, QUIET was not a really good name for this variable >>> >> in the Makefile. It would have been better if it were named BR_QUIET. >>> >> But that was introduced way before we decided on a variable naming >>> >> convention... :-/ >>> > >>> > So which naming conventions Yann was referring? >>> >>> Hi Yann, >>> Can you please explain further your opinion? >> >> Oh, sorry, it seems I was not explicit enough in my mail... >> >> What I said was "QUIET was not a really good name [...] that was >> introduced way before we decided on a variable naming convention..." >> >> I did not want to make it sound like we should rename it, sorry. >> >> I agree with Thomas here: we should keep QUIET as-is. >> >> Sorry, sorry for the confusion... :-( > > Ok, I will sent an updated patch set without the renaming patch. I've sent an updated patch set: http://lists.busybox.net/pipermail/buildroot/2014-December/116079.html BR
diff --git a/Makefile b/Makefile index 10445a2..3baa709 100644 --- a/Makefile +++ b/Makefile @@ -303,7 +303,7 @@ GNU_HOST_NAME := $(shell support/gnuconfig/config.guess) TARGETS := # silent mode requested? -QUIET := $(if $(findstring s,$(MAKEFLAGS)),-q) +BR_QUIET := $(if $(findstring s,$(MAKEFLAGS)),-q) # Strip off the annoying quoting ARCH := $(call qstrip,$(BR2_ARCH)) diff --git a/package/Makefile.in b/package/Makefile.in index a63a2e8..bad49c3 100644 --- a/package/Makefile.in +++ b/package/Makefile.in @@ -223,7 +223,7 @@ BISON := $(shell which bison || type -p bison) SED := $(shell which sed || type -p sed) -i -e UNZIP := $(shell which unzip || type -p unzip) -q -APPLY_PATCHES = support/scripts/apply-patches.sh $(if $(QUIET),-s) +APPLY_PATCHES = support/scripts/apply-patches.sh $(if $(BR_QUIET),-s) HOST_CPPFLAGS = -I$(HOST_DIR)/usr/include HOST_CFLAGS ?= -O2 diff --git a/package/berkeleydb/berkeleydb.mk b/package/berkeleydb/berkeleydb.mk index 30fc518..a7b8a70 100644 --- a/package/berkeleydb/berkeleydb.mk +++ b/package/berkeleydb/berkeleydb.mk @@ -25,7 +25,7 @@ define BERKELEYDB_CONFIGURE_CMDS (cd $(@D)/build_unix; rm -rf config.cache; \ $(TARGET_CONFIGURE_OPTS) \ $(TARGET_CONFIGURE_ARGS) \ - ../dist/configure $(QUIET) \ + ../dist/configure $(BR_QUIET) \ --target=$(GNU_TARGET_NAME) \ --host=$(GNU_TARGET_NAME) \ --build=$(GNU_HOST_NAME) \ diff --git a/package/gcc/gcc-final/gcc-final.mk b/package/gcc/gcc-final/gcc-final.mk index c014bc5..875579c 100644 --- a/package/gcc/gcc-final/gcc-final.mk +++ b/package/gcc/gcc-final/gcc-final.mk @@ -36,7 +36,7 @@ define HOST_GCC_FINAL_CONFIGURE_CMDS --prefix="$(HOST_DIR)/usr" \ --sysconfdir="$(HOST_DIR)/etc" \ --enable-static \ - $(QUIET) $(HOST_GCC_FINAL_CONF_OPTS) \ + $(BR_QUIET) $(HOST_GCC_FINAL_CONF_OPTS) \ ) endef diff --git a/package/pkg-autotools.mk b/package/pkg-autotools.mk index b20e20e..4bad10f 100644 --- a/package/pkg-autotools.mk +++ b/package/pkg-autotools.mk @@ -204,7 +204,7 @@ define $(2)_CONFIGURE_CMDS $$(DISABLE_IPV6) \ $$(ENABLE_DEBUG) \ $$(SHARED_STATIC_LIBS_OPTS) \ - $$(QUIET) $$($$(PKG)_CONF_OPTS) \ + $$(BR_QUIET) $$($$(PKG)_CONF_OPTS) \ ) endef else @@ -233,7 +233,7 @@ define $(2)_CONFIGURE_CMDS --with-xmlto=no \ --with-fop=no \ --disable-dependency-tracking \ - $$(QUIET) $$($$(PKG)_CONF_OPTS) \ + $$(BR_QUIET) $$($$(PKG)_CONF_OPTS) \ ) endef endif diff --git a/package/pkg-download.mk b/package/pkg-download.mk index ba72fc1..884daff 100644 --- a/package/pkg-download.mk +++ b/package/pkg-download.mk @@ -8,14 +8,14 @@ ################################################################################ # Download method commands -export WGET := $(call qstrip,$(BR2_WGET)) $(QUIET) +export WGET := $(call qstrip,$(BR2_WGET)) $(BR_QUIET) export SVN := $(call qstrip,$(BR2_SVN)) export CVS := $(call qstrip,$(BR2_CVS)) export BZR := $(call qstrip,$(BR2_BZR)) export GIT := $(call qstrip,$(BR2_GIT)) -export HG := $(call qstrip,$(BR2_HG)) $(QUIET) -export SCP := $(call qstrip,$(BR2_SCP)) $(QUIET) -SSH := $(call qstrip,$(BR2_SSH)) $(QUIET) +export HG := $(call qstrip,$(BR2_HG)) $(BR_QUIET) +export SCP := $(call qstrip,$(BR2_SCP)) $(BR_QUIET) +SSH := $(call qstrip,$(BR2_SSH)) $(BR_QUIET) export LOCALFILES := $(call qstrip,$(BR2_LOCALFILES)) DL_WRAPPER = support/download/dl-wrapper
Rename the variable "QUIET" to "BR_QUIET" accordingly to the convention that internal variables should be named BR_XXX. Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com> --- Notes: v5: - add this patch (Yann) Makefile | 2 +- package/Makefile.in | 2 +- package/berkeleydb/berkeleydb.mk | 2 +- package/gcc/gcc-final/gcc-final.mk | 2 +- package/pkg-autotools.mk | 4 ++-- package/pkg-download.mk | 8 ++++---- 6 files changed, 10 insertions(+), 10 deletions(-)