| Message ID | 1417252360-10929-3-git-send-email-jezz@sysmic.org |
|---|---|
| State | Accepted |
| Headers | show |
Jérôme, All, On 2014-11-29 10:12 +0100, Jérôme Pouiller spake thusly: > libz160 is provided as binary. We need EABI toolchain with glibc to use > it. > > Signed-off-by: Jérôme Pouiller <jezz@sysmic.org> > --- > package/freescale-imx/libz160/Config.in | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/package/freescale-imx/libz160/Config.in b/package/freescale-imx/libz160/Config.in > index f956cce..f4abcc5 100644 > --- a/package/freescale-imx/libz160/Config.in > +++ b/package/freescale-imx/libz160/Config.in > @@ -1,5 +1,11 @@ > config BR2_PACKAGE_LIBZ160 > bool "libz160" > + depends on BR2_ARM_EABI > + depends on BR2_TOOLCHAIN_USES_GLIBC > help > An API for user space programs to perform 2D accelerated graphics > operations on AMD GPU (included for examples in iMX5x chipsets) > + > +comment "libz160 needs an EABI toolchain w/ (e)glibc" > + depends on BR2_arm Not needed, we're already in a depends-on-arm block thanks to BR2_PACKAGE_FREESCALE_IMX. > + depends on (!BR2_ARM_EABI || !BR2_TOOLCHAIN_USES_GLIBC) The parenthesis are superfluous here. Otherwise: Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Regards, Yann E. MORIN. > -- > 1.9.1 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Dear Jérôme Pouiller, On Sat, 29 Nov 2014 10:12:39 +0100, Jérôme Pouiller wrote: > libz160 is provided as binary. We need EABI toolchain with glibc to use > it. > > Signed-off-by: Jérôme Pouiller <jezz@sysmic.org> > --- > package/freescale-imx/libz160/Config.in | 6 ++++++ > 1 file changed, 6 insertions(+) Applied, after tweaking the comments as suggested by Yann. Thanks, Thomas
diff --git a/package/freescale-imx/libz160/Config.in b/package/freescale-imx/libz160/Config.in index f956cce..f4abcc5 100644 --- a/package/freescale-imx/libz160/Config.in +++ b/package/freescale-imx/libz160/Config.in @@ -1,5 +1,11 @@ config BR2_PACKAGE_LIBZ160 bool "libz160" + depends on BR2_ARM_EABI + depends on BR2_TOOLCHAIN_USES_GLIBC help An API for user space programs to perform 2D accelerated graphics operations on AMD GPU (included for examples in iMX5x chipsets) + +comment "libz160 needs an EABI toolchain w/ (e)glibc" + depends on BR2_arm + depends on (!BR2_ARM_EABI || !BR2_TOOLCHAIN_USES_GLIBC)
libz160 is provided as binary. We need EABI toolchain with glibc to use it. Signed-off-by: Jérôme Pouiller <jezz@sysmic.org> --- package/freescale-imx/libz160/Config.in | 6 ++++++ 1 file changed, 6 insertions(+)