diff mbox

schifra: mark as broken

Message ID 1415530410-18824-1-git-send-email-thomas.petazzoni@free-electrons.com
State Accepted
Commit 54f3f58b2b86f024678ab983f671f93d00ea8ec3
Headers show

Commit Message

Thomas Petazzoni Nov. 9, 2014, 10:53 a.m. UTC
There are many build failures caused by schifra, due to upstream
changing the tarball without doing new releases. Since has been an
on-going problem for some time, and is now the #1 issue in the
autobuilders. So let's mark this package broken, until someone cares
enough to fix it, or until we remove it.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/schifra/Config.in | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Peter Korsgaard Nov. 9, 2014, 11:26 a.m. UTC | #1
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > There are many build failures caused by schifra, due to upstream
 > changing the tarball without doing new releases. Since has been an
 > on-going problem for some time, and is now the #1 issue in the
 > autobuilders. So let's mark this package broken, until someone cares
 > enough to fix it, or until we remove it.

I've been discussing with schifra upstream and hope to have a fix very
soon, so I prefer to wait a bit and get it fixed instead.

They already put versioned binaries up on http://schifra.com/buildroot/
but I would prefer them to not do anything special for buildroot (that
they might forget to maintain in the future).
Peter Korsgaard Nov. 13, 2014, 9:06 a.m. UTC | #2
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > There are many build failures caused by schifra, due to upstream
 > changing the tarball without doing new releases. Since has been an
 > on-going problem for some time, and is now the #1 issue in the
 > autobuilders. So let's mark this package broken, until someone cares
 > enough to fix it, or until we remove it.

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Committed, thanks.
diff mbox

Patch

diff --git a/package/schifra/Config.in b/package/schifra/Config.in
index 486f92d..a3f699a 100644
--- a/package/schifra/Config.in
+++ b/package/schifra/Config.in
@@ -1,6 +1,10 @@ 
 config BR2_PACKAGE_SCHIFRA
 	bool "schifra"
 	depends on BR2_INSTALL_LIBSTDCPP
+	# Upstream keep changing the tarball without doing new
+	# releases. This is not acceptable for Buildroot, as
+	# reproducible builds are very important.
+	depends on BR2_BROKEN
 	help
 	  Schifra is a very robust, highly optimized and extremely configurable
 	  Reed-Solomon error correcting code library for both software and IP
@@ -18,4 +22,5 @@  config BR2_PACKAGE_SCHIFRA_EXAMPLES
 endif
 
 comment "schifra needs a toolchain w/ C++"
+	depends on BR2_BROKEN
 	depends on !BR2_INSTALL_LIBSTDCPP