| Message ID | 1415357294-22601-1-git-send-email-nicolas.serafini@sensefly.com |
|---|---|
| State | Accepted |
| Headers | show |
Dear Nicolas Serafini, On Fri, 7 Nov 2014 11:48:14 +0100, Nicolas Serafini wrote: > Add support for Exiv2 library and utility to manage image metadata > > Exiv2 can be built in GPLv2+ or commercial version. But in commercial > version the Nikon lens name database and the NLS support has to be > disabled for copyright reason. > > Signed-off-by: Nicolas Serafini <nicolas.serafini@sensefly.com> Thanks, I've applied your patch to the next branch. However, I've done a number of changes before applying your patch: [Thomas: - switch to using the CMake build system, which works better than the clunky autoconf + manual Makefile based build system. - add missing toolchains dependencies: does not build in static library configuration, needs C++, etc.] If you could test the next branch, and verify that it continues to work in your situation, it would be great. Thanks a lot, Thomas
Dear Thomas Petazzoni, On Sat, 22 Nov 2014 18:14:44 +0100 Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Dear Nicolas Serafini, > > On Fri, 7 Nov 2014 11:48:14 +0100, Nicolas Serafini wrote: > > Add support for Exiv2 library and utility to manage image metadata > > > > Exiv2 can be built in GPLv2+ or commercial version. But in > > commercial version the Nikon lens name database and the NLS support > > has to be disabled for copyright reason. > > > > Signed-off-by: Nicolas Serafini <nicolas.serafini@sensefly.com> > > Thanks, I've applied your patch to the next branch. However, I've done > a number of changes before applying your patch: > > [Thomas: > - switch to using the CMake build system, which works better > than the clunky autoconf + manual Makefile based build system. I started using cmake for this package, but the functionality is marked as "work in progress" and is expected to be 100% functional for release 0.25. Still I just tested with several configurations and it works. > - add missing toolchains dependencies: does not build in static > library configuration, needs C++, etc.] Thank you for adding toolchains dependencies. I would be careful to add them next time. > > If you could test the next branch, and verify that it continues to > work in your situation, it would be great. I tested it and it works as before. Thanks for this commit Regards, Nicolas > > Thanks a lot, > > Thomas
Am Fri, 07 Nov 2014 11:48:14 +0100 schrieb Nicolas Serafini:
> +EXIV2_INSTALL_STAGING = YES
Hi,
afaics no other buildroot package uses exiv2 so I would to remove the
staging install, any objections?
Regards, Bernd
Hello, On Sun, 04 Jun 2017 09:55:37 +0200, Bernd Kuhls wrote: > > +EXIV2_INSTALL_STAGING = YES > > afaics no other buildroot package uses exiv2 so I would to remove the > staging install, any objections? It is a library, so it makes sense to have it installed in staging. There are plenty of other libraries that are not used by other packages in Buildroot, but by people for their own custom/private applications. Removing the staging installation for all those libraries would not make sense. So, I would say that we should keep the staging installation for exiv2. Best regards, Thomas
diff --git a/package/Config.in b/package/Config.in index 28cf703..6abf344 100644 --- a/package/Config.in +++ b/package/Config.in @@ -625,6 +625,7 @@ menu "Graphics" source "package/adwaita-icon-theme/Config.in" source "package/atk/Config.in" source "package/cairo/Config.in" + source "package/exiv2/Config.in" source "package/fltk/Config.in" source "package/fontconfig/Config.in" source "package/freetype/Config.in" diff --git a/package/exiv2/Config.in b/package/exiv2/Config.in new file mode 100644 index 0000000..35f54a0 --- /dev/null +++ b/package/exiv2/Config.in @@ -0,0 +1,47 @@ +config BR2_PACKAGE_EXIV2 + bool "exiv2" + help + Exiv2 is a C++ library and a command line utility to manage + image metadata. + It provides fast and easy read and write access to the Exif, + IPTC and XMP metadata of images in various formats. + + Exiv2 is available with GPLv2+ or commercial license. + + http://www.exiv2.org/ + +if BR2_PACKAGE_EXIV2 + +config BR2_PACKAGE_EXIV2_COMMERCIAL + bool "Enable commercial" + help + Build the commercial version for closed source project. + + The Nikon lens name database and the NLS support is disabled + for copyright reason. + + A commercial license request is needed. + http://www.exiv2.org/download.html#license + +config BR2_PACKAGE_EXIV2_PNG + bool "PNG image support" + select BR2_PACKAGE_ZLIB + help + Build with PNG image support + +config BR2_PACKAGE_EXIV2_XMP + bool "XMP support" + select BR2_PACKAGE_EXPAT + help + Build with XMP support + +config BR2_PACKAGE_EXIV2_LENSDATA + bool "Nikon lens name database" + depends on !BR2_PACKAGE_EXIV2_COMMERCIAL + help + Integrate Nikon lens name database. + + This database is integrated but comes from thirdparty: + http://www.rottmerhusen.com/objektives/lensid/thirdparty.html + +endif diff --git a/package/exiv2/exiv2.hash b/package/exiv2/exiv2.hash new file mode 100644 index 0000000..d4f8c60 --- /dev/null +++ b/package/exiv2/exiv2.hash @@ -0,0 +1,4 @@ +# From http://www.exiv2.org/download.html +md5 b8a23dc56a98ede85c00718a97a8d6fc exiv2-0.24.tar.gz +# Locally calculated +sha256 f4a443e6c7fb9d9f5e787732f76969a64c72c4c04af69b10ed57f949c2dfef8e exiv2-0.24.tar.gz diff --git a/package/exiv2/exiv2.mk b/package/exiv2/exiv2.mk new file mode 100644 index 0000000..39f713a --- /dev/null +++ b/package/exiv2/exiv2.mk @@ -0,0 +1,39 @@ +################################################################################ +# +# exiv2 +# +################################################################################ + +EXIV2_VERSION = 0.24 +EXIV2_SITE = http://www.exiv2.org +EXIV2_INSTALL_STAGING = YES + +ifneq ($(BR2_PACKAGE_EXIV2_LENSDATA),y) +EXIV2_CONF_OPTS += --disable-lensdata +endif + +ifeq ($(BR2_PACKAGE_EXIV2_COMMERCIAL),y) +EXIV2_LICENSE = commercial +# NLS support is disabled in commercial version due to the copyright +# of the translated texts. +EXIV2_CONF_OPTS += --enable-commercial --disable-nls +else +EXIV2_LICENSE = GPLv2+ +EXIV2_LICENSE_FILES = COPYING +endif + +ifeq ($(BR2_PACKAGE_EXIV2_PNG),y) +EXIV2_CONF_OPTS += --with-zlib=$(STAGING_DIR) +EXIV2_DEPENDENCIES += zlib +else +EXIV2_CONF_OPTS += --without-zlib +endif + +ifeq ($(BR2_PACKAGE_EXIV2_XMP),y) +EXIV2_CONF_OPTS += --enable-xmp --with-expat=$(STAGING_DIR)/usr/lib +EXIV2_DEPENDENCIES += expat +else +EXIV2_CONF_OPTS += --disable-xmp +endif + +$(eval $(autotools-package))