diff mbox

[1/2] mx53loco: update support

Message ID 1413790693-8281-1-git-send-email-eric@eukrea.com
State Superseded, archived
Headers show

Commit Message

Eric Benard Oct. 20, 2014, 7:38 a.m. UTC
- update bootloader to 2014.07 with fslc patches
- update kernel to 2.6.35_maintain branch which contains latest fixes
- defconfig was then generated by savedefconfig which suppressed and
  reordered some items which explains the number of lines changed.

Tested on an i.MX53 QSB and an i.MX53 QSB-R

Signed-off-by: Eric Bénard <eric@eukrea.com>
---
 configs/mx53loco_defconfig | 24 +++++++++---------------
 1 file changed, 9 insertions(+), 15 deletions(-)

Comments

Peter Korsgaard Oct. 20, 2014, 8:03 a.m. UTC | #1
>>>>> "Eric" == Eric Bénard <eric@eukrea.com> writes:

 > - update bootloader to 2014.07 with fslc patches

fslc? Do you mean Freescale?

 > - update kernel to 2.6.35_maintain branch which contains latest fixes
 > - defconfig was then generated by savedefconfig which suppressed and
 >   reordered some items which explains the number of lines changed.

 > Tested on an i.MX53 QSB and an i.MX53 QSB-R

 > Signed-off-by: Eric Bénard <eric@eukrea.com>
 > ---
 >  configs/mx53loco_defconfig | 24 +++++++++---------------
 >  1 file changed, 9 insertions(+), 15 deletions(-)

 > diff --git a/configs/mx53loco_defconfig b/configs/mx53loco_defconfig
 > index 8b12238..6e59e5b 100644
 > --- a/configs/mx53loco_defconfig
 > +++ b/configs/mx53loco_defconfig
 > @@ -1,22 +1,16 @@
 > -# Architecture
 >  BR2_arm=y
 >  BR2_cortex_a8=y
 > -BR2_ARM_FPU_VFPV3D16=y
 > -
 > -# System
 >  BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0"
 > -BR2_TARGET_UBOOT=y
 > -BR2_TARGET_UBOOT_BOARDNAME="mx53_loco"
 > -BR2_TARGET_UBOOT_CUSTOM_GIT=y
 > -BR2_TARGET_UBOOT_CUSTOM_REPO_URL="git://git.freescale.com/imx/uboot-imx.git"
 > -BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="rel_imx_2.6.35_11.09.01"
 > -
 > -# filesystem
 > -BR2_TARGET_ROOTFS_EXT2=y
 > -
 > -# Kernel

I prefer to keep the section comments, but OK.

 >  BR2_LINUX_KERNEL=y
 >  BR2_LINUX_KERNEL_CUSTOM_GIT=y
 >  BR2_LINUX_KERNEL_CUSTOM_REPO_URL="git://git.freescale.com/imx/linux-2.6-imx.git"
 > -BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="rel_imx_2.6.35_11.09.01"
 > +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="imx_2.6.35_maintain"

_VERSION has to uniquely specify a revision, so it must be a tag or a
sha1 - And not a branch.

So use b3912bb8a4caf3ec50909135e88af959982c43ca instead.

 >  BR2_LINUX_KERNEL_DEFCONFIG="imx5"
 > +BR2_LINUX_KERNEL_ZIMAGE=y
 > +BR2_TARGET_ROOTFS_EXT2=y
 > +BR2_TARGET_UBOOT=y
 > +BR2_TARGET_UBOOT_BOARDNAME="mx53loco"
 > +BR2_TARGET_UBOOT_CUSTOM_GIT=y
 > +BR2_TARGET_UBOOT_CUSTOM_REPO_URL="git://github.com/Freescale/u-boot-imx.git"

The github page seems to redirect this to u-boot-fslc - So perhaps use
that instead?

 > +BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="patches-2014.07"

Same comment as for the kernel.
Eric Benard Oct. 20, 2014, 8:31 a.m. UTC | #2
Hi Peter,

Le Mon, 20 Oct 2014 10:03:00 +0200,
Peter Korsgaard <jacmet@uclibc.org> a écrit :

> 
> >>>>> "Eric" == Eric Bénard <eric@eukrea.com> writes:
> 
>  > - update bootloader to 2014.07 with fslc patches
> 
> fslc? Do you mean Freescale?
> 
fscl means "Freescale Community" : 
http://freescale.github.io/
https://community.freescale.com/welcome
so the suffix -fslc is added to u-boot & linux git trees :
https://github.com/Freescale/u-boot-fslc
https://github.com/Freescale/linux-fslc

>  > - update kernel to 2.6.35_maintain branch which contains latest
>  > fixes
>  > - defconfig was then generated by savedefconfig which suppressed
>  > and reordered some items which explains the number of lines
>  > changed.
> 
>  > Tested on an i.MX53 QSB and an i.MX53 QSB-R
> 
>  > Signed-off-by: Eric Bénard <eric@eukrea.com>
>  > ---
>  >  configs/mx53loco_defconfig | 24 +++++++++---------------
>  >  1 file changed, 9 insertions(+), 15 deletions(-)
> 
>  > diff --git a/configs/mx53loco_defconfig
>  > b/configs/mx53loco_defconfig index 8b12238..6e59e5b 100644
>  > --- a/configs/mx53loco_defconfig
>  > +++ b/configs/mx53loco_defconfig
>  > @@ -1,22 +1,16 @@
>  > -# Architecture
>  >  BR2_arm=y
>  >  BR2_cortex_a8=y
>  > -BR2_ARM_FPU_VFPV3D16=y
>  > -
>  > -# System
>  >  BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0"
>  > -BR2_TARGET_UBOOT=y
>  > -BR2_TARGET_UBOOT_BOARDNAME="mx53_loco"
>  > -BR2_TARGET_UBOOT_CUSTOM_GIT=y
>  > -BR2_TARGET_UBOOT_CUSTOM_REPO_URL="git://git.freescale.com/imx/uboot-imx.git"
>  > -BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="rel_imx_2.6.35_11.09.01"
>  > -
>  > -# filesystem
>  > -BR2_TARGET_ROOTFS_EXT2=y
>  > -
>  > -# Kernel
> 
> I prefer to keep the section comments, but OK.
> 
make savedefconfig automagically removed the comments.
I you prefer I can manually reintroduce them.

>  >  BR2_LINUX_KERNEL=y
>  >  BR2_LINUX_KERNEL_CUSTOM_GIT=y
>  >  BR2_LINUX_KERNEL_CUSTOM_REPO_URL="git://git.freescale.com/imx/linux-2.6-imx.git"
>  > -BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="rel_imx_2.6.35_11.09.01"
>  > +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="imx_2.6.35_maintain"
> 
> _VERSION has to uniquely specify a revision, so it must be a tag or a
> sha1 - And not a branch.
> 
then the help is misleading as it says (for
BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION and for
BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION) :
"Revision to use in the typical format used by Git/Mercurial
E.G. a sha id, a tag, _branch_ , .. "

> So use b3912bb8a4caf3ec50909135e88af959982c43ca instead.
> 
OK will do in v2.

>  >  BR2_LINUX_KERNEL_DEFCONFIG="imx5"
>  > +BR2_LINUX_KERNEL_ZIMAGE=y
>  > +BR2_TARGET_ROOTFS_EXT2=y
>  > +BR2_TARGET_UBOOT=y
>  > +BR2_TARGET_UBOOT_BOARDNAME="mx53loco"
>  > +BR2_TARGET_UBOOT_CUSTOM_GIT=y
>  > +BR2_TARGET_UBOOT_CUSTOM_REPO_URL="git://github.com/Freescale/u-boot-imx.git"
> 
> The github page seems to redirect this to u-boot-fslc - So perhaps use
> that instead?
> 
OK

>  > +BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="patches-2014.07"
> 
> Same comment as for the kernel.
> 
OK

Thanks,
Eric
Thomas Petazzoni Oct. 20, 2014, 8:41 a.m. UTC | #3
Dear Eric Bénard,

On Mon, 20 Oct 2014 09:38:12 +0200, Eric Bénard wrote:

> -# Kernel
>  BR2_LINUX_KERNEL=y
>  BR2_LINUX_KERNEL_CUSTOM_GIT=y
>  BR2_LINUX_KERNEL_CUSTOM_REPO_URL="git://git.freescale.com/imx/linux-2.6-imx.git"
> -BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="rel_imx_2.6.35_11.09.01"
> +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="imx_2.6.35_maintain"

Since we're using 2.6.35, the kernel headers of the toolchain should
also be fixed to 2.6.35, otherwise we're using 3.17 by default which
may cause some issues.

Thomas
Peter Korsgaard Oct. 20, 2014, 10:58 a.m. UTC | #4
>>>>> "Eric" == Eric Bénard <eric@eukrea.com> writes:

Hi,

 >> fslc? Do you mean Freescale?
 >> 
 > fscl means "Freescale Community" : 

fslc ;)

 > http://freescale.github.io/
 > https://community.freescale.com/welcome
 > so the suffix -fslc is added to u-boot & linux git trees :
 > https://github.com/Freescale/u-boot-fslc
 > https://github.com/Freescale/linux-fslc

Ok, thanks.


 >> I prefer to keep the section comments, but OK.
 >> 
 > make savedefconfig automagically removed the comments.
 > I you prefer I can manually reintroduce them.

I think it is nicer for consistency, but I can add them as well when
committing.


 >> >  BR2_LINUX_KERNEL=y
 >> >  BR2_LINUX_KERNEL_CUSTOM_GIT=y
 >> >  BR2_LINUX_KERNEL_CUSTOM_REPO_URL="git://git.freescale.com/imx/linux-2.6-imx.git"
 >> > -BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="rel_imx_2.6.35_11.09.01"
 >> > +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="imx_2.6.35_maintain"
 >> 
 >> _VERSION has to uniquely specify a revision, so it must be a tag or a
 >> sha1 - And not a branch.
 >> 
 > then the help is misleading as it says (for
 > BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION and for
 > BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION) :
 > "Revision to use in the typical format used by Git/Mercurial
 > E.G. a sha id, a tag, _branch_ , .. "

Ahh yes, I'll fix that. The problem about using a branch is that the
downloading infrastructure thinks the branch name uniquely identifies
the code, so it will only download it once even if more commits are
pushed to the branch later.
diff mbox

Patch

diff --git a/configs/mx53loco_defconfig b/configs/mx53loco_defconfig
index 8b12238..6e59e5b 100644
--- a/configs/mx53loco_defconfig
+++ b/configs/mx53loco_defconfig
@@ -1,22 +1,16 @@ 
-# Architecture
 BR2_arm=y
 BR2_cortex_a8=y
-BR2_ARM_FPU_VFPV3D16=y
-
-# System
 BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0"
-BR2_TARGET_UBOOT=y
-BR2_TARGET_UBOOT_BOARDNAME="mx53_loco"
-BR2_TARGET_UBOOT_CUSTOM_GIT=y
-BR2_TARGET_UBOOT_CUSTOM_REPO_URL="git://git.freescale.com/imx/uboot-imx.git"
-BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="rel_imx_2.6.35_11.09.01"
-
-# filesystem
-BR2_TARGET_ROOTFS_EXT2=y
-
-# Kernel
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_GIT=y
 BR2_LINUX_KERNEL_CUSTOM_REPO_URL="git://git.freescale.com/imx/linux-2.6-imx.git"
-BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="rel_imx_2.6.35_11.09.01"
+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="imx_2.6.35_maintain"
 BR2_LINUX_KERNEL_DEFCONFIG="imx5"
+BR2_LINUX_KERNEL_ZIMAGE=y
+BR2_TARGET_ROOTFS_EXT2=y
+BR2_TARGET_UBOOT=y
+BR2_TARGET_UBOOT_BOARDNAME="mx53loco"
+BR2_TARGET_UBOOT_CUSTOM_GIT=y
+BR2_TARGET_UBOOT_CUSTOM_REPO_URL="git://github.com/Freescale/u-boot-imx.git"
+BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="patches-2014.07"
+BR2_TARGET_UBOOT_FORMAT_IMX=y