diff mbox

[27/31] arch/powerpc: get rid of BR2_GCC_TARGET_TUNE

Message ID 1413749285-1108-28-git-send-email-thomas.petazzoni@free-electrons.com
State Accepted
Commit 75418c4cf678a3c34352bd7a781296937815681d
Headers show

Commit Message

Thomas Petazzoni Oct. 19, 2014, 8:08 p.m. UTC
According to the gcc documentation for PowerPC options:

'-mtune=CPU_TYPE'
     Set the instruction scheduling parameters for machine type
     CPU_TYPE, but do not set the architecture type, register usage, or
     choice of mnemonics, as '-mcpu=CPU_TYPE' would.  The same values
     for CPU_TYPE are used for '-mtune' as for '-mcpu'.  If both are
     specified, the code generated will use the architecture, registers,
     and mnemonics set by '-mcpu', but the scheduling parameters set by
     '-mtune'.

In the case of Buildroot where we only target a specific system, using
-mtune therefore doesn't make much sense, and using -mcpu would be
more appropriate. As a consequence, this patch makes PowerPC use
BR2_GCC_TARGET_CPU instead of BR2_GCC_TARGET_TUNE.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 arch/Config.in.powerpc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yann E. MORIN Oct. 19, 2014, 10:17 p.m. UTC | #1
Thomas, All,

On 2014-10-19 22:08 +0200, Thomas Petazzoni spake thusly:
> According to the gcc documentation for PowerPC options:
> 
> '-mtune=CPU_TYPE'
>      Set the instruction scheduling parameters for machine type
>      CPU_TYPE, but do not set the architecture type, register usage, or
>      choice of mnemonics, as '-mcpu=CPU_TYPE' would.  The same values
>      for CPU_TYPE are used for '-mtune' as for '-mcpu'.  If both are
>      specified, the code generated will use the architecture, registers,
>      and mnemonics set by '-mcpu', but the scheduling parameters set by
>      '-mtune'.
> 
> In the case of Buildroot where we only target a specific system, using
> -mtune therefore doesn't make much sense, and using -mcpu would be
> more appropriate. As a consequence, this patch makes PowerPC use
> BR2_GCC_TARGET_CPU instead of BR2_GCC_TARGET_TUNE.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  arch/Config.in.powerpc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/Config.in.powerpc b/arch/Config.in.powerpc
> index 239f5dc..fabee9f 100644
> --- a/arch/Config.in.powerpc
> +++ b/arch/Config.in.powerpc
> @@ -160,7 +160,7 @@ config BR2_ENDIAN
>  config BR2_ARCH_HAS_ATOMICS
>  	default y
>  
> -config BR2_GCC_TARGET_TUNE
> +config BR2_GCC_TARGET_CPU
>  	default "401"		if BR2_powerpc_401
>  	default "403"		if BR2_powerpc_403
>  	default "405"		if BR2_powerpc_405
> -- 
> 2.0.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
diff mbox

Patch

diff --git a/arch/Config.in.powerpc b/arch/Config.in.powerpc
index 239f5dc..fabee9f 100644
--- a/arch/Config.in.powerpc
+++ b/arch/Config.in.powerpc
@@ -160,7 +160,7 @@  config BR2_ENDIAN
 config BR2_ARCH_HAS_ATOMICS
 	default y
 
-config BR2_GCC_TARGET_TUNE
+config BR2_GCC_TARGET_CPU
 	default "401"		if BR2_powerpc_401
 	default "403"		if BR2_powerpc_403
 	default "405"		if BR2_powerpc_405