| Message ID | 1413748165-2732-2-git-send-email-bernd.kuhls@t-online.de |
|---|---|
| State | Superseded |
| Headers | show |
Dear Bernd Kuhls, On Sun, 19 Oct 2014 21:49:25 +0200, Bernd Kuhls wrote: > diff --git a/package/liblog4c-localtime/liblog4c-0003-debug.patch b/package/liblog4c-localtime/liblog4c-0003-debug.patch > new file mode 100644 > index 0000000..80b00cf > --- /dev/null > +++ b/package/liblog4c-localtime/liblog4c-0003-debug.patch > @@ -0,0 +1,37 @@ > +Fix build with BR2_ENABLE_DEBUG=yes > + > +Fixes > +init.c:39:20: fatal error: mcheck.h: No such file or directory > + > +Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> Same comment as for the other package: using AC_CHECK_HEADER([mcheck.h]) and then HAVE_MCHECK_H is a much better solution. Do you think you can push upstream this patch as well as the other patches that we have? Thanks, Thomas
Bernd, On Sun, 19 Oct 2014 22:49:55 +0200, Thomas Petazzoni wrote: > Same comment as for the other package: using > AC_CHECK_HEADER([mcheck.h]) and then HAVE_MCHECK_H is a much better > solution. > > Do you think you can push upstream this patch as well as the other > patches that we have? I've committed some patches against liblog4c-localtime to implement this, and I submitted them upstream. Therefore, I've marked your patch as Superseded. Thanks for spotting and analyzing the issue! Thanks, Thomas
diff --git a/package/liblog4c-localtime/liblog4c-0003-debug.patch b/package/liblog4c-localtime/liblog4c-0003-debug.patch new file mode 100644 index 0000000..80b00cf --- /dev/null +++ b/package/liblog4c-localtime/liblog4c-0003-debug.patch @@ -0,0 +1,37 @@ +Fix build with BR2_ENABLE_DEBUG=yes + +Fixes +init.c:39:20: fatal error: mcheck.h: No such file or directory + +Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> + +diff -uNr log4c-localtime-1.0.org/src/log4c/init.c log4c-localtime-1.0/src/log4c/init.c +--- log4c-localtime-1.0.org/src/log4c/init.c 2011-09-06 15:37:02.000000000 +0200 ++++ log4c-localtime-1.0/src/log4c/init.c 2014-10-19 21:39:29.000000000 +0200 +@@ -35,7 +35,7 @@ + #include <layout_type_basic_r.h> + #include <layout_type_dated_r.h> + +-#if defined(__LOG4C_DEBUG__) && defined(__GLIBC__) ++#if defined(__LOG4C_DEBUG__) && defined(__GLIBC__) && !defined(__UCLIBC__) + #include <mcheck.h> + #endif + +@@ -100,7 +100,7 @@ + sd_debug("log4c_init["); + + /* activate GLIBC allocation debugging */ +-#if defined(__LOG4C_DEBUG__) && defined(__GLIBC__) ++#if defined(__LOG4C_DEBUG__) && defined(__GLIBC__) && !defined(__UCLIBC__) + mtrace(); + #endif + +@@ -278,7 +280,7 @@ + log4c_dump_all_instances(stderr); + } + #endif +-#if defined(__LOG4C_DEBUG__) && defined(__GLIBC__) ++#if defined(__LOG4C_DEBUG__) && defined(__GLIBC__) && !defined(__UCLIBC__) + muntrace(); + #endif +
Fixes init.c:39:20: fatal error: mcheck.h: No such file or directory Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de> --- .../liblog4c-localtime/liblog4c-0003-debug.patch | 37 ++++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 package/liblog4c-localtime/liblog4c-0003-debug.patch