diff mbox

rt-tests: enable on MIPS uClibc again

Message ID 1413040612-19235-1-git-send-email-arnout@mind.be
State Accepted
Commit 398e590e2d55668e9ef7420cc274f0afdd174684
Headers show

Commit Message

Arnout Vandecappelle Oct. 11, 2014, 3:16 p.m. UTC 
We have fixes in the internal toolchain; an external toolchain is most
likely a buildroot-built toolchain anyway, so it will also have the
fix. But we still keep a comment to warn the user for potentially-broken
external toolchains.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/rt-tests/Config.in | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

Comments

Peter Korsgaard Oct. 12, 2014, 7:47 a.m. UTC | #1 
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:

 > We have fixes in the internal toolchain; an external toolchain is most
 > likely a buildroot-built toolchain anyway, so it will also have the
 > fix. But we still keep a comment to warn the user for potentially-broken
 > external toolchains.

 > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
 > Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>

Committed, thanks.
diff mbox

Patch

diff --git a/package/rt-tests/Config.in b/package/rt-tests/Config.in
index 28a4a11..81e5d06 100644
--- a/package/rt-tests/Config.in
+++ b/package/rt-tests/Config.in
@@ -1,8 +1,6 @@ 
 config BR2_PACKAGE_RT_TESTS
 	bool "rt-tests"
 	# no _tid field in 'struct sigevent'
-	depends on !(BR2_TOOLCHAIN_USES_UCLIBC && (BR2_mips || BR2_mipsel || \
-		BR2_mips64 || BR2_mips64el))
 	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	help
 	  Set of utilities for testing the real-time behaviour of a
@@ -23,9 +21,10 @@  config BR2_PACKAGE_RT_TESTS
 	  http://rt.wiki.kernel.org
 
 
-comment "rt-tests needs an (e)glibc toolchain"
-	depends on BR2_TOOLCHAIN_USES_UCLIBC && (BR2_mips || BR2_mipsel || \
-		BR2_mips64 || BR2_mips64el)
+comment "rt-tests may not work on MIPS with an external uClibc toolchain"
+	depends on BR2_PACKAGE_RT_TESTS
+	depends on BR2_TOOLCHAIN_EXTERNAL_UCLIBC
+	depends on BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el
 
 comment "rt-tests needs a toolchain w/ NPTL"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL