diff mbox

heirloom-mailx: add license info

Message ID 1410584439-31668-1-git-send-email-danomimanchego123@gmail.com
State Accepted
Headers show

Commit Message

Danomi Manchego Sept. 13, 2014, 5 a.m. UTC
Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
---
 package/heirloom-mailx/heirloom-mailx.mk | 2 ++
 1 file changed, 2 insertions(+)

Comments

Baruch Siach Sept. 13, 2014, 6:43 p.m. UTC | #1
Hi Danomi,

On Sat, Sep 13, 2014 at 01:00:39AM -0400, Danomi Manchego wrote:
> Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
> ---
>  package/heirloom-mailx/heirloom-mailx.mk | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/heirloom-mailx/heirloom-mailx.mk b/package/heirloom-mailx/heirloom-mailx.mk
> index 75221d4..0a80a3c 100644
> --- a/package/heirloom-mailx/heirloom-mailx.mk
> +++ b/package/heirloom-mailx/heirloom-mailx.mk
> @@ -7,6 +7,8 @@
>  HEIRLOOM_MAILX_VERSION = 12.5
>  HEIRLOOM_MAILX_SOURCE  = heirloom-mailx_$(HEIRLOOM_MAILX_VERSION).orig.tar.gz
>  HEIRLOOM_MAILX_SITE    = http://snapshot.debian.org/archive/debian/20110427T035506Z/pool/main/h/heirloom-mailx
> +HEIRLOOM_MAILX_LICENSE = BSD-4c, Bellcore (base64), IEEE (docs), OpenVision (imap_gssapi), RSA Data Security (md5), Network Working Group (hmac), MPLv1.1 (nss)

Do we install these IEEE licensed docs? If not I think we can omit this 
license. IANAL, though.

baruch

> +HEIRLOOM_MAILX_LICENSE_FILES = COPYING
>  
>  ifeq ($(BR2_PACKAGE_OPENSSL),y)
>  HEIRLOOM_MAILX_DEPENDENCIES += openssl
Peter Korsgaard Sept. 13, 2014, 7:51 p.m. UTC | #2
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 > Hi Danomi,
 > On Sat, Sep 13, 2014 at 01:00:39AM -0400, Danomi Manchego wrote:
 >> Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
 >> ---
 >> package/heirloom-mailx/heirloom-mailx.mk | 2 ++
 >> 1 file changed, 2 insertions(+)
 >> 
 >> diff --git a/package/heirloom-mailx/heirloom-mailx.mk b/package/heirloom-mailx/heirloom-mailx.mk
 >> index 75221d4..0a80a3c 100644
 >> --- a/package/heirloom-mailx/heirloom-mailx.mk
 >> +++ b/package/heirloom-mailx/heirloom-mailx.mk
 >> @@ -7,6 +7,8 @@
 >> HEIRLOOM_MAILX_VERSION = 12.5
 >> HEIRLOOM_MAILX_SOURCE  = heirloom-mailx_$(HEIRLOOM_MAILX_VERSION).orig.tar.gz
 >> HEIRLOOM_MAILX_SITE    = http://snapshot.debian.org/archive/debian/20110427T035506Z/pool/main/h/heirloom-mailx
 >> +HEIRLOOM_MAILX_LICENSE = BSD-4c, Bellcore (base64), IEEE (docs), OpenVision (imap_gssapi), RSA Data Security (md5), Network Working Group (hmac), MPLv1.1 (nss)

 > Do we install these IEEE licensed docs? If not I think we can omit this 
 > license. IANAL, though.

True. The only documentation getting installed is the man pages, and we
delete them unless the deprecated BR2_HAVE_DOCUMENTATION option is
enabled.

So I think we can skip it.
Peter Korsgaard Sept. 13, 2014, 7:51 p.m. UTC | #3
>>>>> "Danomi" == Danomi Manchego <danomimanchego123@gmail.com> writes:

 > Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
 > ---
 >  package/heirloom-mailx/heirloom-mailx.mk | 2 ++
 >  1 file changed, 2 insertions(+)

 > diff --git a/package/heirloom-mailx/heirloom-mailx.mk b/package/heirloom-mailx/heirloom-mailx.mk
 > index 75221d4..0a80a3c 100644
 > --- a/package/heirloom-mailx/heirloom-mailx.mk
 > +++ b/package/heirloom-mailx/heirloom-mailx.mk
 > @@ -7,6 +7,8 @@
 >  HEIRLOOM_MAILX_VERSION = 12.5
 >  HEIRLOOM_MAILX_SOURCE  = heirloom-mailx_$(HEIRLOOM_MAILX_VERSION).orig.tar.gz
 >  HEIRLOOM_MAILX_SITE    = http://snapshot.debian.org/archive/debian/20110427T035506Z/pool/main/h/heirloom-mailx
 > +HEIRLOOM_MAILX_LICENSE = BSD-4c, Bellcore (base64), IEEE (docs), OpenVision (imap_gssapi), RSA Data Security (md5), Network Working Group (hmac), MPLv1.1 (nss)
 > +HEIRLOOM_MAILX_LICENSE_FILES = COPYING

Committed with the IEEE part dropped as suggested by Baruch.
Danomi Manchego Sept. 13, 2014, 7:51 p.m. UTC | #4
Baruch,

On Sat, Sep 13, 2014 at 2:43 PM, Baruch Siach <baruch@tkos.co.il> wrote:
> Hi Danomi,
>
> On Sat, Sep 13, 2014 at 01:00:39AM -0400, Danomi Manchego wrote:
>> Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
>> ---
>>  package/heirloom-mailx/heirloom-mailx.mk | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/package/heirloom-mailx/heirloom-mailx.mk b/package/heirloom-mailx/heirloom-mailx.mk
>> index 75221d4..0a80a3c 100644
>> --- a/package/heirloom-mailx/heirloom-mailx.mk
>> +++ b/package/heirloom-mailx/heirloom-mailx.mk
>> @@ -7,6 +7,8 @@
>>  HEIRLOOM_MAILX_VERSION = 12.5
>>  HEIRLOOM_MAILX_SOURCE  = heirloom-mailx_$(HEIRLOOM_MAILX_VERSION).orig.tar.gz
>>  HEIRLOOM_MAILX_SITE    = http://snapshot.debian.org/archive/debian/20110427T035506Z/pool/main/h/heirloom-mailx
>> +HEIRLOOM_MAILX_LICENSE = BSD-4c, Bellcore (base64), IEEE (docs), OpenVision (imap_gssapi), RSA Data Security (md5), Network Working Group (hmac), MPLv1.1 (nss)
>
> Do we install these IEEE licensed docs? If not I think we can omit this
> license. IANAL, though.

No, no doc is installed.  A man page gets installed, but then its
deleted during target finalization.

I'm sympathetic to the notion of dropping the license.  But in the
case of heirloom-mailx, all of these licenses are listed in the one
COPYING file.  So anyone that actually looks at the file will see IEEE
mentioned.

Besides, this seems consistent with other buildroot packages that call
out specific licenses for docs:

$ find -name \*.mk -exec grep 'LICENSE =' {} \+ | grep -v
LICENSE_FILES | grep -i doc
./package/jq/jq.mk:JQ_LICENSE = MIT (code), CC-BY-3.0 (documentation)
./package/docker/docker.mk:DOCKER_LICENSE = GPLv2+
./package/libassuan/libassuan.mk:LIBASSUAN_LICENSE = LGPLv2.1+
(library), GPLv3 (tests, doc)
./package/libcgicc/libcgicc.mk:LIBCGICC_LICENSE = LGPLv3+ (library),
GFDL1.2+ (docs)
./package/xenomai/xenomai.mk:XENOMAI_LICENSE = headers: GPLv2+ with
exception, libraries: LGPLv2.1+, kernel: GPLv2+, docs: GFDLv1.2+,
ipipe patch and can driver: GPLv2

Of course, maybe these should also drop the doc license components as
well?  For example, libassuan doesn't install the tests and the docs
gets deleted, so I think it makes sense to drop the GPLv3 COPYING and
just consider the LGPLv2.1 library.  When company policy is to treat
GPLv3 as a contaminant, it seems like this distinction can make a big
difference.

Not sure ...

Danomi -

> baruch
>
>> +HEIRLOOM_MAILX_LICENSE_FILES = COPYING
>>
>>  ifeq ($(BR2_PACKAGE_OPENSSL),y)
>>  HEIRLOOM_MAILX_DEPENDENCIES += openssl
>
> --
>      http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
>    - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
diff mbox

Patch

diff --git a/package/heirloom-mailx/heirloom-mailx.mk b/package/heirloom-mailx/heirloom-mailx.mk
index 75221d4..0a80a3c 100644
--- a/package/heirloom-mailx/heirloom-mailx.mk
+++ b/package/heirloom-mailx/heirloom-mailx.mk
@@ -7,6 +7,8 @@ 
 HEIRLOOM_MAILX_VERSION = 12.5
 HEIRLOOM_MAILX_SOURCE  = heirloom-mailx_$(HEIRLOOM_MAILX_VERSION).orig.tar.gz
 HEIRLOOM_MAILX_SITE    = http://snapshot.debian.org/archive/debian/20110427T035506Z/pool/main/h/heirloom-mailx
+HEIRLOOM_MAILX_LICENSE = BSD-4c, Bellcore (base64), IEEE (docs), OpenVision (imap_gssapi), RSA Data Security (md5), Network Working Group (hmac), MPLv1.1 (nss)
+HEIRLOOM_MAILX_LICENSE_FILES = COPYING
 
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
 HEIRLOOM_MAILX_DEPENDENCIES += openssl