| Message ID | 1405672963-16069-2-git-send-email-rick.taylor@cassidian.com |
|---|---|
| State | Changes Requested |
| Headers | show |
Dear Rick Taylor, On Fri, 18 Jul 2014 09:42:42 +0100, Rick Taylor wrote: > Signed-off-by: Rick Taylor <rick.taylor@cassidian.com> > --- > docs/manual/adding-packages-autotools.txt | 5 +++++ > 1 file changed, 5 insertions(+) Commit title should be: docs/manual: update documentation for <pkg>_AUTORECONF_ENV or something similar, at least carrying the "docs/manual:" prefix. Thanks, Thomas
Hi Rick, On Fri, Jul 18, 2014 at 10:42 AM, Rick Taylor <tropicalstormuk@gmail.com> wrote: > Signed-off-by: Rick Taylor <rick.taylor@cassidian.com> > --- > docs/manual/adding-packages-autotools.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/docs/manual/adding-packages-autotools.txt b/docs/manual/adding-packages-autotools.txt > index 3f40503..a1a4b90 100644 > --- a/docs/manual/adding-packages-autotools.txt > +++ b/docs/manual/adding-packages-autotools.txt > @@ -121,6 +121,11 @@ cases, typical packages will therefore only use a few of them. > automake, libtool, etc.). Valid values are +YES+ and > +NO+. By default, the value is +NO+ > > +* +LIBFOO_AUTORECONF_ENV+, to specify additional environment > + variables to pass the 'autoreconf' program if Did you see my comment on the previous version of this patch? I think there is a 'to' missing here: to pass _to_ the autoreconf program Best regards, Thomas
Hi All, I have rebased all my autoconf patches down to 1 patch file. Hopefully I have got the git commit message correct. Many thanks for your patience! Rick On Fri, Jul 18, 2014 at 9:54 AM, Thomas De Schampheleire < patrickdepinguin@gmail.com> wrote: > Hi Rick, > > On Fri, Jul 18, 2014 at 10:42 AM, Rick Taylor <tropicalstormuk@gmail.com> > wrote: > > Signed-off-by: Rick Taylor <rick.taylor@cassidian.com> > > --- > > docs/manual/adding-packages-autotools.txt | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/docs/manual/adding-packages-autotools.txt > b/docs/manual/adding-packages-autotools.txt > > index 3f40503..a1a4b90 100644 > > --- a/docs/manual/adding-packages-autotools.txt > > +++ b/docs/manual/adding-packages-autotools.txt > > @@ -121,6 +121,11 @@ cases, typical packages will therefore only use a > few of them. > > automake, libtool, etc.). Valid values are +YES+ and > > +NO+. By default, the value is +NO+ > > > > +* +LIBFOO_AUTORECONF_ENV+, to specify additional environment > > + variables to pass the 'autoreconf' program if > > Did you see my comment on the previous version of this patch? I think > there is a 'to' missing here: > > to pass _to_ the autoreconf program > > > Best regards, > Thomas >
diff --git a/docs/manual/adding-packages-autotools.txt b/docs/manual/adding-packages-autotools.txt index 3f40503..a1a4b90 100644 --- a/docs/manual/adding-packages-autotools.txt +++ b/docs/manual/adding-packages-autotools.txt @@ -121,6 +121,11 @@ cases, typical packages will therefore only use a few of them. automake, libtool, etc.). Valid values are +YES+ and +NO+. By default, the value is +NO+ +* +LIBFOO_AUTORECONF_ENV+, to specify additional environment + variables to pass the 'autoreconf' program if + +LIBFOO_AUTORECONF=YES+. These are passed before + the 'autoreconf' command. By default, empty. + * +LIBFOO_AUTORECONF_OPT+ to specify additional options passed to the 'autoreconf' program if +LIBFOO_AUTORECONF=YES+. By default, empty.
Signed-off-by: Rick Taylor <rick.taylor@cassidian.com> --- docs/manual/adding-packages-autotools.txt | 5 +++++ 1 file changed, 5 insertions(+)