| Message ID | 13d64548b894fc1b351af2f9bbb861ce230144d0.1424173685.git.baruch@tkos.co.il |
|---|---|
| State | Changes Requested |
| Headers | show |
Dear Baruch Siach, On Tue, 17 Feb 2015 13:48:05 +0200, Baruch Siach wrote: > # This package implements the support for external toolchains, i.e > -# toolchains that have not been produced by Buildroot itself and that > -# Buildroot can download from the Web or that are already available on > -# the system on which Buildroot runs. So far, we have tested this > +# toolchains that have not been produced locally by Buildroot itself and I am not sure adding "locally" makes the thing clearer: you can very well produce a toolchain with Buildroot "locally", and then re-use it in a later Buildroot build as an external toolchain on the same machine. Maybe we should simply rephrase this as: This package implements the support for external toolchains, i.e toolchains that are available pre-built, ready to use. Such toolchain me either be readily available on the Web (Linaro, Sourcery CodeBench, from processor vendors) or may be built with tools like Crosstool-NG or Buildroot itself. Best regards, Thomas
Hi Thomas, On Thu, Feb 19, 2015 at 09:36:18PM +0100, Thomas Petazzoni wrote: > On Tue, 17 Feb 2015 13:48:05 +0200, Baruch Siach wrote: > > # This package implements the support for external toolchains, i.e > > -# toolchains that have not been produced by Buildroot itself and that > > -# Buildroot can download from the Web or that are already available on > > -# the system on which Buildroot runs. So far, we have tested this > > +# toolchains that have not been produced locally by Buildroot itself and > > I am not sure adding "locally" makes the thing clearer: you can very > well produce a toolchain with Buildroot "locally", and then re-use it > in a later Buildroot build as an external toolchain on the same machine. > > Maybe we should simply rephrase this as: > > This package implements the support for external toolchains, i.e > toolchains that are available pre-built, ready to use. Such toolchain > me either be readily available on the Web (Linaro, Sourcery s/me/may/ > CodeBench, from processor vendors) or may be built with tools like > Crosstool-NG or Buildroot itself. Looks good to me. Would you like me to send a patch? baruch
Dear Baruch Siach, On Fri, 20 Feb 2015 08:37:26 +0200, Baruch Siach wrote: > > CodeBench, from processor vendors) or may be built with tools like > > Crosstool-NG or Buildroot itself. > > Looks good to me. Would you like me to send a patch? Yes, please :) Thanks! Thomas
diff --git a/toolchain/toolchain-external/toolchain-external.mk b/toolchain/toolchain-external/toolchain-external.mk index 5a69eb88958e..4376c8ddbf1f 100644 --- a/toolchain/toolchain-external/toolchain-external.mk +++ b/toolchain/toolchain-external/toolchain-external.mk @@ -6,9 +6,9 @@ # # This package implements the support for external toolchains, i.e -# toolchains that have not been produced by Buildroot itself and that -# Buildroot can download from the Web or that are already available on -# the system on which Buildroot runs. So far, we have tested this +# toolchains that have not been produced locally by Buildroot itself and +# that Buildroot can download from the Web or that are already available +# on the system on which Buildroot runs. So far, we have tested this # with: # # * Toolchains generated by Crosstool-NG
External toolchain can also have been generated by Buildroot previously, as the list that follows demonstrates. Add the word 'locally' at the right place to make the point clearer. Signed-off-by: Baruch Siach <baruch@tkos.co.il> --- toolchain/toolchain-external/toolchain-external.mk | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)