diff mbox

network-manager: Don't build Qt example programs

Message ID 1396624973-58181-1-git-send-email-Vincent.Riera@imgtec.com
State Accepted
Headers show

Commit Message

Vicente Olivert Riera April 4, 2014, 3:22 p.m. UTC
The purpose of "--enable-qt" option is not to build NetworkManager with
Qt support. It's name can be a bit confusing. The real purpose of this
option is to build Qt example programs, so we disable it as we also
disable the tests and documentation in the target.

Fixes:
   http://autobuild.buildroot.net/results/3b6/3b6a40c1683d0859a934e4d79e2048e97b193e94/

Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/network-manager/network-manager.mk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Yegor Yefremov April 4, 2014, 3:35 p.m. UTC | #1
On Fri, Apr 4, 2014 at 5:22 PM, Vicente Olivert Riera
<Vincent.Riera@imgtec.com> wrote:
> The purpose of "--enable-qt" option is not to build NetworkManager with
> Qt support. It's name can be a bit confusing. The real purpose of this
> option is to build Qt example programs, so we disable it as we also
> disable the tests and documentation in the target.
>
> Fixes:
>    http://autobuild.buildroot.net/results/3b6/3b6a40c1683d0859a934e4d79e2048e97b193e94/
>
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
>  package/network-manager/network-manager.mk |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/package/network-manager/network-manager.mk b/package/network-manager/network-manager.mk
> index 24bae63..1953888 100644
> --- a/package/network-manager/network-manager.mk
> +++ b/package/network-manager/network-manager.mk
> @@ -24,6 +24,7 @@ NETWORK_MANAGER_CONF_ENV = \
>  NETWORK_MANAGER_CONF_OPT = \
>                 --mandir=$(STAGING_DIR)/usr/man/ \
>                 --disable-tests \
> +               --disable-qt \
>                 --disable-more-warnings \
>                 --without-docs \
>                 --disable-gtk-doc \

Tested-by: Yegor Yefremov <yegorslists@googlemail.com>
Thomas Petazzoni April 4, 2014, 9:32 p.m. UTC | #2
Dear Vicente Olivert Riera,

On Fri, 4 Apr 2014 16:22:53 +0100, Vicente Olivert Riera wrote:
> The purpose of "--enable-qt" option is not to build NetworkManager with
> Qt support. It's name can be a bit confusing. The real purpose of this
> option is to build Qt example programs, so we disable it as we also
> disable the tests and documentation in the target.
> 
> Fixes:
>    http://autobuild.buildroot.net/results/3b6/3b6a40c1683d0859a934e4d79e2048e97b193e94/
> 
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
>  package/network-manager/network-manager.mk |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

Applied, thanks.

Thomas
diff mbox

Patch

diff --git a/package/network-manager/network-manager.mk b/package/network-manager/network-manager.mk
index 24bae63..1953888 100644
--- a/package/network-manager/network-manager.mk
+++ b/package/network-manager/network-manager.mk
@@ -24,6 +24,7 @@  NETWORK_MANAGER_CONF_ENV = \
 NETWORK_MANAGER_CONF_OPT = \
 		--mandir=$(STAGING_DIR)/usr/man/ \
 		--disable-tests \
+		--disable-qt \
 		--disable-more-warnings \
 		--without-docs \
 		--disable-gtk-doc \