| Message ID | 1396001767-4910-1-git-send-email-eric.le.bihan.dev@free.fr |
|---|---|
| State | Superseded |
| Headers | show |
Dear Eric Le Bihan, On Fri, 28 Mar 2014 11:16:07 +0100, Eric Le Bihan wrote: > Systemd only supports the architectures defined in > src/shared/architecture.h. This list does not contain ARC, Blackfin, > Xtensa, Microblaze and Nios2, so this package is disabled for these > architectures. > > Fixes > http://autobuild.buildroot.net/results/bcc/bcce95eb0748505c0d62db21a6e420aae3c3181b/ > > Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr> > --- > package/systemd/Config.in | 2 ++ > system/Config.in | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/package/systemd/Config.in b/package/systemd/Config.in > index 838e13e..66b5fc4 100644 > --- a/package/systemd/Config.in > +++ b/package/systemd/Config.in > @@ -2,6 +2,8 @@ config BR2_PACKAGE_SYSTEMD > bool "systemd" > depends on BR2_INIT_SYSTEMD > depends on !BR2_avr32 # no epoll_create1 > + depends on !BR2_arc && !BR2_bfin && !BR2_xtensa > + depends on !BR2_microblaze && !BR2_nios2 Maybe it's better to use positive logic here, and only explicitly allow systemd on the architectures that it supports. This way if tomorrow we add support for a new architecture, we won't get weird failures. In package/systemd/Config.in: config BR2_PACKAGE_SYSTEMD_ARCH_SUPPORTS bool default y if BR2_arm || BR2_powerpc || BR2_... and then use "depends on BR2_PACKAGE_SYSTEM_ARCH_SUPPORTS" where needed. Best regards, Thomas
Hi! On Fri, Mar 28, 2014 at 12:11:56PM +0100, Thomas Petazzoni wrote: > Dear Eric Le Bihan, > > On Fri, 28 Mar 2014 11:16:07 +0100, Eric Le Bihan wrote: > > Systemd only supports the architectures defined in > > src/shared/architecture.h. This list does not contain ARC, Blackfin, > > Xtensa, Microblaze and Nios2, so this package is disabled for these > > architectures. [...] > > Maybe it's better to use positive logic here, and only explicitly allow > systemd on the architectures that it supports. This way if tomorrow we > add support for a new architecture, we won't get weird failures. > > In package/systemd/Config.in: > > config BR2_PACKAGE_SYSTEMD_ARCH_SUPPORTS > bool > default y if BR2_arm || BR2_powerpc || BR2_... > > and then use "depends on BR2_PACKAGE_SYSTEM_ARCH_SUPPORTS" where needed. Thanks for the advice! I noticed BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT in package/qt/Config.in follows the same logic. Best regards, ELB
diff --git a/package/systemd/Config.in b/package/systemd/Config.in index 838e13e..66b5fc4 100644 --- a/package/systemd/Config.in +++ b/package/systemd/Config.in @@ -2,6 +2,8 @@ config BR2_PACKAGE_SYSTEMD bool "systemd" depends on BR2_INIT_SYSTEMD depends on !BR2_avr32 # no epoll_create1 + depends on !BR2_arc && !BR2_bfin && !BR2_xtensa + depends on !BR2_microblaze && !BR2_nios2 depends on BR2_LARGEFILE # util-linux depends on BR2_USE_WCHAR # util-linux depends on BR2_INET_IPV6 diff --git a/system/Config.in b/system/Config.in index e8f1ed6..217dbd4 100644 --- a/system/Config.in +++ b/system/Config.in @@ -88,6 +88,8 @@ config BR2_INIT_SYSV config BR2_INIT_SYSTEMD bool "systemd" depends on !BR2_avr32 # no epoll_create1 + depends on !BR2_arc && !BR2_bfin && !BR2_xtensa + depends on !BR2_microblaze && !BR2_nios2 depends on BR2_TOOLCHAIN_USES_GLIBC depends on BR2_LARGEFILE depends on BR2_USE_WCHAR
Systemd only supports the architectures defined in src/shared/architecture.h. This list does not contain ARC, Blackfin, Xtensa, Microblaze and Nios2, so this package is disabled for these architectures. Fixes http://autobuild.buildroot.net/results/bcc/bcce95eb0748505c0d62db21a6e420aae3c3181b/ Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr> --- package/systemd/Config.in | 2 ++ system/Config.in | 2 ++ 2 files changed, 4 insertions(+)