diff mbox

[3/3] rsyslog: bump to version 6.3.8

Message ID 1394459809-22174-3-git-send-email-clshotwe@rockwellcollins.com
State Superseded
Headers show

Commit Message

Clayton Shotwell March 10, 2014, 1:56 p.m. UTC
Bumping version of rsyslog and adding new dependencies of libee and
libestr.

Signed-off-by: Clayton Shotwell <clshotwe@rockwellcollins.com>
---
 package/rsyslog/rsyslog.mk |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Comments

Ryan Barnett March 10, 2014, 2:34 p.m. UTC | #1
Clayton,

Clayton Shotwell <clshotwe@rockwellcollins.com> wrote on 03/10/2014 
08:56:49 AM:

> 
################################################################################
> 
> -RSYSLOG_VERSION = 5.8.0
> +RSYSLOG_VERSION = 6.3.8
>  RSYSLOG_SITE = http://rsyslog.com/files/download/rsyslog/
> -RSYSLOG_DEPENDENCIES = zlib
> +RSYSLOG_DEPENDENCIES = zlib libestr libee
> 
>  # Build after Busybox
>  ifeq ($(BR2_PACKAGE_BUSYBOX),y)

Checking the website for rsyslog it appears that the latest version is 
7.6.0. Is there a reason to not bump to this version? Also could you add 
the license information since there doesn't appear to be any for this 
package?

Thanks,
-Ryan
Clayton Shotwell March 10, 2014, 7:03 p.m. UTC | #2
Ryan J Barnett/USA/RockwellCollins wrote on 03/10/2014 09:34:21 AM:

> From: Ryan J Barnett/USA/RockwellCollins
> To: Clayton Shotwell <clshotwe@rockwellcollins.com>
> Cc: buildroot@buildroot.org, buildroot-bounces@busybox.net
> Date: 03/10/2014 09:34 AM
> Subject: Re: [Buildroot] [PATCH 3/3] rsyslog: bump to version 6.3.8
> 
> Clayton,
> 
> Clayton Shotwell <clshotwe@rockwellcollins.com> wrote on 03/10/2014 
> 08:56:49 AM:
> 
> > 
> 
################################################################################
> > 
> > -RSYSLOG_VERSION = 5.8.0
> > +RSYSLOG_VERSION = 6.3.8
> >  RSYSLOG_SITE = http://rsyslog.com/files/download/rsyslog/
> > -RSYSLOG_DEPENDENCIES = zlib
> > +RSYSLOG_DEPENDENCIES = zlib libestr libee
> > 
> >  # Build after Busybox
> >  ifeq ($(BR2_PACKAGE_BUSYBOX),y)
> 
> Checking the website for rsyslog it appears that the latest version is 
> 7.6.0. Is there a reason to not bump to this version? Also could you add 

> the license information since there doesn't appear to be any for this 
> package?

I went with 6.3.8 initially because that was the version that contained 
the feature I need to use.  I didn't even check for a newer version.  I 
will get the 7.6.0 built and tested and then I will resubmit my patches.

Thanks,
Clayton

Clayton Shotwell
Software Engineer
clshotwe@rockwellcollins.com
www.rockwellcollins.com
Baruch Siach March 10, 2014, 7:14 p.m. UTC | #3
Hi Clayton,

On Mon, Mar 10, 2014 at 08:56:49AM -0500, Clayton Shotwell wrote:
> Bumping version of rsyslog and adding new dependencies of libee and
> libestr.
> 
> Signed-off-by: Clayton Shotwell <clshotwe@rockwellcollins.com>
> ---
>  package/rsyslog/rsyslog.mk |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/rsyslog/rsyslog.mk b/package/rsyslog/rsyslog.mk
> index daae010..3ca5eae 100644
> --- a/package/rsyslog/rsyslog.mk
> +++ b/package/rsyslog/rsyslog.mk
> @@ -4,9 +4,9 @@
>  #
>  ################################################################################
>  
> -RSYSLOG_VERSION = 5.8.0
> +RSYSLOG_VERSION = 6.3.8
>  RSYSLOG_SITE = http://rsyslog.com/files/download/rsyslog/
> -RSYSLOG_DEPENDENCIES = zlib
> +RSYSLOG_DEPENDENCIES = zlib libestr libee

Shouldn't you also select these packages in Config.in to make sure they are 
available?

baruch

>  # Build after Busybox
>  ifeq ($(BR2_PACKAGE_BUSYBOX),y)
> -- 
> 1.7.1
Clayton Shotwell March 10, 2014, 8:12 p.m. UTC | #4
Baruch Siach <baruch@tkos.co.il> wrote on 03/10/2014 02:14:53 PM:

> From: Baruch Siach <baruch@tkos.co.il>
> To: Clayton Shotwell <clshotwe@rockwellcollins.com>
> Cc: buildroot@buildroot.org
> Date: 03/10/2014 02:14 PM
> Subject: Re: [Buildroot] [PATCH 3/3] rsyslog: bump to version 6.3.8
> 
> Hi Clayton,
> 
> On Mon, Mar 10, 2014 at 08:56:49AM -0500, Clayton Shotwell wrote:
> > Bumping version of rsyslog and adding new dependencies of libee and
> > libestr.
> > 
> > Signed-off-by: Clayton Shotwell <clshotwe@rockwellcollins.com>
> > ---
> >  package/rsyslog/rsyslog.mk |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/package/rsyslog/rsyslog.mk b/package/rsyslog/rsyslog.mk
> > index daae010..3ca5eae 100644
> > --- a/package/rsyslog/rsyslog.mk
> > +++ b/package/rsyslog/rsyslog.mk
> > @@ -4,9 +4,9 @@
> >  #
> > 
> 
################################################################################
> > 
> > -RSYSLOG_VERSION = 5.8.0
> > +RSYSLOG_VERSION = 6.3.8
> >  RSYSLOG_SITE = http://rsyslog.com/files/download/rsyslog/
> > -RSYSLOG_DEPENDENCIES = zlib
> > +RSYSLOG_DEPENDENCIES = zlib libestr libee
> 
> Shouldn't you also select these packages in Config.in to make sure they 
are 
> available?
> 
> baruch

Yes I should. I'll make that change a resubmit.

Thanks,
Clayton

Clayton Shotwell
Software Engineer
clshotwe@rockwellcollins.com
www.rockwellcollins.com
diff mbox

Patch

diff --git a/package/rsyslog/rsyslog.mk b/package/rsyslog/rsyslog.mk
index daae010..3ca5eae 100644
--- a/package/rsyslog/rsyslog.mk
+++ b/package/rsyslog/rsyslog.mk
@@ -4,9 +4,9 @@ 
 #
 ################################################################################
 
-RSYSLOG_VERSION = 5.8.0
+RSYSLOG_VERSION = 6.3.8
 RSYSLOG_SITE = http://rsyslog.com/files/download/rsyslog/
-RSYSLOG_DEPENDENCIES = zlib
+RSYSLOG_DEPENDENCIES = zlib libestr libee
 
 # Build after Busybox
 ifeq ($(BR2_PACKAGE_BUSYBOX),y)