| Message ID | 1394039187-24328-1-git-send-email-Vincent.Riera@imgtec.com |
|---|---|
| State | Superseded |
| Headers | show |
On 05/03/14 18:06, Vicente Olivert Riera wrote: > Building o32 ELF files for MIPS64 is an exotic configuration that nobody > should be using. If o32 is required, then is better if it's built for > MIPS 32-bit cores so only 32-bit instructions will be used leading to a > more efficient o32 usage. > > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> > --- > arch/Config.in.mips | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/arch/Config.in.mips b/arch/Config.in.mips > index d9c0c02..e2b1e60 100644 > --- a/arch/Config.in.mips > +++ b/arch/Config.in.mips > @@ -47,6 +47,7 @@ choice > > config BR2_MIPS_OABI32 > bool "o32" > + depends on !BR2_ARCH_IS_64 > config BR2_MIPS_NABI32 > bool "n32" > depends on BR2_ARCH_IS_64 > Then maybe it's better to make the choice depend on BR2_ARCH_IS_64, and make the OABI32 symbol blind and default y on !BR2_ARCH_IS_64. Regards, Arnout
On 03/05/2014 11:27 PM, Arnout Vandecappelle wrote: > On 05/03/14 18:06, Vicente Olivert Riera wrote: >> Building o32 ELF files for MIPS64 is an exotic configuration that nobody >> should be using. If o32 is required, then is better if it's built for >> MIPS 32-bit cores so only 32-bit instructions will be used leading to a >> more efficient o32 usage. >> >> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> >> --- >> arch/Config.in.mips | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/arch/Config.in.mips b/arch/Config.in.mips >> index d9c0c02..e2b1e60 100644 >> --- a/arch/Config.in.mips >> +++ b/arch/Config.in.mips >> @@ -47,6 +47,7 @@ choice >> >> config BR2_MIPS_OABI32 >> bool "o32" >> + depends on !BR2_ARCH_IS_64 >> config BR2_MIPS_NABI32 >> bool "n32" >> depends on BR2_ARCH_IS_64 >> > > Then maybe it's better to make the choice depend on BR2_ARCH_IS_64, and > make the OABI32 symbol blind and default y on !BR2_ARCH_IS_64. OABI32 is already the default on !BR2_ARCH_IS_64. Take a look to this part of the Config.in.mips: choice prompt "Target ABI" depends on BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el default BR2_MIPS_OABI32 if !BR2_ARCH_IS_64 default BR2_MIPS_NABI32 if BR2_ARCH_IS_64 > > Regards, > Arnout >
On 06/03/14 10:51, Vicente Olivert Riera wrote: > On 03/05/2014 11:27 PM, Arnout Vandecappelle wrote: >> On 05/03/14 18:06, Vicente Olivert Riera wrote: >>> Building o32 ELF files for MIPS64 is an exotic configuration that nobody >>> should be using. If o32 is required, then is better if it's built for >>> MIPS 32-bit cores so only 32-bit instructions will be used leading to a >>> more efficient o32 usage. >>> >>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> >>> --- >>> arch/Config.in.mips | 1 + >>> 1 files changed, 1 insertions(+), 0 deletions(-) >>> >>> diff --git a/arch/Config.in.mips b/arch/Config.in.mips >>> index d9c0c02..e2b1e60 100644 >>> --- a/arch/Config.in.mips >>> +++ b/arch/Config.in.mips >>> @@ -47,6 +47,7 @@ choice >>> >>> config BR2_MIPS_OABI32 >>> bool "o32" >>> + depends on !BR2_ARCH_IS_64 >>> config BR2_MIPS_NABI32 >>> bool "n32" >>> depends on BR2_ARCH_IS_64 >>> >> >> Then maybe it's better to make the choice depend on BR2_ARCH_IS_64, and >> make the OABI32 symbol blind and default y on !BR2_ARCH_IS_64. > > OABI32 is already the default on !BR2_ARCH_IS_64. Take a look to this > part of the Config.in.mips: > > choice > prompt "Target ABI" > depends on BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el > default BR2_MIPS_OABI32 if !BR2_ARCH_IS_64 > default BR2_MIPS_NABI32 if BR2_ARCH_IS_64 It's not just the default, it's the only valid choice. So indeed, it already doesn't make much sense to present the user with the choice if there is only one option. However, removing it is currently a bit complicated because you need to keep the BR2_MIPS_OABI32 config in the choice for BR2_ARCH_IS_64. However, with your change, there is no need at all to keep the OABI32 option in the choice: if 64, it is forced to no, and if !64, it is forced to yes. BTW, something I forgot to mention earlier: ideally there should be a legacy detection for existing configs with 64 and OABI32. It may be a bit difficult to implement, however. Regards, Arnout > >> >> Regards, >> Arnout >> > >
On 03/06/2014 11:13 AM, Arnout Vandecappelle wrote: > On 06/03/14 10:51, Vicente Olivert Riera wrote: >> On 03/05/2014 11:27 PM, Arnout Vandecappelle wrote: >>> On 05/03/14 18:06, Vicente Olivert Riera wrote: >>>> Building o32 ELF files for MIPS64 is an exotic configuration that nobody >>>> should be using. If o32 is required, then is better if it's built for >>>> MIPS 32-bit cores so only 32-bit instructions will be used leading to a >>>> more efficient o32 usage. >>>> >>>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> >>>> --- >>>> arch/Config.in.mips | 1 + >>>> 1 files changed, 1 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/arch/Config.in.mips b/arch/Config.in.mips >>>> index d9c0c02..e2b1e60 100644 >>>> --- a/arch/Config.in.mips >>>> +++ b/arch/Config.in.mips >>>> @@ -47,6 +47,7 @@ choice >>>> >>>> config BR2_MIPS_OABI32 >>>> bool "o32" >>>> + depends on !BR2_ARCH_IS_64 >>>> config BR2_MIPS_NABI32 >>>> bool "n32" >>>> depends on BR2_ARCH_IS_64 >>>> >>> >>> Then maybe it's better to make the choice depend on BR2_ARCH_IS_64, and >>> make the OABI32 symbol blind and default y on !BR2_ARCH_IS_64. >> >> OABI32 is already the default on !BR2_ARCH_IS_64. Take a look to this >> part of the Config.in.mips: >> >> choice >> prompt "Target ABI" >> depends on BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el >> default BR2_MIPS_OABI32 if !BR2_ARCH_IS_64 >> default BR2_MIPS_NABI32 if BR2_ARCH_IS_64 > > It's not just the default, it's the only valid choice. So indeed, it > already doesn't make much sense to present the user with the choice if > there is only one option. However, removing it is currently a bit > complicated because you need to keep the BR2_MIPS_OABI32 config in the > choice for BR2_ARCH_IS_64. > > However, with your change, there is no need at all to keep the OABI32 > option in the choice: if 64, it is forced to no, and if !64, it is forced > to yes. > > > BTW, something I forgot to mention earlier: ideally there should be a > legacy detection for existing configs with 64 and OABI32. It may be a bit > difficult to implement, however. > > Regards, > Arnout > > >> >>> >>> Regards, >>> Arnout >>> >> >> > > Patch V2 sent: http://patchwork.ozlabs.org/patch/333638/
diff --git a/arch/Config.in.mips b/arch/Config.in.mips index d9c0c02..e2b1e60 100644 --- a/arch/Config.in.mips +++ b/arch/Config.in.mips @@ -47,6 +47,7 @@ choice config BR2_MIPS_OABI32 bool "o32" + depends on !BR2_ARCH_IS_64 config BR2_MIPS_NABI32 bool "n32" depends on BR2_ARCH_IS_64
Building o32 ELF files for MIPS64 is an exotic configuration that nobody should be using. If o32 is required, then is better if it's built for MIPS 32-bit cores so only 32-bit instructions will be used leading to a more efficient o32 usage. Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> --- arch/Config.in.mips | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)