| Message ID | 1392297727-17627-3-git-send-email-thomas.petazzoni@free-electrons.com |
|---|---|
| State | Superseded |
| Headers | show |
On Thu, Feb 13, 2014 at 2:22 PM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > --- > docs/manual/adding-packages-directory.txt | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt > index 754a145..e1299c3 100644 > --- a/docs/manual/adding-packages-directory.txt > +++ b/docs/manual/adding-packages-directory.txt > @@ -235,7 +235,13 @@ use in the comment. > > * thread support > ** Dependency symbol: +BR2_TOOLCHAIN_HAS_THREADS+ > -** Comment string: +threads+ > +** Comment string: +threads+ (unless +BR2_TOOLCHAIN_HAS_THREADS_NPTL+ > + is also needed, in which case, specifying only +NPTL threads+ is > + sufficient) > + > +* NPTL thread support > +** Dependency symbol: +BR2_TOOLCHAIN_HAS_THREADS_NPTL+ > +** Comment string: +NPTL threads+ > > * RPC support > ** Dependency symbol: +BR2_TOOLCHAIN_HAS_NATIVE_RPC+ Should we maybe use 'NPTL' rather than 'NPTL threads' to make the string shorter? (we want to fit in 80chars). It's true that it's a bit more cryptic, but so is RPC, wchar, etc. The biggest point is that a user can go to the Toolchain menu and recognize a string that matches, in this case the keyword NPTL. Best regards, Thomas
Dear Thomas De Schampheleire, On Thu, 13 Feb 2014 14:46:00 +0100, Thomas De Schampheleire wrote: > > * thread support > > ** Dependency symbol: +BR2_TOOLCHAIN_HAS_THREADS+ > > -** Comment string: +threads+ > > +** Comment string: +threads+ (unless +BR2_TOOLCHAIN_HAS_THREADS_NPTL+ > > + is also needed, in which case, specifying only +NPTL threads+ is > > + sufficient) > > + > > +* NPTL thread support > > +** Dependency symbol: +BR2_TOOLCHAIN_HAS_THREADS_NPTL+ > > +** Comment string: +NPTL threads+ > > > > * RPC support > > ** Dependency symbol: +BR2_TOOLCHAIN_HAS_NATIVE_RPC+ > > Should we maybe use 'NPTL' rather than 'NPTL threads' to make the > string shorter? (we want to fit in 80chars). > It's true that it's a bit more cryptic, but so is RPC, wchar, etc. > The biggest point is that a user can go to the Toolchain menu and > recognize a string that matches, in this case the keyword NPTL. Fine with me. I'll adjust that in the v2, but I'll wait a little bit more for other comments, if any :) Thanks for the review! Thomas
diff --git a/docs/manual/adding-packages-directory.txt b/docs/manual/adding-packages-directory.txt index 754a145..e1299c3 100644 --- a/docs/manual/adding-packages-directory.txt +++ b/docs/manual/adding-packages-directory.txt @@ -235,7 +235,13 @@ use in the comment. * thread support ** Dependency symbol: +BR2_TOOLCHAIN_HAS_THREADS+ -** Comment string: +threads+ +** Comment string: +threads+ (unless +BR2_TOOLCHAIN_HAS_THREADS_NPTL+ + is also needed, in which case, specifying only +NPTL threads+ is + sufficient) + +* NPTL thread support +** Dependency symbol: +BR2_TOOLCHAIN_HAS_THREADS_NPTL+ +** Comment string: +NPTL threads+ * RPC support ** Dependency symbol: +BR2_TOOLCHAIN_HAS_NATIVE_RPC+
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- docs/manual/adding-packages-directory.txt | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)