diff mbox

[06/14] libmodplug: new package

Message ID 1389549208-19078-7-git-send-email-maxime.hadjinlian@gmail.com
State Accepted
Headers show

Commit Message

Maxime Hadjinlian Jan. 12, 2014, 5:53 p.m. UTC
MOD music file decoder.
This package was originally found at : https://github.com/huceke/buildroot-rbp
By gimli <ebsi4711@gmail.com>

Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
---
 package/Config.in                |  1 +
 package/libmodplug/Config.in     | 10 ++++++++++
 package/libmodplug/libmodplug.mk | 12 ++++++++++++
 3 files changed, 23 insertions(+)
 create mode 100644 package/libmodplug/Config.in
 create mode 100644 package/libmodplug/libmodplug.mk

Comments

Bernd Kuhls Jan. 12, 2014, 6:41 p.m. UTC | #1
Maxime Hadjinlian
<maxime.hadjinlian@gmail.com> wrote in
news:1389549208-19078-7-git-send-email-maxime.hadjinlian@gmail.com: 

> +LIBMODPLUG_VERSION = 0.8.7

Hi,

current version is 0.8.8.4.

Regards, Bernd
Yann E. MORIN Jan. 14, 2014, 10:36 p.m. UTC | #2
Maxime, All,

On 2014-01-12 18:53 +0100, Maxime Hadjinlian spake thusly:
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>

Otherwise:
    Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

/me likes the easy ones... :-)

Regards,
Yann E. MORIN.
Peter Korsgaard Jan. 15, 2014, 8:55 p.m. UTC | #3
>>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes:

 > MOD music file decoder.
 > This package was originally found at : https://github.com/huceke/buildroot-rbp
 > By gimli <ebsi4711@gmail.com>

 > Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
 > ---
 >  package/Config.in                |  1 +
 >  package/libmodplug/Config.in     | 10 ++++++++++
 >  package/libmodplug/libmodplug.mk | 12 ++++++++++++
 >  3 files changed, 23 insertions(+)
 >  create mode 100644 package/libmodplug/Config.in
 >  create mode 100644 package/libmodplug/libmodplug.mk

 > diff --git a/package/Config.in b/package/Config.in
 > index d50c5ec..836dc7e 100644
 > --- a/package/Config.in
 > +++ b/package/Config.in
 > @@ -452,6 +452,7 @@ source "package/libcuefile/Config.in"
 >  source "package/libid3tag/Config.in"
 >  source "package/liblo/Config.in"
 >  source "package/libmad/Config.in"
 > +source "package/libmodplug/Config.in"
 >  source "package/libmpd/Config.in"
 >  source "package/libreplaygain/Config.in"
 >  source "package/libsamplerate/Config.in"
 > diff --git a/package/libmodplug/Config.in b/package/libmodplug/Config.in
 > new file mode 100644
 > index 0000000..976a08b
 > --- /dev/null
 > +++ b/package/libmodplug/Config.in
 > @@ -0,0 +1,10 @@
 > +config BR2_PACKAGE_LIBMODPLUG
 > +	bool "libmodplug"
 > +	depends on BR2_INSTALL_LIBSTDCPP
 > +	help
 > +	  MOD music file decoder
 > +
 > +	  http://modplug-xmms.sourceforge.net/
 > +
 > +comment "libmodplug requires C++ support in toolchain"
 > +	depends on !BR2_INSTALL_LIBSTDCPP

We've standardized on '<foo> needs a toolchain w/ C++' now.

 > diff --git a/package/libmodplug/libmodplug.mk b/package/libmodplug/libmodplug.mk
 > new file mode 100644
 > index 0000000..14df808
 > --- /dev/null
 > +++ b/package/libmodplug/libmodplug.mk
 > @@ -0,0 +1,12 @@
 > +#############################################################

80 char #'s.

 > +#
 > +# libmodplug
 > +#
 > +#############################################################
 > +
 > +LIBMODPLUG_VERSION = 0.8.7
 > +LIBMODPLUG_SITE = http://downloads.sourceforge.net/project/modplug-xmms/libmodplug/$(LIBMODPLUG_VERSION)
 > +LIBMODPLUG_INSTALL_STAGING = YES
 > +LIBMODPLUG_LICENSE = Public Domain

You forgot _LICENSE_FILES.

Committed with these fixes, thanks.
Maxime Hadjinlian Jan. 15, 2014, 11:19 p.m. UTC | #4
Hi all,

On Wed, Jan 15, 2014 at 9:55 PM, Peter Korsgaard <jacmet@uclibc.org> wrote:
>>>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes:
>
>  > MOD music file decoder.
>  > This package was originally found at : https://github.com/huceke/buildroot-rbp
>  > By gimli <ebsi4711@gmail.com>
>
>  > Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
>  > ---
>  >  package/Config.in                |  1 +
>  >  package/libmodplug/Config.in     | 10 ++++++++++
>  >  package/libmodplug/libmodplug.mk | 12 ++++++++++++
>  >  3 files changed, 23 insertions(+)
>  >  create mode 100644 package/libmodplug/Config.in
>  >  create mode 100644 package/libmodplug/libmodplug.mk
>
>  > diff --git a/package/Config.in b/package/Config.in
>  > index d50c5ec..836dc7e 100644
>  > --- a/package/Config.in
>  > +++ b/package/Config.in
>  > @@ -452,6 +452,7 @@ source "package/libcuefile/Config.in"
>  >  source "package/libid3tag/Config.in"
>  >  source "package/liblo/Config.in"
>  >  source "package/libmad/Config.in"
>  > +source "package/libmodplug/Config.in"
>  >  source "package/libmpd/Config.in"
>  >  source "package/libreplaygain/Config.in"
>  >  source "package/libsamplerate/Config.in"
>  > diff --git a/package/libmodplug/Config.in b/package/libmodplug/Config.in
>  > new file mode 100644
>  > index 0000000..976a08b
>  > --- /dev/null
>  > +++ b/package/libmodplug/Config.in
>  > @@ -0,0 +1,10 @@
>  > +config BR2_PACKAGE_LIBMODPLUG
>  > +    bool "libmodplug"
>  > +    depends on BR2_INSTALL_LIBSTDCPP
>  > +    help
>  > +      MOD music file decoder
>  > +
>  > +      http://modplug-xmms.sourceforge.net/
>  > +
>  > +comment "libmodplug requires C++ support in toolchain"
>  > +    depends on !BR2_INSTALL_LIBSTDCPP
>
> We've standardized on '<foo> needs a toolchain w/ C++' now.
Ok, I will fix this, then send again the whole series with all the comments.
>
>  > diff --git a/package/libmodplug/libmodplug.mk b/package/libmodplug/libmodplug.mk
>  > new file mode 100644
>  > index 0000000..14df808
>  > --- /dev/null
>  > +++ b/package/libmodplug/libmodplug.mk
>  > @@ -0,0 +1,12 @@
>  > +#############################################################
>
> 80 char #'s.
>
>  > +#
>  > +# libmodplug
>  > +#
>  > +#############################################################
>  > +
>  > +LIBMODPLUG_VERSION = 0.8.7
>  > +LIBMODPLUG_SITE = http://downloads.sourceforge.net/project/modplug-xmms/libmodplug/$(LIBMODPLUG_VERSION)
>  > +LIBMODPLUG_INSTALL_STAGING = YES
>  > +LIBMODPLUG_LICENSE = Public Domain
>
> You forgot _LICENSE_FILES.
>
> Committed with these fixes, thanks.
Thanks
>
> --
> Bye, Peter Korsgaard
diff mbox

Patch

diff --git a/package/Config.in b/package/Config.in
index d50c5ec..836dc7e 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -452,6 +452,7 @@  source "package/libcuefile/Config.in"
 source "package/libid3tag/Config.in"
 source "package/liblo/Config.in"
 source "package/libmad/Config.in"
+source "package/libmodplug/Config.in"
 source "package/libmpd/Config.in"
 source "package/libreplaygain/Config.in"
 source "package/libsamplerate/Config.in"
diff --git a/package/libmodplug/Config.in b/package/libmodplug/Config.in
new file mode 100644
index 0000000..976a08b
--- /dev/null
+++ b/package/libmodplug/Config.in
@@ -0,0 +1,10 @@ 
+config BR2_PACKAGE_LIBMODPLUG
+	bool "libmodplug"
+	depends on BR2_INSTALL_LIBSTDCPP
+	help
+	  MOD music file decoder
+
+	  http://modplug-xmms.sourceforge.net/
+
+comment "libmodplug requires C++ support in toolchain"
+	depends on !BR2_INSTALL_LIBSTDCPP
diff --git a/package/libmodplug/libmodplug.mk b/package/libmodplug/libmodplug.mk
new file mode 100644
index 0000000..14df808
--- /dev/null
+++ b/package/libmodplug/libmodplug.mk
@@ -0,0 +1,12 @@ 
+#############################################################
+#
+# libmodplug
+#
+#############################################################
+
+LIBMODPLUG_VERSION = 0.8.7
+LIBMODPLUG_SITE = http://downloads.sourceforge.net/project/modplug-xmms/libmodplug/$(LIBMODPLUG_VERSION)
+LIBMODPLUG_INSTALL_STAGING = YES
+LIBMODPLUG_LICENSE = Public Domain
+
+$(eval $(autotools-package))