| Message ID | 1385112407-3569-1-git-send-email-s.martin49@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
Samuel, Samuel Martin <s.martin49@gmail.com> wrote on 11/22/2013 03:26:47 AM: [...] > diff --git a/package/ofono/Config.in b/package/ofono/Config.in > index c431e08..1cb41ea 100644 > --- a/package/ofono/Config.in > +++ b/package/ofono/Config.in > @@ -3,6 +3,7 @@ config BR2_PACKAGE_OFONO > depends on BR2_USE_WCHAR # gettext, libglib2 > depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2 > depends on BR2_USE_MMU # dbus > + depends on !BR2_avr32 # libcap-ng > select BR2_PACKAGE_LIBCAP_NG > select BR2_PACKAGE_DBUS > select BR2_PACKAGE_LIBGLIB2 > @@ -15,5 +16,6 @@ config BR2_PACKAGE_OFONO > http://ofono.org/ > > comment "ofono needs a toolchain w/ wchar, threads" Wouldn't you want comment above saying and !avr32 or something to that extent? > + depends on !BR2_avr32 > depends on BR2_USE_MMU > depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS Thanks, -Ryan
Hi Ryan, 2013/11/22 Ryan Barnett <rjbarnet@rockwellcollins.com> > Samuel, > > Samuel Martin <s.martin49@gmail.com> wrote on 11/22/2013 03:26:47 AM: > > [...] > > > diff --git a/package/ofono/Config.in b/package/ofono/Config.in > > index c431e08..1cb41ea 100644 > > --- a/package/ofono/Config.in > > +++ b/package/ofono/Config.in > > @@ -3,6 +3,7 @@ config BR2_PACKAGE_OFONO > > depends on BR2_USE_WCHAR # gettext, libglib2 > > depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2 > > depends on BR2_USE_MMU # dbus > > + depends on !BR2_avr32 # libcap-ng > > select BR2_PACKAGE_LIBCAP_NG > > select BR2_PACKAGE_DBUS > > select BR2_PACKAGE_LIBGLIB2 > > @@ -15,5 +16,6 @@ config BR2_PACKAGE_OFONO > > http://ofono.org/ > > > > comment "ofono needs a toolchain w/ wchar, threads" > > Wouldn't you want comment above saying and !avr32 or something to that > extent? > According to the manual ( http://git.buildroot.net/buildroot/tree/docs/manual/adding-packages-directory.txt#n213), this is not needed. > > + depends on !BR2_avr32 > > depends on BR2_USE_MMU > > depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS > > Thanks, > -Ryan > > Regards,
Samuel Martin <s.martin49@gmail.com> wrote on 11/22/2013 03:39:17 AM: > 2013/11/22 Ryan Barnett <rjbarnet@rockwellcollins.com> [...] > > Wouldn't you want comment above saying and !avr32 or something to that > > extent? > According to the manual > ( http://git.buildroot.net/buildroot/tree/docs/manual/adding-packages-directory.txt#n213 ), > this is not needed. > Thanks for the information as I didn't remember off the top of my head! So disregard my comment then :) Thanks, -Ryan
>>>>> "Samuel" == Samuel Martin <s.martin49@gmail.com> writes: > libcap-ng needs TLS support, which is not available on avr32. > Also, disable reverse dependencies. > Fixes: > http://autobuild.buildroot.net/results/73c/73c7c211a51c312bbe4eb6a540f3ad9c92c79ebe/ > Signed-off-by: Samuel Martin <s.martin49@gmail.com> > --- > changes v1 -> v2: > - add the 'depends on' statement to the ofono comment (ThomasP) Committed, thanks.
diff --git a/package/libcap-ng/Config.in b/package/libcap-ng/Config.in index d1663cd..da5b447 100644 --- a/package/libcap-ng/Config.in +++ b/package/libcap-ng/Config.in @@ -1,5 +1,6 @@ config BR2_PACKAGE_LIBCAP_NG bool "libcap-ng" + depends on !BR2_avr32 # lacks TLS help The libcap-ng library is intended to make programming with posix capabilities much easier than the traditional libcap diff --git a/package/ofono/Config.in b/package/ofono/Config.in index c431e08..1cb41ea 100644 --- a/package/ofono/Config.in +++ b/package/ofono/Config.in @@ -3,6 +3,7 @@ config BR2_PACKAGE_OFONO depends on BR2_USE_WCHAR # gettext, libglib2 depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2 depends on BR2_USE_MMU # dbus + depends on !BR2_avr32 # libcap-ng select BR2_PACKAGE_LIBCAP_NG select BR2_PACKAGE_DBUS select BR2_PACKAGE_LIBGLIB2 @@ -15,5 +16,6 @@ config BR2_PACKAGE_OFONO http://ofono.org/ comment "ofono needs a toolchain w/ wchar, threads" + depends on !BR2_avr32 depends on BR2_USE_MMU depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
libcap-ng needs TLS support, which is not available on avr32. Also, disable reverse dependencies. Fixes: http://autobuild.buildroot.net/results/73c/73c7c211a51c312bbe4eb6a540f3ad9c92c79ebe/ Signed-off-by: Samuel Martin <s.martin49@gmail.com> --- changes v1 -> v2: - add the 'depends on' statement to the ofono comment (ThomasP) --- package/libcap-ng/Config.in | 1 + package/ofono/Config.in | 2 ++ 2 files changed, 3 insertions(+)