| Message ID | 1384639674-15170-1-git-send-email-arnaud.aujon@gmail.com |
|---|---|
| State | Accepted |
| Commit | 93adbf9c00671cb5983cfa7b11b04d2d72ab344b |
| Headers | show |
>>>>> "Arnaud" == Arnaud Aujon <arnaud.aujon@gmail.com> writes: > Fix a typo in squashfs site url > Signed-off-by: Arnaud Aujon <arnaud.aujon@gmail.com> Committed, thanks.
Dear Arnaud Aujon, On Sat, 16 Nov 2013 23:07:54 +0100, Arnaud Aujon wrote: > Fix a typo in squashfs site url > > Signed-off-by: Arnaud Aujon <arnaud.aujon@gmail.com> Just a quick comment: the title of the patch should have been: squashfs: fix typo in url or package/squashfs: fix typo in url You've used "[squashfs] fix typo in url" as the title, but this doesn't work really nicely, because the part between [ and ] gets removed by Git when applying the patch. Therefore, the title of your patch has became only "fix typo in url", which isn't very descriptive. Best regards, Thomas
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes: > Dear Arnaud Aujon, > On Sat, 16 Nov 2013 23:07:54 +0100, Arnaud Aujon wrote: >> Fix a typo in squashfs site url >> >> Signed-off-by: Arnaud Aujon <arnaud.aujon@gmail.com> > Just a quick comment: the title of the patch should have been: > squashfs: fix typo in url > or > package/squashfs: fix typo in url > You've used "[squashfs] fix typo in url" as the title, but this doesn't > work really nicely, because the part between [ and ] gets removed by > Git when applying the patch. Therefore, the title of your patch has > became only "fix typo in url", which isn't very descriptive. Indeed, and I should have corrected it when committing, but I forgot :/
Thomas, 2013/11/17 Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > Dear Arnaud Aujon, > > You've used "[squashfs] fix typo in url" as the title, but this doesn't > work really nicely, because the part between [ and ] gets removed by > Git when applying the patch. Therefore, the title of your patch has > became only "fix typo in url", which isn't very descriptive. > Sorry about that, I will be more careful next time. Regards, Arnaud
diff --git a/package/squashfs/squashfs.mk b/package/squashfs/squashfs.mk index 04a26c6..bff308c 100644 --- a/package/squashfs/squashfs.mk +++ b/package/squashfs/squashfs.mk @@ -6,7 +6,7 @@ SQUASHFS_VERSION = 4.2 SQUASHFS_SOURCE = squashfs$(SQUASHFS_VERSION).tar.gz -SQUASHFS_SITE = http://downloads.sourceforge.net/projct/squashfs/squashfs/squashfs$(SQUASHFS_VERSION) +SQUASHFS_SITE = http://downloads.sourceforge.net/project/squashfs/squashfs/squashfs$(SQUASHFS_VERSION) # no libattr in BR SQUASHFS_MAKE_ARGS = XATTR_SUPPORT=0
Fix a typo in squashfs site url Signed-off-by: Arnaud Aujon <arnaud.aujon@gmail.com> --- package/squashfs/squashfs.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)