| Message ID | 1381267637-3957-1-git-send-email-jerzy.grzegorek@trzebnica.net |
|---|---|
| State | Superseded |
| Headers | show |
Dear Jerzy Grzegorek, On Tue, 8 Oct 2013 23:27:17 +0200, Jerzy Grzegorek wrote: > config BR2_PACKAGE_XLIB_LIBPTHREAD_STUBS > bool "libpthread-stubs" > + depends on BR2_TOOLCHAIN_HAS_THREADS No, that doesn't work. When you add a toolchain dependency to one package, you must propagate it to the reverse dependencies of this package that are selecting this package. For example, libdrm and libxcb are both selecting XLIB_LIBPTHREAD_STUBS, but they do not have the BR2_TOOLCHAIN_HAS_THREADS, so you should add this dependency to libdrm and libxcb as well. Best regards, Thomas
Hi Thomas, > Dear Jerzy Grzegorek, > > On Tue, 8 Oct 2013 23:27:17 +0200, Jerzy Grzegorek wrote: > >> config BR2_PACKAGE_XLIB_LIBPTHREAD_STUBS >> bool "libpthread-stubs" >> + depends on BR2_TOOLCHAIN_HAS_THREADS > No, that doesn't work. When you add a toolchain dependency to one > package, you must propagate it to the reverse dependencies of this > package that are selecting this package. > > For example, libdrm and libxcb are both selecting > XLIB_LIBPTHREAD_STUBS, but they do not have the > BR2_TOOLCHAIN_HAS_THREADS, so you should add this dependency to libdrm > and libxcb as well. Thanks for clarification. Regards, Jerzy > Best regards, > > Thomas
diff --git a/package/x11r7/xlib_libpthread-stubs/Config.in b/package/x11r7/xlib_libpthread-stubs/Config.in index fb53585..b2df95a 100644 --- a/package/x11r7/xlib_libpthread-stubs/Config.in +++ b/package/x11r7/xlib_libpthread-stubs/Config.in @@ -1,7 +1,11 @@ config BR2_PACKAGE_XLIB_LIBPTHREAD_STUBS bool "libpthread-stubs" + depends on BR2_TOOLCHAIN_HAS_THREADS help This library provides weak aliases for pthread functions not provided in libc or otherwise available by default. http://xcb.freedesktop.org/ + +comment "xlib_libpthread-stubs needs a toolchain with thread support" + depends on !BR2_TOOLCHAIN_HAS_THREADS
Fixes: http://autobuild.buildroot.org/results/609/6099baac4bb469ae18aab6512233db25183eaabd/ Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net> --- package/x11r7/xlib_libpthread-stubs/Config.in | 4 ++++ 1 file changed, 4 insertions(+)