| Message ID | 1375001692-12024-1-git-send-email-tjlee@ambarella.com |
|---|---|
| State | Accepted |
| Commit | e8ab39a7b5205e6a1a076fdda257a5baa32be765 |
| Delegated to: | Thomas De Schampheleire |
| Headers | show |
On 28/07/13 10:54, Tzu-Jung Lee wrote: > One of the use cases is for the 'local packages' to restore > the SCM info. Some packages use this information to generate > version info during build time. In this case, the local package > can have this hook to restore it by symbolic link for example. > > Signed-off-by: Tzu-Jung Lee <tjlee@ambarella.com> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Although IMHO it's a bit of a hack to use it for that specific use case. That use case would be better served with rsync -au --cvs-exclude --include core $($(PKG)_RSYNC_OPTS) $(SRCDIR)/ $(@D) (note that it is possible to set FOO_RSYNC_OPTS in the override file). Regards, Arnout > --- > Include the comments aginst v1 from Thomas De Schampheleire: > > Updte manual for the new hook. > Set the default hook to empty > > docs/manual/adding-packages-generic.txt | 1 + > package/pkg-generic.mk | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/docs/manual/adding-packages-generic.txt b/docs/manual/adding-packages-generic.txt > index faf70b1..2889add 100644 > --- a/docs/manual/adding-packages-generic.txt > +++ b/docs/manual/adding-packages-generic.txt > @@ -441,6 +441,7 @@ The following hook points are available: > > * +LIBFOO_POST_DOWNLOAD_HOOKS+ > * +LIBFOO_POST_EXTRACT_HOOKS+ > +* +LIBFOO_POST_RSYNC_HOOKS+ > * +LIBFOO_PRE_PATCH_HOOKS+ > * +LIBFOO_POST_PATCH_HOOKS+ > * +LIBFOO_PRE_CONFIGURE_HOOKS+ > diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk > index d9a12f2..3d3adc9 100644 > --- a/package/pkg-generic.mk > +++ b/package/pkg-generic.mk > @@ -63,6 +63,7 @@ $(BUILD_DIR)/%/.stamp_rsynced: > @$(call MESSAGE,"Syncing from source dir $(SRCDIR)") > @test -d $(SRCDIR) || (echo "ERROR: $(SRCDIR) does not exist" ; exit 1) > rsync -au --cvs-exclude --include core $(SRCDIR)/ $(@D) > + $(foreach hook,$($(PKG)_POST_RSYNC_HOOKS),$(call $(hook))$(sep)) > $(Q)touch $@ > > # Handle the SOURCE_CHECK and SHOW_EXTERNAL_DEPS cases for rsynced > @@ -337,6 +338,7 @@ $(2)_EXTRACT_CMDS ?= \ > # post-steps hooks > $(2)_POST_DOWNLOAD_HOOKS ?= > $(2)_POST_EXTRACT_HOOKS ?= > +$(2)_POST_RSYNC_HOOKS ?= > $(2)_PRE_PATCH_HOOKS ?= > $(2)_POST_PATCH_HOOKS ?= > $(2)_PRE_CONFIGURE_HOOKS ?= >
diff --git a/docs/manual/adding-packages-generic.txt b/docs/manual/adding-packages-generic.txt index faf70b1..2889add 100644 --- a/docs/manual/adding-packages-generic.txt +++ b/docs/manual/adding-packages-generic.txt @@ -441,6 +441,7 @@ The following hook points are available: * +LIBFOO_POST_DOWNLOAD_HOOKS+ * +LIBFOO_POST_EXTRACT_HOOKS+ +* +LIBFOO_POST_RSYNC_HOOKS+ * +LIBFOO_PRE_PATCH_HOOKS+ * +LIBFOO_POST_PATCH_HOOKS+ * +LIBFOO_PRE_CONFIGURE_HOOKS+ diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk index d9a12f2..3d3adc9 100644 --- a/package/pkg-generic.mk +++ b/package/pkg-generic.mk @@ -63,6 +63,7 @@ $(BUILD_DIR)/%/.stamp_rsynced: @$(call MESSAGE,"Syncing from source dir $(SRCDIR)") @test -d $(SRCDIR) || (echo "ERROR: $(SRCDIR) does not exist" ; exit 1) rsync -au --cvs-exclude --include core $(SRCDIR)/ $(@D) + $(foreach hook,$($(PKG)_POST_RSYNC_HOOKS),$(call $(hook))$(sep)) $(Q)touch $@ # Handle the SOURCE_CHECK and SHOW_EXTERNAL_DEPS cases for rsynced @@ -337,6 +338,7 @@ $(2)_EXTRACT_CMDS ?= \ # post-steps hooks $(2)_POST_DOWNLOAD_HOOKS ?= $(2)_POST_EXTRACT_HOOKS ?= +$(2)_POST_RSYNC_HOOKS ?= $(2)_PRE_PATCH_HOOKS ?= $(2)_POST_PATCH_HOOKS ?= $(2)_PRE_CONFIGURE_HOOKS ?=
One of the use cases is for the 'local packages' to restore the SCM info. Some packages use this information to generate version info during build time. In this case, the local package can have this hook to restore it by symbolic link for example. Signed-off-by: Tzu-Jung Lee <tjlee@ambarella.com> --- Include the comments aginst v1 from Thomas De Schampheleire: Updte manual for the new hook. Set the default hook to empty docs/manual/adding-packages-generic.txt | 1 + package/pkg-generic.mk | 2 ++ 2 files changed, 3 insertions(+)