| Message ID | 1374944218-19629-1-git-send-email-tjlee@ambarella.com |
|---|---|
| State | Superseded |
| Headers | show |
Hi Tzu-Jung Lee, On Sat, Jul 27, 2013 at 6:56 PM, Tzu-Jung Lee <roylee17@gmail.com> wrote: > Signed-off-by: Tzu-Jung Lee <tjlee@ambarella.com> Could you explain more about the use case of this patch? Why do you want to override the rsync command? > --- > package/pkg-generic.mk | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk > index b8eaa98..d9a12f2 100644 > --- a/package/pkg-generic.mk > +++ b/package/pkg-generic.mk > @@ -309,6 +309,10 @@ $(2)_INSTALL_IMAGES ?= NO > $(2)_INSTALL_TARGET ?= YES > $(2)_DIR_PREFIX = $(if $(4),$(4),$(TOP_SRCDIR)/package) > > +# default rsync command > +$(2)_RSYNC_CMDS ?= \ > + rsync -au --cvs-exclude --include core $(SRCDIR)/ $(@D) > + > # define sub-target stamps > $(2)_TARGET_INSTALL_TARGET = $$($(2)_DIR)/.stamp_target_installed > $(2)_TARGET_INSTALL_STAGING = $$($(2)_DIR)/.stamp_staging_installed I fail to understand how this will work without further changes. Even if a package defines FOO_RSYNC_CMDS, where is it used? I guess the original rsync commands should be replaced by the new variable. Also here, documentation should be updated to reflect new features. Best regards, Thomas
diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk index b8eaa98..d9a12f2 100644 --- a/package/pkg-generic.mk +++ b/package/pkg-generic.mk @@ -309,6 +309,10 @@ $(2)_INSTALL_IMAGES ?= NO $(2)_INSTALL_TARGET ?= YES $(2)_DIR_PREFIX = $(if $(4),$(4),$(TOP_SRCDIR)/package) +# default rsync command +$(2)_RSYNC_CMDS ?= \ + rsync -au --cvs-exclude --include core $(SRCDIR)/ $(@D) + # define sub-target stamps $(2)_TARGET_INSTALL_TARGET = $$($(2)_DIR)/.stamp_target_installed $(2)_TARGET_INSTALL_STAGING = $$($(2)_DIR)/.stamp_staging_installed
Signed-off-by: Tzu-Jung Lee <tjlee@ambarella.com> --- package/pkg-generic.mk | 4 ++++ 1 file changed, 4 insertions(+)