From patchwork Sat Jun 8 09:14:21 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Petazzoni X-Patchwork-Id: 249941 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (silver.osuosl.org [140.211.166.136]) by ozlabs.org (Postfix) with ESMTP id BB0F52C0174 for ; Sat, 8 Jun 2013 19:15:42 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 8B5A031EB7; Sat, 8 Jun 2013 09:15:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hVL5ApRQdRy4; Sat, 8 Jun 2013 09:15:31 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id C94E531EB4; Sat, 8 Jun 2013 09:15:10 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (fraxinus.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 382E08F753 for ; Sat, 8 Jun 2013 09:14:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 96E22FFC96 for ; Sat, 8 Jun 2013 09:14:38 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0WXlUHdPQLIL for ; Sat, 8 Jun 2013 09:14:37 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.free-electrons.com (mail.free-electrons.com [94.23.35.102]) by fraxinus.osuosl.org (Postfix) with ESMTP id 4E18BFFB56 for ; Sat, 8 Jun 2013 09:14:37 +0000 (UTC) Received: by mail.free-electrons.com (Postfix, from userid 106) id 46A007B0; Sat, 8 Jun 2013 11:14:37 +0200 (CEST) Received: from localhost (AToulouse-651-1-76-8.w92-156.abo.wanadoo.fr [92.156.131.8]) by mail.free-electrons.com (Postfix) with ESMTPSA id CB6B5768; Sat, 8 Jun 2013 11:14:36 +0200 (CEST) From: Thomas Petazzoni To: buildroot@uclibc.org Date: Sat, 8 Jun 2013 11:14:21 +0200 Message-Id: <1370682862-7285-8-git-send-email-thomas.petazzoni@free-electrons.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1370682862-7285-1-git-send-email-thomas.petazzoni@free-electrons.com> References: <1370682862-7285-1-git-send-email-thomas.petazzoni@free-electrons.com> Subject: [Buildroot] [PATCH 8/9] ext-toolchain-wrapper: force hash-style to 'both' X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net From: Patrick Ziegler If ext-toolchain-wrapper was build with gcc that uses hash-style 'gnu' by default, the resulting binary might be unusable on other systems. The error in this case is "Floating point exception". Using hash-style 'both' solves this issue. Signed-off-by: Patrick Ziegler Signed-off-by: Thomas Petazzoni --- toolchain/toolchain-external/ext-tool.mk | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/toolchain/toolchain-external/ext-tool.mk b/toolchain/toolchain-external/ext-tool.mk index 30a4953..430b2bc 100644 --- a/toolchain/toolchain-external/ext-tool.mk +++ b/toolchain/toolchain-external/ext-tool.mk @@ -491,7 +491,9 @@ $(HOST_DIR)/usr/bin/ext-toolchain-wrapper: $(STAMP_DIR)/ext-toolchain-installed ;; \ esac; \ done ; - $(HOSTCC) $(HOST_CFLAGS) $(TOOLCHAIN_EXTERNAL_WRAPPER_ARGS) -s \ + # We use --hash-style=both to increase the compatibility of + # the generated binary with older platforms + $(HOSTCC) $(HOST_CFLAGS) $(TOOLCHAIN_EXTERNAL_WRAPPER_ARGS) -s -Wl,--hash-style=both \ toolchain/toolchain-external/ext-toolchain-wrapper.c -o $@ # 'uclibc' is the target to provide toolchain / staging dir