diff mbox

[v2] package/libbsd: depends on architectures providing a.out.h

Message ID 1370502475-13022-1-git-send-email-yann.morin.1998@free.fr
State Accepted
Commit 29b071077f66de1d9a257e7c5c6983dcce1fc65d
Headers show

Commit Message

Yann E. MORIN June 6, 2013, 7:07 a.m. UTC 
From: "Yann E. MORIN" <yann.morin.1998@free.fr>

libbsd requires a.out.h, which is only available in a select subset
of the architectures Buildroot supports.

Propagate these new dependencies down to libedit.

Fixes:
    http://autobuild.buildroot.org/results/019/019091312ec547520370ffad967b53e23f54a14b
    http://autobuild.buildroot.org/results/87c/87c3a8bf2248606d80ddcfd96132de4c5fe869ed
    http://autobuild.buildroot.org/results/589/5891f539ce3f3ff2e3411228472c8833fdd0d7c0
    [...]

Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
Changes v1 -> v2:
  - propagate dependencies down to libedit, instead of changes
    'select' into 'depends on'  (Peter)

---
 package/libbsd/Config.in  | 3 +++
 package/libedit/Config.in | 1 +
 2 files changed, 4 insertions(+)

Comments

Peter Korsgaard June 6, 2013, 7:35 a.m. UTC | #1 
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 Yann> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
 Yann> libbsd requires a.out.h, which is only available in a select subset
 Yann> of the architectures Buildroot supports.

 Yann> Propagate these new dependencies down to libedit.

Committed, thanks.
diff mbox

Patch

diff --git a/package/libbsd/Config.in b/package/libbsd/Config.in
index 0ed9dac..915a4bd 100644
--- a/package/libbsd/Config.in
+++ b/package/libbsd/Config.in
@@ -1,5 +1,8 @@ 
 config BR2_PACKAGE_LIBBSD
 	bool "libbsd"
+	# libbsd requires a.out.h, which is only available for those
+	# architectures: arm, m68k, x86 (and alpha, but we don't care.)
+	depends on ( BR2_arm || BR2_armeb || BR2_m68k || BR2_i386 || BR2_x86_64 )
 	help
 	  This library provides useful functions commonly found on BSD
 	  systems, and lacking on others like GNU systems, thus making
diff --git a/package/libedit/Config.in b/package/libedit/Config.in
index b49c23c..34160f4 100644
--- a/package/libedit/Config.in
+++ b/package/libedit/Config.in
@@ -1,5 +1,6 @@ 
 config BR2_PACKAGE_LIBEDIT
 	bool "libedit"
+	depends on ( BR2_arm || BR2_armeb || BR2_m68k || BR2_i386 || BR2_x86_64 )  # libbsd
 	select BR2_PACKAGE_LIBBSD
 	select BR2_PACKAGE_NCURSES
 	help