diff mbox

[2/5] tvheadend: needs threads

Message ID 1369268647-13128-2-git-send-email-gilles.talis@gmail.com
State Accepted
Commit f937306ead7605c1c8a9360503d1a5f92202c229
Headers show

Commit Message

Gilles Talis May 23, 2013, 12:24 a.m. UTC
Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
---
 package/tvheadend/Config.in |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

Comments

Yann E. MORIN May 23, 2013, 6:54 a.m. UTC | #1
Gilles, All,

On 2013-05-22 17:24 -0700, Gilles Talis spake thusly:
> Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
> ---
>  package/tvheadend/Config.in |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/package/tvheadend/Config.in b/package/tvheadend/Config.in
> index 19ab276..7083b01 100644
> --- a/package/tvheadend/Config.in
> +++ b/package/tvheadend/Config.in
> @@ -1,9 +1,10 @@
> -comment "tvheadend requires a toolchain with LARGEFILE and IPv6 support"
> -    depends on !BR2_LARGEFILE || !BR2_INET_IPV6
> +comment "tvheadend needs a toolchain with LARGEFILE, IPv6 and THREADS support"
> +    depends on !BR2_LARGEFILE || !BR2_INET_IPV6 || !BR2_TOOLCHAIN_HAS_THREADS
>  
>  config BR2_PACKAGE_TVHEADEND
>  	bool "tvheadend"
>  	depends on BR2_LARGEFILE && BR2_INET_IPV6
> +	depends on BR2_TOOLCHAIN_HAS_THREADS

Is it because tvheadend selects dvb-apps that it requires threads, or
does it itself require threads?

If the former, then:
	depends on BR2_TOOLCHAIN_HAS_THREADS # dvb-apps

If the latter, then OK.

Regards,
Yann E. MORIN.
Gilles Talis May 23, 2013, 2:44 p.m. UTC | #2
Yann, all,

2013/5/22 Yann E. MORIN <yann.morin.1998@free.fr>:
> Gilles, All,
>
> Is it because tvheadend selects dvb-apps that it requires threads, or
> does it itself require threads?
>
It is tvheadend that needs threads. It is not dvb-apps that requires
threads, but dvb-apps utils.
By the way, thanks for the ack on my dvb-apps utils patch.

Regards,
Gilles.
Yann E. MORIN May 23, 2013, 5:42 p.m. UTC | #3
Gilles, All,

On 2013-05-23 07:44 -0700, Gilles Talis spake thusly:
> 2013/5/22 Yann E. MORIN <yann.morin.1998@free.fr>:
> > Gilles, All,
> >
> > Is it because tvheadend selects dvb-apps that it requires threads, or
> > does it itself require threads?
> >
> It is tvheadend that needs threads.

OK.

> It is not dvb-apps that requires
> threads, but dvb-apps utils.

Yep, I meant dvb-apps utils.

Regards,
Yann E. MORIN.
Peter Korsgaard May 23, 2013, 8:34 p.m. UTC | #4
>>>>> "Gilles" == Gilles Talis <gilles.talis@gmail.com> writes:

 Gilles> Signed-off-by: Gilles Talis <gilles.talis@gmail.com>

Committed, thanks.
diff mbox

Patch

diff --git a/package/tvheadend/Config.in b/package/tvheadend/Config.in
index 19ab276..7083b01 100644
--- a/package/tvheadend/Config.in
+++ b/package/tvheadend/Config.in
@@ -1,9 +1,10 @@ 
-comment "tvheadend requires a toolchain with LARGEFILE and IPv6 support"
-    depends on !BR2_LARGEFILE || !BR2_INET_IPV6
+comment "tvheadend needs a toolchain with LARGEFILE, IPv6 and THREADS support"
+    depends on !BR2_LARGEFILE || !BR2_INET_IPV6 || !BR2_TOOLCHAIN_HAS_THREADS
 
 config BR2_PACKAGE_TVHEADEND
 	bool "tvheadend"
 	depends on BR2_LARGEFILE && BR2_INET_IPV6
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	# tvheadend requires an atomic_add operation. Either you have
 	# a gcc >= 4.3 toolchain and it uses the gcc intrinsics, or it
 	# has special code for x86, x86-64, PPC and ARM. So in the