Message ID | 1349256390-9956-1-git-send-email-arnout@mind.be |
---|---|
State | Accepted |
Headers | show |
Peter, Could you apply this one? It has been around for a very long time. Thanks! Thomas On Wed, 3 Oct 2012 11:26:30 +0200, Arnout Vandecappelle (Essensium/Mind) wrote: > When compiling for the same architecture and libc as the host, > GNU_TARGET_NAME and GNU_HOST_NAME are equal. configure scripts use > these to detect cross-compilation, and will decide that we're doing > native compilation. This may trigger running of executables, > which fail because of missing libraries in the host environment. > > To solve this, set the vendor part in GNU_TARGET_NAME to buildroot. > > This problem exists for instance in xserver_xorg-server on x86_64. > > Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> > Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > --- > RESEND I hit this again while compiling xserver_xorg-server... > RESEND-2 And again, after testing the xorg updates. > Added ThomasP's Acked-by as well. > > v3: modify GNU_TARGET_NAME instead of GNU_HOST_NAME, which makes a lot > more sense of course. Thank you ThomasP! > > I only tested this one with xserver_xorg-server on a Sourcery > x86_64 toolchain and with a simple config and an internal > toolchain. > > v2: -buildroot- instead of -buildroot_cross-, as suggested by ThomasP. > > package/Makefile.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/Makefile.in b/package/Makefile.in > index 64508b2..30a542a 100644 > --- a/package/Makefile.in > +++ b/package/Makefile.in > @@ -20,7 +20,7 @@ MAKE1:=$(HOSTMAKE) -j1 > MAKE:=$(HOSTMAKE) -j$(PARALLEL_JOBS) > > # Compute GNU_TARGET_NAME > -GNU_TARGET_NAME=$(ARCH)-unknown-linux-$(LIBC)$(ABI) > +GNU_TARGET_NAME=$(ARCH)-buildroot-linux-$(LIBC)$(ABI) > > ifeq > ($(BR2_TOOLCHAIN_BUILDROOT)$(BR2_TOOLCHAIN_CTNG_uClibc)$(BR2_TOOLCHAIN_EXTERNAL_UCLIBC),y) > LIBC=uclibc
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:
Arnout> When compiling for the same architecture and libc as the host,
Arnout> GNU_TARGET_NAME and GNU_HOST_NAME are equal. configure scripts use
Arnout> these to detect cross-compilation, and will decide that we're doing
Arnout> native compilation. This may trigger running of executables,
Arnout> which fail because of missing libraries in the host environment.
Arnout> To solve this, set the vendor part in GNU_TARGET_NAME to buildroot.
Arnout> This problem exists for instance in xserver_xorg-server on x86_64.
Committed, thanks.
On Thu, 04 Oct 2012 22:50:45 +0200, Peter Korsgaard wrote:
> Committed, thanks.
Thanks!
Thomas
diff --git a/package/Makefile.in b/package/Makefile.in index 64508b2..30a542a 100644 --- a/package/Makefile.in +++ b/package/Makefile.in @@ -20,7 +20,7 @@ MAKE1:=$(HOSTMAKE) -j1 MAKE:=$(HOSTMAKE) -j$(PARALLEL_JOBS) # Compute GNU_TARGET_NAME -GNU_TARGET_NAME=$(ARCH)-unknown-linux-$(LIBC)$(ABI) +GNU_TARGET_NAME=$(ARCH)-buildroot-linux-$(LIBC)$(ABI) ifeq ($(BR2_TOOLCHAIN_BUILDROOT)$(BR2_TOOLCHAIN_CTNG_uClibc)$(BR2_TOOLCHAIN_EXTERNAL_UCLIBC),y) LIBC=uclibc