Message ID | 1337067382-19212-1-git-send-email-faessler@was.ch |
---|---|
State | Accepted |
Headers | show |
Hoi Dominik, Thank you for your contribution. You patch looks very good, with a few small remarks. Please add a Signed-off-by line for yourself. This is a short way for you to assert that you are entitled to contribute the patch under buildroot's GPL license. See http://kerneltrap.org/files/Jeremy/DCO.txt for more details. On 05/15/12 09:36, Dominik Fässler wrote: [snip] > --- /dev/null > +++ b/package/logsurfer/logsurfer.mk > @@ -0,0 +1,15 @@ > +############################################################# > +# > +# logsurfer > +# > +############################################################# > + > +LOGSURFER_VERSION = 1.8 > +LOGSURFER_SOURCE = logsurfer-$(LOGSURFER_VERSION).tar.gz > +LOGSURFER_SITE = http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/logsurfer/logsurfer/logsurfer-${LOGSURFER_VERSION} We try to be consistent in using $() to reference variables, rather than ${}. > +define LOGSURFER_INSTALL_TARGET_CMDS > + $(INSTALL) -D -m 0755 $(@D)/src/logsurfer $(TARGET_DIR)/bin > +endef > + > +$(eval $(call AUTOTARGETS,package,logsurfer)) The arguments to AUTOTARGETS are no longer necessary. Regards, Arnout
>>>>> "Dominik" == Dominik Fässler <faessler@was.ch> writes:
Dominik> ---
Dominik> package/Config.in | 1 +
Dominik> package/logsurfer/Config.in | 7 +++++++
Dominik> package/logsurfer/logsurfer.mk | 15 +++++++++++++++
Dominik> 3 files changed, 23 insertions(+), 0 deletions(-)
Dominik> create mode 100644 package/logsurfer/Config.in
Dominik> create mode 100644 package/logsurfer/logsurfer.mk
Dominik> diff --git a/package/Config.in b/package/Config.in
Dominik> index 4e3c414..091f8d6 100644
Dominik> --- a/package/Config.in
Dominik> +++ b/package/Config.in
Dominik> @@ -613,6 +613,7 @@ source "package/file/Config.in"
Dominik> source "package/inotify-tools/Config.in"
Dominik> source "package/lockfile-progs/Config.in"
Dominik> source "package/logrotate/Config.in"
Dominik> +source "package/logsurfer/Config.in"
Dominik> source "package/screen/Config.in"
Dominik> source "package/sudo/Config.in"
Dominik> if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
Dominik> diff --git a/package/logsurfer/Config.in b/package/logsurfer/Config.in
Dominik> new file mode 100644
Dominik> index 0000000..27d1881
Dominik> --- /dev/null
Dominik> +++ b/package/logsurfer/Config.in
Dominik> @@ -0,0 +1,7 @@
Dominik> +config BR2_PACKAGE_LOGSURFER
Dominik> + bool "logsurfer"
Dominik> + help
Dominik> + Logsurfer is a program for monitoring system logs in real-time,
Dominik> + and reporting on the occurrence of events.
Dominik> +
Dominik> + http://www.crypt.gen.nz/logsurfer/
Dominik> diff --git a/package/logsurfer/logsurfer.mk b/package/logsurfer/logsurfer.mk
Dominik> new file mode 100644
Dominik> index 0000000..31405ff
Dominik> --- /dev/null
Dominik> +++ b/package/logsurfer/logsurfer.mk
Dominik> @@ -0,0 +1,15 @@
Dominik> +#############################################################
Dominik> +#
Dominik> +# logsurfer
Dominik> +#
Dominik> +#############################################################
Dominik> +
Dominik> +LOGSURFER_VERSION = 1.8
Dominik> +LOGSURFER_SOURCE = logsurfer-$(LOGSURFER_VERSION).tar.gz
Dominik> +LOGSURFER_SITE = http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/logsurfer/logsurfer/logsurfer-${LOGSURFER_VERSION}
Dominik> +
Dominik> +define LOGSURFER_INSTALL_TARGET_CMDS
Dominik> + $(INSTALL) -D -m 0755 $(@D)/src/logsurfer $(TARGET_DIR)/bin
Dominik> +endef
Next to the feedback Arnout gave you, this line is wrong. With install
-D you need to provide the destination file name as well, and it would
be good to install man pages if BR2_HAVE_DOCUMENTATION is enabled.
I've fixed up these things and committed to next, thanks.
diff --git a/package/Config.in b/package/Config.in index 4e3c414..091f8d6 100644 --- a/package/Config.in +++ b/package/Config.in @@ -613,6 +613,7 @@ source "package/file/Config.in" source "package/inotify-tools/Config.in" source "package/lockfile-progs/Config.in" source "package/logrotate/Config.in" +source "package/logsurfer/Config.in" source "package/screen/Config.in" source "package/sudo/Config.in" if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS diff --git a/package/logsurfer/Config.in b/package/logsurfer/Config.in new file mode 100644 index 0000000..27d1881 --- /dev/null +++ b/package/logsurfer/Config.in @@ -0,0 +1,7 @@ +config BR2_PACKAGE_LOGSURFER + bool "logsurfer" + help + Logsurfer is a program for monitoring system logs in real-time, + and reporting on the occurrence of events. + + http://www.crypt.gen.nz/logsurfer/ diff --git a/package/logsurfer/logsurfer.mk b/package/logsurfer/logsurfer.mk new file mode 100644 index 0000000..31405ff --- /dev/null +++ b/package/logsurfer/logsurfer.mk @@ -0,0 +1,15 @@ +############################################################# +# +# logsurfer +# +############################################################# + +LOGSURFER_VERSION = 1.8 +LOGSURFER_SOURCE = logsurfer-$(LOGSURFER_VERSION).tar.gz +LOGSURFER_SITE = http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/logsurfer/logsurfer/logsurfer-${LOGSURFER_VERSION} + +define LOGSURFER_INSTALL_TARGET_CMDS + $(INSTALL) -D -m 0755 $(@D)/src/logsurfer $(TARGET_DIR)/bin +endef + +$(eval $(call AUTOTARGETS,package,logsurfer))