| Message ID | 0301f2d3c762f8815c7c6dc25ed5ea8307275305.1418322200.git.yann.morin.1998@free.fr |
|---|---|
| State | Superseded |
| Headers | show |
Dear Yann E. MORIN, On Thu, 11 Dec 2014 19:24:48 +0100, Yann E. MORIN wrote: > In some cases, upstream just update their releases in-place, without > renaming them. When that package is updated in Buildroot, a new hash to > match the new upstream release is included in the corresponding .hash > file. We could also mention the case of SourceForge sending HTML crap from time to time, and things like that. > Note: this does not add any overhead compared to the previous situation, > because we were already checking hashes of localy cached files. It just locally. Other than that: Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
diff --git a/support/download/dl-wrapper b/support/download/dl-wrapper index fdb49db..d66715f 100755 --- a/support/download/dl-wrapper +++ b/support/download/dl-wrapper @@ -56,7 +56,11 @@ main() { # If the output file already exists, do not download it again if [ -e "${output}" ]; then - exit 0 + if support/download/check-hash "${hfile}" "${output}" "${output##*/}"; then + exit 0 + fi + rm -f "${output}" + printf "Re-downloading '%s'...\n" "${output##*/}" fi # tmpd is a temporary directory in which backends may store intermediate
In some cases, upstream just update their releases in-place, without renaming them. When that package is updated in Buildroot, a new hash to match the new upstream release is included in the corresponding .hash file. As a consequence, users who previously downloaded that package's tarball with an older version of Buildroot, will get stuck with an old archive for that package, and after updating their Buildroot copy, will be greeted with a failed download, due to the local file not matching the new hashes. So, to avoid this situation, check the hashes prior to doing the download. If the hashes match, consider the locally cached file genuine, and do not download it. However, if the locally cached file does not match the known hashes we have for it, it is promptly removed, and a download is re-attempted. Note: this does not add any overhead compared to the previous situation, because we were already checking hashes of localy cached files. It just changes the order in which we do the checks. For the records, here is the overhead of hashing a 231MiB file (qt-everywhere-opensource-src-4.8.6.tar.gz) on a core-i5 @2.5GHz: cache-cold cache-hot sha1 1.914s 0.762s sha256 2.109s 1.270s But again, this overhead already existed before this patch. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Cc: Peter Korsgaard <jacmet@uclibc.org> Cc: Gustavo Zacarias <gustavo@zacarias.com.ar> --- support/download/dl-wrapper | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)