mbox series

[v12,00/16] Add support for AM62x-SK HS-FS devices

Message ID 20240407103512.1112712-1-romain.naour@smile.fr
Headers show
Series Add support for AM62x-SK HS-FS devices | expand

Message

Romain Naour April 7, 2024, 10:34 a.m. UTC
This series aims initially to fix AM62x-SK HS-FS devices but doing so
would requires adding a TI legacy tool "ti-k3-core-secdev" into Buildroot.
ti-k3-core-secdev is replaced by u-boot's binman tool since v2023.10 release
of u-boot.

Instead, we bump the BSP to use the latest u-boot release (2024.01) to use
binman. Doing so requires to rework the TI K3 SoC support in Buildroot.

This new version (v12) of this series remove the ti-k3 package and
all SOC and SECTYPE options. As suggested by Michael Walle, copy the
default tiboot3.bin and sysfw.itb (if any) if no custom file name is
provided on the defconfig. Since such file name can be customized,
the user must provide the complete firmware name if not using the
default one.

http://lists.busybox.net/pipermail/buildroot/2024-April/688943.html

With the advice of Andreas Dannenberg (TI K3 architect), we switch
AM62x/AM62Ax/AM64x to HS-FS by default.

Tests performed on earlier revision of this series:

* compiled ti_am62x_sk_defconfig
  * success
* booted on AM62x SK EVM (E3)
  * success
  * no obvious errors in dmesg

Tested-by: Gero Schwäricke <gero.schwaericke@grandcentrix.net>

Dario Binacchi (10):
  boot/ti-k3-r5-loader: drop hash for version 2022.10
  boot/ti-k3-r5-loader: add BR2_TARGET_TI_K3_R5_LOADER_USE_BINMAN option
  boot/uboot: add BR2_TARGET_UBOOT_USE_BINMAN option
  boot/ti-k3-r5-loader: install tiboot3.bin and sysfw.itb to
    BINARIES_DIR
  configs/ti_am62x_sk_defconfig: bump U-Boot version to 2024.01
  configs/ti_am62x_sk_defconfig: bump Linux version to 6.6.18
  board/ti/am62x-sk: generalize post-build.sh
  board/ti/am62x-sk: move post-build.sh to board/ti/common/am6xx
  configs/ti_am64x_sk_defconfig: bump U-Boot version to 2024.01
  configs/ti_am64x_sk_defconfig: bump Linux version to 6.6.18

Romain Naour (6):
  board/ti/am6{2,4}x-sk: add arm-trusted-firmware v2.7 hash
  boot/uboot: rename TI_K3_DM option to cover further TI K3 SoCs support
  boot/uboot: remove BR2_TARGET_UBOOT_TI_K3_DM_SOCNAME
  boot/ti-k3-image-gen: remove package
  boot/ti-k3-r5-loader: remove BR2_TARGET_TI_K3_R5_LOADER_USE_BINMAN
  package/ti-k3: switch AM62x/AM62Ax/AM64x to HS-FS by default

 Config.in.legacy                              | 15 ++++
 DEVELOPERS                                    |  2 -
 board/ti/am62x-sk/genimage.cfg                |  7 +-
 .../arm-trusted-firmware.hash                 |  2 +
 .../patches/linux-headers/linux-headers.hash  |  1 +
 board/ti/am62x-sk/patches/linux/linux.hash    |  2 +
 .../ti-k3-r5-loader/ti-k3-r5-loader.hash      |  2 +
 board/ti/am64x-sk/genimage.cfg                |  7 +-
 .../arm-trusted-firmware.hash                 |  2 +
 .../patches/linux-headers/linux-headers.hash  |  1 +
 board/ti/am64x-sk/patches/linux/linux.hash    |  2 +
 .../ti-k3-r5-loader/ti-k3-r5-loader.hash      |  1 +
 board/ti/common/am6xx/post-build.sh           | 58 ++++++++++++++
 boot/Config.in                                |  1 -
 boot/ti-k3-image-gen/Config.in                | 77 -------------------
 boot/ti-k3-image-gen/ti-k3-image-gen.hash     |  3 -
 boot/ti-k3-image-gen/ti-k3-image-gen.mk       | 54 -------------
 boot/ti-k3-r5-loader/Config.in                | 33 ++++++++
 boot/ti-k3-r5-loader/ti-k3-r5-loader.hash     |  1 -
 boot/ti-k3-r5-loader/ti-k3-r5-loader.mk       | 40 +++++++++-
 boot/uboot/Config.in                          | 35 +++++----
 boot/uboot/uboot.mk                           | 12 ++-
 configs/ti_am62x_sk_defconfig                 | 21 ++---
 configs/ti_am64x_sk_defconfig                 | 20 +++--
 24 files changed, 221 insertions(+), 178 deletions(-)
 create mode 100644 board/ti/am62x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash
 create mode 120000 board/ti/am62x-sk/patches/linux-headers/linux-headers.hash
 create mode 100644 board/ti/am62x-sk/patches/linux/linux.hash
 create mode 100644 board/ti/am62x-sk/patches/ti-k3-r5-loader/ti-k3-r5-loader.hash
 create mode 100644 board/ti/am64x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash
 create mode 120000 board/ti/am64x-sk/patches/linux-headers/linux-headers.hash
 create mode 100644 board/ti/am64x-sk/patches/linux/linux.hash
 create mode 100644 board/ti/am64x-sk/patches/ti-k3-r5-loader/ti-k3-r5-loader.hash
 create mode 100755 board/ti/common/am6xx/post-build.sh
 delete mode 100644 boot/ti-k3-image-gen/Config.in
 delete mode 100644 boot/ti-k3-image-gen/ti-k3-image-gen.hash
 delete mode 100644 boot/ti-k3-image-gen/ti-k3-image-gen.mk

--
2.44.0

Comments

Arnout Vandecappelle April 7, 2024, 8:30 p.m. UTC | #1
On 07/04/2024 12:34, Romain Naour wrote:
> This series aims initially to fix AM62x-SK HS-FS devices but doing so
> would requires adding a TI legacy tool "ti-k3-core-secdev" into Buildroot.
> ti-k3-core-secdev is replaced by u-boot's binman tool since v2023.10 release
> of u-boot.
> 
> Instead, we bump the BSP to use the latest u-boot release (2024.01) to use
> binman. Doing so requires to rework the TI K3 SoC support in Buildroot.
> 
> This new version (v12) of this series remove the ti-k3 package and
> all SOC and SECTYPE options. As suggested by Michael Walle, copy the
> default tiboot3.bin and sysfw.itb (if any) if no custom file name is
> provided on the defconfig. Since such file name can be customized,
> the user must provide the complete firmware name if not using the
> default one.
> 
> http://lists.busybox.net/pipermail/buildroot/2024-April/688943.html
> 
> With the advice of Andreas Dannenberg (TI K3 architect), we switch
> AM62x/AM62Ax/AM64x to HS-FS by default.
> 
> Tests performed on earlier revision of this series:
> 
> * compiled ti_am62x_sk_defconfig
>    * success
> * booted on AM62x SK EVM (E3)
>    * success
>    * no obvious errors in dmesg
> 
> Tested-by: Gero Schwäricke <gero.schwaericke@grandcentrix.net>
> 
> Dario Binacchi (10):
>    boot/ti-k3-r5-loader: drop hash for version 2022.10
>    boot/ti-k3-r5-loader: add BR2_TARGET_TI_K3_R5_LOADER_USE_BINMAN option
>    boot/uboot: add BR2_TARGET_UBOOT_USE_BINMAN option
>    boot/ti-k3-r5-loader: install tiboot3.bin and sysfw.itb to
>      BINARIES_DIR
>    configs/ti_am62x_sk_defconfig: bump U-Boot version to 2024.01
>    configs/ti_am62x_sk_defconfig: bump Linux version to 6.6.18
>    board/ti/am62x-sk: generalize post-build.sh
>    board/ti/am62x-sk: move post-build.sh to board/ti/common/am6xx
>    configs/ti_am64x_sk_defconfig: bump U-Boot version to 2024.01
>    configs/ti_am64x_sk_defconfig: bump Linux version to 6.6.18
> 
> Romain Naour (6):
>    board/ti/am6{2,4}x-sk: add arm-trusted-firmware v2.7 hash
>    boot/uboot: rename TI_K3_DM option to cover further TI K3 SoCs support
>    boot/uboot: remove BR2_TARGET_UBOOT_TI_K3_DM_SOCNAME
>    boot/ti-k3-image-gen: remove package
>    boot/ti-k3-r5-loader: remove BR2_TARGET_TI_K3_R5_LOADER_USE_BINMAN
>    package/ti-k3: switch AM62x/AM62Ax/AM64x to HS-FS by default

  Patches 1-5 applied to master. And there I stopped, due to the SWSFW typo. I 
could have fixed it up myself but it's really every patch that needs to be 
updated...


  Regards,
  Arnout

> 
>   Config.in.legacy                              | 15 ++++
>   DEVELOPERS                                    |  2 -
>   board/ti/am62x-sk/genimage.cfg                |  7 +-
>   .../arm-trusted-firmware.hash                 |  2 +
>   .../patches/linux-headers/linux-headers.hash  |  1 +
>   board/ti/am62x-sk/patches/linux/linux.hash    |  2 +
>   .../ti-k3-r5-loader/ti-k3-r5-loader.hash      |  2 +
>   board/ti/am64x-sk/genimage.cfg                |  7 +-
>   .../arm-trusted-firmware.hash                 |  2 +
>   .../patches/linux-headers/linux-headers.hash  |  1 +
>   board/ti/am64x-sk/patches/linux/linux.hash    |  2 +
>   .../ti-k3-r5-loader/ti-k3-r5-loader.hash      |  1 +
>   board/ti/common/am6xx/post-build.sh           | 58 ++++++++++++++
>   boot/Config.in                                |  1 -
>   boot/ti-k3-image-gen/Config.in                | 77 -------------------
>   boot/ti-k3-image-gen/ti-k3-image-gen.hash     |  3 -
>   boot/ti-k3-image-gen/ti-k3-image-gen.mk       | 54 -------------
>   boot/ti-k3-r5-loader/Config.in                | 33 ++++++++
>   boot/ti-k3-r5-loader/ti-k3-r5-loader.hash     |  1 -
>   boot/ti-k3-r5-loader/ti-k3-r5-loader.mk       | 40 +++++++++-
>   boot/uboot/Config.in                          | 35 +++++----
>   boot/uboot/uboot.mk                           | 12 ++-
>   configs/ti_am62x_sk_defconfig                 | 21 ++---
>   configs/ti_am64x_sk_defconfig                 | 20 +++--
>   24 files changed, 221 insertions(+), 178 deletions(-)
>   create mode 100644 board/ti/am62x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash
>   create mode 120000 board/ti/am62x-sk/patches/linux-headers/linux-headers.hash
>   create mode 100644 board/ti/am62x-sk/patches/linux/linux.hash
>   create mode 100644 board/ti/am62x-sk/patches/ti-k3-r5-loader/ti-k3-r5-loader.hash
>   create mode 100644 board/ti/am64x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash
>   create mode 120000 board/ti/am64x-sk/patches/linux-headers/linux-headers.hash
>   create mode 100644 board/ti/am64x-sk/patches/linux/linux.hash
>   create mode 100644 board/ti/am64x-sk/patches/ti-k3-r5-loader/ti-k3-r5-loader.hash
>   create mode 100755 board/ti/common/am6xx/post-build.sh
>   delete mode 100644 boot/ti-k3-image-gen/Config.in
>   delete mode 100644 boot/ti-k3-image-gen/ti-k3-image-gen.hash
>   delete mode 100644 boot/ti-k3-image-gen/ti-k3-image-gen.mk
> 
> --
> 2.44.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
Arnout Vandecappelle April 8, 2024, 1:47 p.m. UTC | #2
On 07/04/2024 22:30, Arnout Vandecappelle wrote:
>
>
> On 07/04/2024 12:34, Romain Naour wrote:
>> This series aims initially to fix AM62x-SK HS-FS devices but doing so
>> would requires adding a TI legacy tool "ti-k3-core-secdev" into Buildroot.
>> ti-k3-core-secdev is replaced by u-boot's binman tool since v2023.10 release
>> of u-boot.
>>
>> Instead, we bump the BSP to use the latest u-boot release (2024.01) to use
>> binman. Doing so requires to rework the TI K3 SoC support in Buildroot.
>>
>> This new version (v12) of this series remove the ti-k3 package and
>> all SOC and SECTYPE options. As suggested by Michael Walle, copy the
>> default tiboot3.bin and sysfw.itb (if any) if no custom file name is
>> provided on the defconfig. Since such file name can be customized,
>> the user must provide the complete firmware name if not using the
>> default one.
>>
>> http://lists.busybox.net/pipermail/buildroot/2024-April/688943.html
>>
>> With the advice of Andreas Dannenberg (TI K3 architect), we switch
>> AM62x/AM62Ax/AM64x to HS-FS by default.
>>
>> Tests performed on earlier revision of this series:
>>
>> * compiled ti_am62x_sk_defconfig
>>    * success
>> * booted on AM62x SK EVM (E3)
>>    * success
>>    * no obvious errors in dmesg
>>
>> Tested-by: Gero Schwäricke <gero.schwaericke@grandcentrix.net>
>>
>> Dario Binacchi (10):
>>    boot/ti-k3-r5-loader: drop hash for version 2022.10
>>    boot/ti-k3-r5-loader: add BR2_TARGET_TI_K3_R5_LOADER_USE_BINMAN option
>>    boot/uboot: add BR2_TARGET_UBOOT_USE_BINMAN option
>>    boot/ti-k3-r5-loader: install tiboot3.bin and sysfw.itb to
>>      BINARIES_DIR
>>    configs/ti_am62x_sk_defconfig: bump U-Boot version to 2024.01
>>    configs/ti_am62x_sk_defconfig: bump Linux version to 6.6.18
>>    board/ti/am62x-sk: generalize post-build.sh
>>    board/ti/am62x-sk: move post-build.sh to board/ti/common/am6xx
>>    configs/ti_am64x_sk_defconfig: bump U-Boot version to 2024.01
>>    configs/ti_am64x_sk_defconfig: bump Linux version to 6.6.18
>>
>> Romain Naour (6):
>>    board/ti/am6{2,4}x-sk: add arm-trusted-firmware v2.7 hash
>>    boot/uboot: rename TI_K3_DM option to cover further TI K3 SoCs support
>>    boot/uboot: remove BR2_TARGET_UBOOT_TI_K3_DM_SOCNAME
>>    boot/ti-k3-image-gen: remove package
>>    boot/ti-k3-r5-loader: remove BR2_TARGET_TI_K3_R5_LOADER_USE_BINMAN
>>    package/ti-k3: switch AM62x/AM62Ax/AM64x to HS-FS by default
>
>  Patches 1-5 applied to master. And there I stopped, due to the SWSFW typo. I 
> could have fixed it up myself but it's really every patch that needs to be 
> updated...


  I also reviewed the rest of the series with minor comments, so you can apply 
them directly (with my Reviewed-by: Arnout Vandecappelle <arnout@mind.be>)


  Regards,
  Arnout


>
>
>  Regards,
>  Arnout
>
>>
>>   Config.in.legacy                              | 15 ++++
>>   DEVELOPERS                                    |  2 -
>>   board/ti/am62x-sk/genimage.cfg                |  7 +-
>>   .../arm-trusted-firmware.hash                 |  2 +
>>   .../patches/linux-headers/linux-headers.hash  |  1 +
>>   board/ti/am62x-sk/patches/linux/linux.hash    |  2 +
>>   .../ti-k3-r5-loader/ti-k3-r5-loader.hash      |  2 +
>>   board/ti/am64x-sk/genimage.cfg                |  7 +-
>>   .../arm-trusted-firmware.hash                 |  2 +
>>   .../patches/linux-headers/linux-headers.hash  |  1 +
>>   board/ti/am64x-sk/patches/linux/linux.hash    |  2 +
>>   .../ti-k3-r5-loader/ti-k3-r5-loader.hash      |  1 +
>>   board/ti/common/am6xx/post-build.sh           | 58 ++++++++++++++
>>   boot/Config.in                                |  1 -
>>   boot/ti-k3-image-gen/Config.in                | 77 -------------------
>>   boot/ti-k3-image-gen/ti-k3-image-gen.hash     |  3 -
>>   boot/ti-k3-image-gen/ti-k3-image-gen.mk       | 54 -------------
>>   boot/ti-k3-r5-loader/Config.in                | 33 ++++++++
>>   boot/ti-k3-r5-loader/ti-k3-r5-loader.hash     |  1 -
>>   boot/ti-k3-r5-loader/ti-k3-r5-loader.mk       | 40 +++++++++-
>>   boot/uboot/Config.in                          | 35 +++++----
>>   boot/uboot/uboot.mk                           | 12 ++-
>>   configs/ti_am62x_sk_defconfig                 | 21 ++---
>>   configs/ti_am64x_sk_defconfig                 | 20 +++--
>>   24 files changed, 221 insertions(+), 178 deletions(-)
>>   create mode 100644 
>> board/ti/am62x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash
>>   create mode 120000 board/ti/am62x-sk/patches/linux-headers/linux-headers.hash
>>   create mode 100644 board/ti/am62x-sk/patches/linux/linux.hash
>>   create mode 100644 
>> board/ti/am62x-sk/patches/ti-k3-r5-loader/ti-k3-r5-loader.hash
>>   create mode 100644 
>> board/ti/am64x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash
>>   create mode 120000 board/ti/am64x-sk/patches/linux-headers/linux-headers.hash
>>   create mode 100644 board/ti/am64x-sk/patches/linux/linux.hash
>>   create mode 100644 
>> board/ti/am64x-sk/patches/ti-k3-r5-loader/ti-k3-r5-loader.hash
>>   create mode 100755 board/ti/common/am6xx/post-build.sh
>>   delete mode 100644 boot/ti-k3-image-gen/Config.in
>>   delete mode 100644 boot/ti-k3-image-gen/ti-k3-image-gen.hash
>>   delete mode 100644 boot/ti-k3-image-gen/ti-k3-image-gen.mk
>>
>> -- 
>> 2.44.0
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot@buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot
Romain Naour April 9, 2024, 9:17 p.m. UTC | #3
Hello Arnout, All,

Le 08/04/2024 à 15:47, Arnout Vandecappelle a écrit :
> 
> On 07/04/2024 22:30, Arnout Vandecappelle wrote:
>>
>>
>> On 07/04/2024 12:34, Romain Naour wrote:
>>> This series aims initially to fix AM62x-SK HS-FS devices but doing so
>>> would requires adding a TI legacy tool "ti-k3-core-secdev" into Buildroot.
>>> ti-k3-core-secdev is replaced by u-boot's binman tool since v2023.10 release
>>> of u-boot.
>>>
>>> Instead, we bump the BSP to use the latest u-boot release (2024.01) to use
>>> binman. Doing so requires to rework the TI K3 SoC support in Buildroot.
>>>
>>> This new version (v12) of this series remove the ti-k3 package and
>>> all SOC and SECTYPE options. As suggested by Michael Walle, copy the
>>> default tiboot3.bin and sysfw.itb (if any) if no custom file name is
>>> provided on the defconfig. Since such file name can be customized,
>>> the user must provide the complete firmware name if not using the
>>> default one.
>>>
>>> http://lists.busybox.net/pipermail/buildroot/2024-April/688943.html
>>>
>>> With the advice of Andreas Dannenberg (TI K3 architect), we switch
>>> AM62x/AM62Ax/AM64x to HS-FS by default.
>>>
>>> Tests performed on earlier revision of this series:
>>>
>>> * compiled ti_am62x_sk_defconfig
>>>    * success
>>> * booted on AM62x SK EVM (E3)
>>>    * success
>>>    * no obvious errors in dmesg
>>>
>>> Tested-by: Gero Schwäricke <gero.schwaericke@grandcentrix.net>
>>>
>>> Dario Binacchi (10):
>>>    boot/ti-k3-r5-loader: drop hash for version 2022.10
>>>    boot/ti-k3-r5-loader: add BR2_TARGET_TI_K3_R5_LOADER_USE_BINMAN option
>>>    boot/uboot: add BR2_TARGET_UBOOT_USE_BINMAN option
>>>    boot/ti-k3-r5-loader: install tiboot3.bin and sysfw.itb to
>>>      BINARIES_DIR
>>>    configs/ti_am62x_sk_defconfig: bump U-Boot version to 2024.01
>>>    configs/ti_am62x_sk_defconfig: bump Linux version to 6.6.18
>>>    board/ti/am62x-sk: generalize post-build.sh
>>>    board/ti/am62x-sk: move post-build.sh to board/ti/common/am6xx
>>>    configs/ti_am64x_sk_defconfig: bump U-Boot version to 2024.01
>>>    configs/ti_am64x_sk_defconfig: bump Linux version to 6.6.18
>>>
>>> Romain Naour (6):
>>>    board/ti/am6{2,4}x-sk: add arm-trusted-firmware v2.7 hash
>>>    boot/uboot: rename TI_K3_DM option to cover further TI K3 SoCs support
>>>    boot/uboot: remove BR2_TARGET_UBOOT_TI_K3_DM_SOCNAME
>>>    boot/ti-k3-image-gen: remove package
>>>    boot/ti-k3-r5-loader: remove BR2_TARGET_TI_K3_R5_LOADER_USE_BINMAN
>>>    package/ti-k3: switch AM62x/AM62Ax/AM64x to HS-FS by default
>>
>>  Patches 1-5 applied to master. And there I stopped, due to the SWSFW typo. I
>> could have fixed it up myself but it's really every patch that needs to be
>> updated...
> 
> 
>  I also reviewed the rest of the series with minor comments, so you can apply
> them directly (with my Reviewed-by: Arnout Vandecappelle <arnout@mind.be>)

Thanks, the series is merged.

Thanks to Dario and Michael for the initial work on the HS-FS topic!

The initial series showed that it was necessary to rework heavily the TI K3 SoC
related packages in Buildroot. This was the opportinity to anticipate on the
addition of new TI K3 SoC support.

Thanks to Andreas and Bryan from TI for the review and fine details about TI K3
SoC familly and the runtime testing.

Thanks to all testers and reviewers.

Best regards,
Romain

> 
> 
>  Regards,
>  Arnout
> 
> 
>>
>>
>>  Regards,
>>  Arnout
>>
>>>
>>>   Config.in.legacy                              | 15 ++++
>>>   DEVELOPERS                                    |  2 -
>>>   board/ti/am62x-sk/genimage.cfg                |  7 +-
>>>   .../arm-trusted-firmware.hash                 |  2 +
>>>   .../patches/linux-headers/linux-headers.hash  |  1 +
>>>   board/ti/am62x-sk/patches/linux/linux.hash    |  2 +
>>>   .../ti-k3-r5-loader/ti-k3-r5-loader.hash      |  2 +
>>>   board/ti/am64x-sk/genimage.cfg                |  7 +-
>>>   .../arm-trusted-firmware.hash                 |  2 +
>>>   .../patches/linux-headers/linux-headers.hash  |  1 +
>>>   board/ti/am64x-sk/patches/linux/linux.hash    |  2 +
>>>   .../ti-k3-r5-loader/ti-k3-r5-loader.hash      |  1 +
>>>   board/ti/common/am6xx/post-build.sh           | 58 ++++++++++++++
>>>   boot/Config.in                                |  1 -
>>>   boot/ti-k3-image-gen/Config.in                | 77 -------------------
>>>   boot/ti-k3-image-gen/ti-k3-image-gen.hash     |  3 -
>>>   boot/ti-k3-image-gen/ti-k3-image-gen.mk       | 54 -------------
>>>   boot/ti-k3-r5-loader/Config.in                | 33 ++++++++
>>>   boot/ti-k3-r5-loader/ti-k3-r5-loader.hash     |  1 -
>>>   boot/ti-k3-r5-loader/ti-k3-r5-loader.mk       | 40 +++++++++-
>>>   boot/uboot/Config.in                          | 35 +++++----
>>>   boot/uboot/uboot.mk                           | 12 ++-
>>>   configs/ti_am62x_sk_defconfig                 | 21 ++---
>>>   configs/ti_am64x_sk_defconfig                 | 20 +++--
>>>   24 files changed, 221 insertions(+), 178 deletions(-)
>>>   create mode 100644
>>> board/ti/am62x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash
>>>   create mode 120000 board/ti/am62x-sk/patches/linux-headers/linux-headers.hash
>>>   create mode 100644 board/ti/am62x-sk/patches/linux/linux.hash
>>>   create mode 100644
>>> board/ti/am62x-sk/patches/ti-k3-r5-loader/ti-k3-r5-loader.hash
>>>   create mode 100644
>>> board/ti/am64x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash
>>>   create mode 120000 board/ti/am64x-sk/patches/linux-headers/linux-headers.hash
>>>   create mode 100644 board/ti/am64x-sk/patches/linux/linux.hash
>>>   create mode 100644
>>> board/ti/am64x-sk/patches/ti-k3-r5-loader/ti-k3-r5-loader.hash
>>>   create mode 100755 board/ti/common/am6xx/post-build.sh
>>>   delete mode 100644 boot/ti-k3-image-gen/Config.in
>>>   delete mode 100644 boot/ti-k3-image-gen/ti-k3-image-gen.hash
>>>   delete mode 100644 boot/ti-k3-image-gen/ti-k3-image-gen.mk
>>>
>>> -- 
>>> 2.44.0
>>>
>>> _______________________________________________
>>> buildroot mailing list
>>> buildroot@buildroot.org
>>> https://lists.buildroot.org/mailman/listinfo/buildroot
Dario Binacchi April 10, 2024, 7:34 a.m. UTC | #4
Hi Romain, All

On Tue, Apr 9, 2024 at 11:17 PM Romain Naour <romain.naour@smile.fr> wrote:
>
> Hello Arnout, All,
>
> Le 08/04/2024 à 15:47, Arnout Vandecappelle a écrit :
> >
> > On 07/04/2024 22:30, Arnout Vandecappelle wrote:
> >>
> >>
> >> On 07/04/2024 12:34, Romain Naour wrote:
> >>> This series aims initially to fix AM62x-SK HS-FS devices but doing so
> >>> would requires adding a TI legacy tool "ti-k3-core-secdev" into Buildroot.
> >>> ti-k3-core-secdev is replaced by u-boot's binman tool since v2023.10 release
> >>> of u-boot.
> >>>
> >>> Instead, we bump the BSP to use the latest u-boot release (2024.01) to use
> >>> binman. Doing so requires to rework the TI K3 SoC support in Buildroot.
> >>>
> >>> This new version (v12) of this series remove the ti-k3 package and
> >>> all SOC and SECTYPE options. As suggested by Michael Walle, copy the
> >>> default tiboot3.bin and sysfw.itb (if any) if no custom file name is
> >>> provided on the defconfig. Since such file name can be customized,
> >>> the user must provide the complete firmware name if not using the
> >>> default one.
> >>>
> >>> http://lists.busybox.net/pipermail/buildroot/2024-April/688943.html
> >>>
> >>> With the advice of Andreas Dannenberg (TI K3 architect), we switch
> >>> AM62x/AM62Ax/AM64x to HS-FS by default.
> >>>
> >>> Tests performed on earlier revision of this series:
> >>>
> >>> * compiled ti_am62x_sk_defconfig
> >>>    * success
> >>> * booted on AM62x SK EVM (E3)
> >>>    * success
> >>>    * no obvious errors in dmesg
> >>>
> >>> Tested-by: Gero Schwäricke <gero.schwaericke@grandcentrix.net>
> >>>
> >>> Dario Binacchi (10):
> >>>    boot/ti-k3-r5-loader: drop hash for version 2022.10
> >>>    boot/ti-k3-r5-loader: add BR2_TARGET_TI_K3_R5_LOADER_USE_BINMAN option
> >>>    boot/uboot: add BR2_TARGET_UBOOT_USE_BINMAN option
> >>>    boot/ti-k3-r5-loader: install tiboot3.bin and sysfw.itb to
> >>>      BINARIES_DIR
> >>>    configs/ti_am62x_sk_defconfig: bump U-Boot version to 2024.01
> >>>    configs/ti_am62x_sk_defconfig: bump Linux version to 6.6.18
> >>>    board/ti/am62x-sk: generalize post-build.sh
> >>>    board/ti/am62x-sk: move post-build.sh to board/ti/common/am6xx
> >>>    configs/ti_am64x_sk_defconfig: bump U-Boot version to 2024.01
> >>>    configs/ti_am64x_sk_defconfig: bump Linux version to 6.6.18
> >>>
> >>> Romain Naour (6):
> >>>    board/ti/am6{2,4}x-sk: add arm-trusted-firmware v2.7 hash
> >>>    boot/uboot: rename TI_K3_DM option to cover further TI K3 SoCs support
> >>>    boot/uboot: remove BR2_TARGET_UBOOT_TI_K3_DM_SOCNAME
> >>>    boot/ti-k3-image-gen: remove package
> >>>    boot/ti-k3-r5-loader: remove BR2_TARGET_TI_K3_R5_LOADER_USE_BINMAN
> >>>    package/ti-k3: switch AM62x/AM62Ax/AM64x to HS-FS by default
> >>
> >>  Patches 1-5 applied to master. And there I stopped, due to the SWSFW typo. I
> >> could have fixed it up myself but it's really every patch that needs to be
> >> updated...
> >
> >
> >  I also reviewed the rest of the series with minor comments, so you can apply
> > them directly (with my Reviewed-by: Arnout Vandecappelle <arnout@mind.be>)
>
> Thanks, the series is merged.
>
> Thanks to Dario and Michael for the initial work on the HS-FS topic!
>
> The initial series showed that it was necessary to rework heavily the TI K3 SoC
> related packages in Buildroot. This was the opportinity to anticipate on the
> addition of new TI K3 SoC support.
>
> Thanks to Andreas and Bryan from TI for the review and fine details about TI K3
> SoC familly and the runtime testing.
>
> Thanks to all testers and reviewers.

I think my two patches for version 10 were ultimately lost:

[v10,05/12] package/ti-k3: disable HS-FS for AM65 SOC
[v10,04/12] package/ti-k3: move TI_K3_{SECTYPE, SOC} out of the image-gen scope

Specifically, patch 4 is necessary for the proper creation of the
image. Has version 12 actually been tested by anyone?
I can assure you version 10 has been.

Additionally, it seems that patch
[v10,02/12] boot/ti-k3-r5-loader: set binman environment
has been incorporated into your patch "boot/ti-k3-r5-loader: remove
BR2_TARGET_TI_K3_R5_LOADER_USE_BINMAN"
and I don't understand why.

Thanks and regards,
Dario

>
> Best regards,
> Romain
>
> >
> >
> >  Regards,
> >  Arnout
> >
> >
> >>
> >>
> >>  Regards,
> >>  Arnout
> >>
> >>>
> >>>   Config.in.legacy                              | 15 ++++
> >>>   DEVELOPERS                                    |  2 -
> >>>   board/ti/am62x-sk/genimage.cfg                |  7 +-
> >>>   .../arm-trusted-firmware.hash                 |  2 +
> >>>   .../patches/linux-headers/linux-headers.hash  |  1 +
> >>>   board/ti/am62x-sk/patches/linux/linux.hash    |  2 +
> >>>   .../ti-k3-r5-loader/ti-k3-r5-loader.hash      |  2 +
> >>>   board/ti/am64x-sk/genimage.cfg                |  7 +-
> >>>   .../arm-trusted-firmware.hash                 |  2 +
> >>>   .../patches/linux-headers/linux-headers.hash  |  1 +
> >>>   board/ti/am64x-sk/patches/linux/linux.hash    |  2 +
> >>>   .../ti-k3-r5-loader/ti-k3-r5-loader.hash      |  1 +
> >>>   board/ti/common/am6xx/post-build.sh           | 58 ++++++++++++++
> >>>   boot/Config.in                                |  1 -
> >>>   boot/ti-k3-image-gen/Config.in                | 77 -------------------
> >>>   boot/ti-k3-image-gen/ti-k3-image-gen.hash     |  3 -
> >>>   boot/ti-k3-image-gen/ti-k3-image-gen.mk       | 54 -------------
> >>>   boot/ti-k3-r5-loader/Config.in                | 33 ++++++++
> >>>   boot/ti-k3-r5-loader/ti-k3-r5-loader.hash     |  1 -
> >>>   boot/ti-k3-r5-loader/ti-k3-r5-loader.mk       | 40 +++++++++-
> >>>   boot/uboot/Config.in                          | 35 +++++----
> >>>   boot/uboot/uboot.mk                           | 12 ++-
> >>>   configs/ti_am62x_sk_defconfig                 | 21 ++---
> >>>   configs/ti_am64x_sk_defconfig                 | 20 +++--
> >>>   24 files changed, 221 insertions(+), 178 deletions(-)
> >>>   create mode 100644
> >>> board/ti/am62x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash
> >>>   create mode 120000 board/ti/am62x-sk/patches/linux-headers/linux-headers.hash
> >>>   create mode 100644 board/ti/am62x-sk/patches/linux/linux.hash
> >>>   create mode 100644
> >>> board/ti/am62x-sk/patches/ti-k3-r5-loader/ti-k3-r5-loader.hash
> >>>   create mode 100644
> >>> board/ti/am64x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash
> >>>   create mode 120000 board/ti/am64x-sk/patches/linux-headers/linux-headers.hash
> >>>   create mode 100644 board/ti/am64x-sk/patches/linux/linux.hash
> >>>   create mode 100644
> >>> board/ti/am64x-sk/patches/ti-k3-r5-loader/ti-k3-r5-loader.hash
> >>>   create mode 100755 board/ti/common/am6xx/post-build.sh
> >>>   delete mode 100644 boot/ti-k3-image-gen/Config.in
> >>>   delete mode 100644 boot/ti-k3-image-gen/ti-k3-image-gen.hash
> >>>   delete mode 100644 boot/ti-k3-image-gen/ti-k3-image-gen.mk
> >>>
> >>> --
> >>> 2.44.0
> >>>
> >>> _______________________________________________
> >>> buildroot mailing list
> >>> buildroot@buildroot.org
> >>> https://lists.buildroot.org/mailman/listinfo/buildroot
>
Gero Schwäricke April 10, 2024, 8 a.m. UTC | #5
On Wed, Apr 10, 2024 at 09:34:16AM +0200, Dario Binacchi wrote:
> Hi Romain, All
> 
> On Tue, Apr 9, 2024 at 11:17 PM Romain Naour <romain.naour@smile.fr> wrote:
> >
> > Hello Arnout, All,
[...]
> >
> > Thanks, the series is merged.
> >
> > Thanks to Dario and Michael for the initial work on the HS-FS topic!
> >
> > The initial series showed that it was necessary to rework heavily the TI K3 SoC
> > related packages in Buildroot. This was the opportinity to anticipate on the
> > addition of new TI K3 SoC support.
> >
> > Thanks to Andreas and Bryan from TI for the review and fine details about TI K3
> > SoC familly and the runtime testing.
> >
> > Thanks to all testers and reviewers.
> 
> I think my two patches for version 10 were ultimately lost:
> 
> [v10,05/12] package/ti-k3: disable HS-FS for AM65 SOC
> [v10,04/12] package/ti-k3: move TI_K3_{SECTYPE, SOC} out of the image-gen scope
> 
> Specifically, patch 4 is necessary for the proper creation of the
> image. Has version 12 actually been tested by anyone?
> I can assure you version 10 has been.
> 
> Additionally, it seems that patch
> [v10,02/12] boot/ti-k3-r5-loader: set binman environment
> has been incorporated into your patch "boot/ti-k3-r5-loader: remove
> BR2_TARGET_TI_K3_R5_LOADER_USE_BINMAN"
> and I don't understand why.
> 
> Thanks and regards,
> Dario

Hi Dario,

I can confirm that something is amiss, maybe it would have been better
to await more tests with patch V12. At least my current test of
ti_am62x_sk_defconfig on master failed to boot:

  U-Boot SPL 2024.01 (Apr 10 2024 - 09:32:17 +0200)
  k3_system_controller sysctrler: k3_sysctrler_start: Boot Notification response failed. ret = -110
  Firmware init failed on rproc (-110)

  resetting ...

I tested with AM62x SK EVM E3. I'll try to apply your two missing
patches and test again.

Best,
Gero

> > Best regards,
> > Romain
> >
[...]
Andreas Dannenberg April 10, 2024, 8:24 a.m. UTC | #6
Gero, Dario,

On Wed, Apr 10, 2024 at 10:00:06AM +0200, Gero Schwäricke via buildroot wrote:
> On Wed, Apr 10, 2024 at 09:34:16AM +0200, Dario Binacchi wrote:
> > Hi Romain, All
> > 
> > On Tue, Apr 9, 2024 at 11:17 PM Romain Naour <romain.naour@smile.fr> wrote:
> > >
> > > Hello Arnout, All,
> [...]
> > >
> > > Thanks, the series is merged.
> > >
> > > Thanks to Dario and Michael for the initial work on the HS-FS topic!
> > >
> > > The initial series showed that it was necessary to rework heavily the TI K3 SoC
> > > related packages in Buildroot. This was the opportinity to anticipate on the
> > > addition of new TI K3 SoC support.
> > >
> > > Thanks to Andreas and Bryan from TI for the review and fine details about TI K3
> > > SoC familly and the runtime testing.
> > >
> > > Thanks to all testers and reviewers.
> > 
> > I think my two patches for version 10 were ultimately lost:
> > 
> > [v10,05/12] package/ti-k3: disable HS-FS for AM65 SOC
> > [v10,04/12] package/ti-k3: move TI_K3_{SECTYPE, SOC} out of the image-gen scope
> > 
> > Specifically, patch 4 is necessary for the proper creation of the
> > image. Has version 12 actually been tested by anyone?
> > I can assure you version 10 has been.
> > 
> > Additionally, it seems that patch
> > [v10,02/12] boot/ti-k3-r5-loader: set binman environment
> > has been incorporated into your patch "boot/ti-k3-r5-loader: remove
> > BR2_TARGET_TI_K3_R5_LOADER_USE_BINMAN"
> > and I don't understand why.
> > 
> > Thanks and regards,
> > Dario
> 
> Hi Dario,
> 
> I can confirm that something is amiss, maybe it would have been better
> to await more tests with patch V12.

I just tested top-of-master w/o any additional patches on SK-AM62 (with
GP silicon) and SK-AM62B (production board, with HS-FS silicon) and it
worked like a champ. Here's the beginning of the boot using SK-AM62...

<...snip...>
U-Boot SPL 2024.01 (Apr 09 2024 - 20:11:30 -0500)
SYSFW ABI: 3.1 (firmware rev 0x0008 '8.6.4--v08.06.04 (Chill Capybar')
SPL initial stack usage: 13368 bytes
Trying to boot from MMC2
Authentication passed
Authentication passed
Authentication passed
Authentication passed
Authentication passed
Starting ATF on ARM64 core...

NOTICE:  BL31: v2.7(release):v2.7
NOTICE:  BL31: Built : 20:08:16, Apr  9 2024
I/TC:
I/TC: OP-TEE version: Unknown_4.0 (gcc version 12.3.0 (Buildroot
2024.02-416-gd01e13c4d4)) #1 Wed Apr 10 01:08:14 UTC 2024 aarch64
I/TC: WARNING: This OP-TEE configuration might be insecure!
I/TC: WARNING: Please check
https://optee.readthedocs.io/en/latest/architecture/porting_guidelines.html
I/TC: Primary CPU initializing
I/TC: SYSFW ABI: 3.1 (firmware rev 0x0008 '8.6.4--v08.06.04 (Chill
Capybar')
I/TC: HUK Initialized
I/TC: Activated SA2UL device
I/TC: Enabled firewalls for SA2UL TRNG device
I/TC: SA2UL TRNG initialized
I/TC: SA2UL Drivers initialized
I/TC: Primary CPU switching to normal world boot

U-Boot SPL 2024.01 (Apr 09 2024 - 20:11:48 -0500)
SYSFW ABI: 3.1 (firmware rev 0x0008 '8.6.4--v08.06.04 (Chill Capybar')
SPL initial stack usage: 1872 bytes
Trying to boot from MMC2
Authentication passed
Authentication passed


U-Boot 2024.01 (Apr 09 2024 - 20:11:48 -0500)

SoC:   AM62X SR1.0 HS-FS
Model: Texas Instruments AM625 SK
DRAM:  2 GiB
Core:  56 devices, 23 uclasses, devicetree: separate
MMC:   mmc@fa10000: 0, mmc@fa00000: 1
Loading Environment from nowhere... OK
In:    serial@2800000
Out:   serial@2800000
Err:   serial@2800000
Net:   eth0: ethernet@8000000port@1
Hit any key to stop autoboot:  0
<...snip...>


> At least my current test of ti_am62x_sk_defconfig on master failed to boot:
> 
>   U-Boot SPL 2024.01 (Apr 10 2024 - 09:32:17 +0200)
>   k3_system_controller sysctrler: k3_sysctrler_start: Boot Notification response failed. ret = -110
>   Firmware init failed on rproc (-110)
> 
>   resetting ...
> 
> I tested with AM62x SK EVM E3. I'll try to apply your two missing
> patches and test again.

Are you using a board with PCB revision 'PROC114E3'? If so this board is
known as 'Third prototype, early release revision of the AM62x SK EVM'
and should have GP silicon. Which means you must have re-added...

BR2_TARGET_TI_K3_R5_LOADER_TIBOOT3_BIN="tiboot3-am62x-gp-evm.bin

...to your .config?

I don't have a PROC114E3 board but the board I used to test the GP
variant today is a PROC114E2, and it worked. But neither of those boards
is considered "production".

Also just for refernce, an SK-AM62 PCB revision history can be found in
Table 1-1 in the AM62x SK EVM User's Guide [1].


--
Andreas Dannenberg
Texas Instruments Inc


[1] https://www.ti.com/lit/pdf/spruj40 




> Best,
> Gero
> 
> > > Best regards,
> > > Romain
> > >
> [...]
> 
> -- 
> 
> 
> 
> –––
> 
> 
> grandcentrix GmbH | A Vodafone Company · Holzmarkt 1 · 50676 
> *Cologne* | Phoenixseestrasse 18 · 44263 *Dortmund* · Germany
> | in 
> <https://www.linkedin.com/company/grandcentrix> | phone: +49-221-677-860-0 
> | email: hello@grandcentrix.net <mailto:hello@grandcentrix.net>
> 
> 
> grandcentrix cares about privacy 
> <https://grandcentrix.net/de/pages/privacymail/>
> 
> Amtsgericht Köln | HRB  
> 70119 | Geschäftsführer: M. Krömer,  R. Hänel | USt.-IdNr.: DE266333969
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
Andreas Dannenberg April 10, 2024, 9:23 a.m. UTC | #7
Gero, Dario, All,

On Wed, Apr 10, 2024 at 03:24:29AM -0500, Andreas Dannenberg via buildroot wrote:
> Gero, Dario,
> 
> On Wed, Apr 10, 2024 at 10:00:06AM +0200, Gero Schwäricke via buildroot wrote:
> > On Wed, Apr 10, 2024 at 09:34:16AM +0200, Dario Binacchi wrote:
> > > Hi Romain, All
> > > 
> > > On Tue, Apr 9, 2024 at 11:17 PM Romain Naour <romain.naour@smile.fr> wrote:
> > > >
> > > > Hello Arnout, All,
> > [...]
> > > >
> > > > Thanks, the series is merged.
> > > >
> > > > Thanks to Dario and Michael for the initial work on the HS-FS topic!
> > > >
> > > > The initial series showed that it was necessary to rework heavily the TI K3 SoC
> > > > related packages in Buildroot. This was the opportinity to anticipate on the
> > > > addition of new TI K3 SoC support.
> > > >
> > > > Thanks to Andreas and Bryan from TI for the review and fine details about TI K3
> > > > SoC familly and the runtime testing.
> > > >
> > > > Thanks to all testers and reviewers.
> > > 
> > > I think my two patches for version 10 were ultimately lost:
> > > 
> > > [v10,05/12] package/ti-k3: disable HS-FS for AM65 SOC
> > > [v10,04/12] package/ti-k3: move TI_K3_{SECTYPE, SOC} out of the image-gen scope
> > > 
> > > Specifically, patch 4 is necessary for the proper creation of the
> > > image. Has version 12 actually been tested by anyone?
> > > I can assure you version 10 has been.
> > > 
> > > Additionally, it seems that patch
> > > [v10,02/12] boot/ti-k3-r5-loader: set binman environment
> > > has been incorporated into your patch "boot/ti-k3-r5-loader: remove
> > > BR2_TARGET_TI_K3_R5_LOADER_USE_BINMAN"
> > > and I don't understand why.
> > > 
> > > Thanks and regards,
> > > Dario
> > 
> > Hi Dario,
> > 
> > I can confirm that something is amiss, maybe it would have been better
> > to await more tests with patch V12.
> 
> I just tested top-of-master w/o any additional patches on SK-AM62 (with
> GP silicon) and SK-AM62B (production board, with HS-FS silicon) and it
> worked like a champ. Here's the beginning of the boot using SK-AM62...

I also just tested top-of-master with SK-AM64 (with GP silicon) and
SK-AM64B (production board, with HS-FS silicon) successfully. With this
I can boot on all 4 board/silicon variants without any issues. This was
done using commit...

d01e13c4d4 ("package/python3: fix cross builds when host and target use the same SOABI")

So from my POV there is no issue with missing patches.

--
Andreas Dannenberg
Texas Instruments Inc


> 
> <...snip...>
> U-Boot SPL 2024.01 (Apr 09 2024 - 20:11:30 -0500)
> SYSFW ABI: 3.1 (firmware rev 0x0008 '8.6.4--v08.06.04 (Chill Capybar')
> SPL initial stack usage: 13368 bytes
> Trying to boot from MMC2
> Authentication passed
> Authentication passed
> Authentication passed
> Authentication passed
> Authentication passed
> Starting ATF on ARM64 core...
> 
> NOTICE:  BL31: v2.7(release):v2.7
> NOTICE:  BL31: Built : 20:08:16, Apr  9 2024
> I/TC:
> I/TC: OP-TEE version: Unknown_4.0 (gcc version 12.3.0 (Buildroot
> 2024.02-416-gd01e13c4d4)) #1 Wed Apr 10 01:08:14 UTC 2024 aarch64
> I/TC: WARNING: This OP-TEE configuration might be insecure!
> I/TC: WARNING: Please check
> https://optee.readthedocs.io/en/latest/architecture/porting_guidelines.html
> I/TC: Primary CPU initializing
> I/TC: SYSFW ABI: 3.1 (firmware rev 0x0008 '8.6.4--v08.06.04 (Chill
> Capybar')
> I/TC: HUK Initialized
> I/TC: Activated SA2UL device
> I/TC: Enabled firewalls for SA2UL TRNG device
> I/TC: SA2UL TRNG initialized
> I/TC: SA2UL Drivers initialized
> I/TC: Primary CPU switching to normal world boot
> 
> U-Boot SPL 2024.01 (Apr 09 2024 - 20:11:48 -0500)
> SYSFW ABI: 3.1 (firmware rev 0x0008 '8.6.4--v08.06.04 (Chill Capybar')
> SPL initial stack usage: 1872 bytes
> Trying to boot from MMC2
> Authentication passed
> Authentication passed
> 
> 
> U-Boot 2024.01 (Apr 09 2024 - 20:11:48 -0500)
> 
> SoC:   AM62X SR1.0 HS-FS
> Model: Texas Instruments AM625 SK
> DRAM:  2 GiB
> Core:  56 devices, 23 uclasses, devicetree: separate
> MMC:   mmc@fa10000: 0, mmc@fa00000: 1
> Loading Environment from nowhere... OK
> In:    serial@2800000
> Out:   serial@2800000
> Err:   serial@2800000
> Net:   eth0: ethernet@8000000port@1
> Hit any key to stop autoboot:  0
> <...snip...>
> 
> 
> > At least my current test of ti_am62x_sk_defconfig on master failed to boot:
> > 
> >   U-Boot SPL 2024.01 (Apr 10 2024 - 09:32:17 +0200)
> >   k3_system_controller sysctrler: k3_sysctrler_start: Boot Notification response failed. ret = -110
> >   Firmware init failed on rproc (-110)
> > 
> >   resetting ...
> > 
> > I tested with AM62x SK EVM E3. I'll try to apply your two missing
> > patches and test again.
> 
> Are you using a board with PCB revision 'PROC114E3'? If so this board is
> known as 'Third prototype, early release revision of the AM62x SK EVM'
> and should have GP silicon. Which means you must have re-added...
> 
> BR2_TARGET_TI_K3_R5_LOADER_TIBOOT3_BIN="tiboot3-am62x-gp-evm.bin
> 
> ...to your .config?
> 
> I don't have a PROC114E3 board but the board I used to test the GP
> variant today is a PROC114E2, and it worked. But neither of those boards
> is considered "production".
> 
> Also just for refernce, an SK-AM62 PCB revision history can be found in
> Table 1-1 in the AM62x SK EVM User's Guide [1].
> 
> 
> --
> Andreas Dannenberg
> Texas Instruments Inc
> 
> 
> [1] https://www.ti.com/lit/pdf/spruj40 
> 
> 
> 
> 
> > Best,
> > Gero
> > 
> > > > Best regards,
> > > > Romain
> > > >
> > [...]
> > 
> > -- 
> > 
> > 
> > 
> > –––
> > 
> > 
> > grandcentrix GmbH | A Vodafone Company · Holzmarkt 1 · 50676 
> > *Cologne* | Phoenixseestrasse 18 · 44263 *Dortmund* · Germany
> > | in 
> > <https://www.linkedin.com/company/grandcentrix> | phone: +49-221-677-860-0 
> > | email: hello@grandcentrix.net <mailto:hello@grandcentrix.net>
> > 
> > 
> > grandcentrix cares about privacy 
> > <https://grandcentrix.net/de/pages/privacymail/>
> > 
> > Amtsgericht Köln | HRB  
> > 70119 | Geschäftsführer: M. Krömer,  R. Hänel | USt.-IdNr.: DE266333969
> > 
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
Dario Binacchi April 10, 2024, 9:36 a.m. UTC | #8
Hi Andreas,

On Wed, Apr 10, 2024 at 11:23 AM Andreas Dannenberg <dannenberg@ti.com> wrote:
>
> Gero, Dario, All,
>
> On Wed, Apr 10, 2024 at 03:24:29AM -0500, Andreas Dannenberg via buildroot wrote:
> > Gero, Dario,
> >
> > On Wed, Apr 10, 2024 at 10:00:06AM +0200, Gero Schwäricke via buildroot wrote:
> > > On Wed, Apr 10, 2024 at 09:34:16AM +0200, Dario Binacchi wrote:
> > > > Hi Romain, All
> > > >
> > > > On Tue, Apr 9, 2024 at 11:17 PM Romain Naour <romain.naour@smile.fr> wrote:
> > > > >
> > > > > Hello Arnout, All,
> > > [...]
> > > > >
> > > > > Thanks, the series is merged.
> > > > >
> > > > > Thanks to Dario and Michael for the initial work on the HS-FS topic!
> > > > >
> > > > > The initial series showed that it was necessary to rework heavily the TI K3 SoC
> > > > > related packages in Buildroot. This was the opportinity to anticipate on the
> > > > > addition of new TI K3 SoC support.
> > > > >
> > > > > Thanks to Andreas and Bryan from TI for the review and fine details about TI K3
> > > > > SoC familly and the runtime testing.
> > > > >
> > > > > Thanks to all testers and reviewers.
> > > >
> > > > I think my two patches for version 10 were ultimately lost:
> > > >
> > > > [v10,05/12] package/ti-k3: disable HS-FS for AM65 SOC
> > > > [v10,04/12] package/ti-k3: move TI_K3_{SECTYPE, SOC} out of the image-gen scope
> > > >
> > > > Specifically, patch 4 is necessary for the proper creation of the
> > > > image. Has version 12 actually been tested by anyone?
> > > > I can assure you version 10 has been.
> > > >
> > > > Additionally, it seems that patch
> > > > [v10,02/12] boot/ti-k3-r5-loader: set binman environment
> > > > has been incorporated into your patch "boot/ti-k3-r5-loader: remove
> > > > BR2_TARGET_TI_K3_R5_LOADER_USE_BINMAN"
> > > > and I don't understand why.
> > > >
> > > > Thanks and regards,
> > > > Dario
> > >
> > > Hi Dario,
> > >
> > > I can confirm that something is amiss, maybe it would have been better
> > > to await more tests with patch V12.
> >
> > I just tested top-of-master w/o any additional patches on SK-AM62 (with
> > GP silicon) and SK-AM62B (production board, with HS-FS silicon) and it
> > worked like a champ. Here's the beginning of the boot using SK-AM62...
>
> I also just tested top-of-master with SK-AM64 (with GP silicon) and
> SK-AM64B (production board, with HS-FS silicon) successfully. With this
> I can boot on all 4 board/silicon variants without any issues. This was
> done using commit...
>
> d01e13c4d4 ("package/python3: fix cross builds when host and target use the same SOABI")
>
> So from my POV there is no issue with missing patches.

I must have missed something.
Thanks again for your tests.

Regards
Dario
>
> --
> Andreas Dannenberg
> Texas Instruments Inc
>
>
> >
> > <...snip...>
> > U-Boot SPL 2024.01 (Apr 09 2024 - 20:11:30 -0500)
> > SYSFW ABI: 3.1 (firmware rev 0x0008 '8.6.4--v08.06.04 (Chill Capybar')
> > SPL initial stack usage: 13368 bytes
> > Trying to boot from MMC2
> > Authentication passed
> > Authentication passed
> > Authentication passed
> > Authentication passed
> > Authentication passed
> > Starting ATF on ARM64 core...
> >
> > NOTICE:  BL31: v2.7(release):v2.7
> > NOTICE:  BL31: Built : 20:08:16, Apr  9 2024
> > I/TC:
> > I/TC: OP-TEE version: Unknown_4.0 (gcc version 12.3.0 (Buildroot
> > 2024.02-416-gd01e13c4d4)) #1 Wed Apr 10 01:08:14 UTC 2024 aarch64
> > I/TC: WARNING: This OP-TEE configuration might be insecure!
> > I/TC: WARNING: Please check
> > https://optee.readthedocs.io/en/latest/architecture/porting_guidelines.html
> > I/TC: Primary CPU initializing
> > I/TC: SYSFW ABI: 3.1 (firmware rev 0x0008 '8.6.4--v08.06.04 (Chill
> > Capybar')
> > I/TC: HUK Initialized
> > I/TC: Activated SA2UL device
> > I/TC: Enabled firewalls for SA2UL TRNG device
> > I/TC: SA2UL TRNG initialized
> > I/TC: SA2UL Drivers initialized
> > I/TC: Primary CPU switching to normal world boot
> >
> > U-Boot SPL 2024.01 (Apr 09 2024 - 20:11:48 -0500)
> > SYSFW ABI: 3.1 (firmware rev 0x0008 '8.6.4--v08.06.04 (Chill Capybar')
> > SPL initial stack usage: 1872 bytes
> > Trying to boot from MMC2
> > Authentication passed
> > Authentication passed
> >
> >
> > U-Boot 2024.01 (Apr 09 2024 - 20:11:48 -0500)
> >
> > SoC:   AM62X SR1.0 HS-FS
> > Model: Texas Instruments AM625 SK
> > DRAM:  2 GiB
> > Core:  56 devices, 23 uclasses, devicetree: separate
> > MMC:   mmc@fa10000: 0, mmc@fa00000: 1
> > Loading Environment from nowhere... OK
> > In:    serial@2800000
> > Out:   serial@2800000
> > Err:   serial@2800000
> > Net:   eth0: ethernet@8000000port@1
> > Hit any key to stop autoboot:  0
> > <...snip...>
> >
> >
> > > At least my current test of ti_am62x_sk_defconfig on master failed to boot:
> > >
> > >   U-Boot SPL 2024.01 (Apr 10 2024 - 09:32:17 +0200)
> > >   k3_system_controller sysctrler: k3_sysctrler_start: Boot Notification response failed. ret = -110
> > >   Firmware init failed on rproc (-110)
> > >
> > >   resetting ...
> > >
> > > I tested with AM62x SK EVM E3. I'll try to apply your two missing
> > > patches and test again.
> >
> > Are you using a board with PCB revision 'PROC114E3'? If so this board is
> > known as 'Third prototype, early release revision of the AM62x SK EVM'
> > and should have GP silicon. Which means you must have re-added...
> >
> > BR2_TARGET_TI_K3_R5_LOADER_TIBOOT3_BIN="tiboot3-am62x-gp-evm.bin
> >
> > ...to your .config?
> >
> > I don't have a PROC114E3 board but the board I used to test the GP
> > variant today is a PROC114E2, and it worked. But neither of those boards
> > is considered "production".
> >
> > Also just for refernce, an SK-AM62 PCB revision history can be found in
> > Table 1-1 in the AM62x SK EVM User's Guide [1].
> >
> >
> > --
> > Andreas Dannenberg
> > Texas Instruments Inc
> >
> >
> > [1] https://www.ti.com/lit/pdf/spruj40
> >
> >
> >
> >
> > > Best,
> > > Gero
> > >
> > > > > Best regards,
> > > > > Romain
> > > > >
> > > [...]
> > >
> > > --
> > >
> > >
> > >
> > > –––
> > >
> > >
> > > grandcentrix GmbH | A Vodafone Company · Holzmarkt 1 · 50676
> > > *Cologne* | Phoenixseestrasse 18 · 44263 *Dortmund* · Germany
> > > | in
> > > <https://www.linkedin.com/company/grandcentrix> | phone: +49-221-677-860-0
> > > | email: hello@grandcentrix.net <mailto:hello@grandcentrix.net>
> > >
> > >
> > > grandcentrix cares about privacy
> > > <https://grandcentrix.net/de/pages/privacymail/>
> > >
> > > Amtsgericht Köln | HRB
> > > 70119 | Geschäftsführer: M. Krömer,  R. Hänel | USt.-IdNr.: DE266333969
> > >
> > > _______________________________________________
> > > buildroot mailing list
> > > buildroot@buildroot.org
> > > https://lists.buildroot.org/mailman/listinfo/buildroot
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
Gero Schwäricke April 10, 2024, 11:10 a.m. UTC | #9
On Wed, Apr 10, 2024 at 03:24:29AM -0500, Andreas Dannenberg via buildroot wrote:
> Gero, Dario,
>
[...]
> > At least my current test of ti_am62x_sk_defconfig on master failed to boot:
> > 
> >   U-Boot SPL 2024.01 (Apr 10 2024 - 09:32:17 +0200)
> >   k3_system_controller sysctrler: k3_sysctrler_start: Boot Notification response failed. ret = -110
> >   Firmware init failed on rproc (-110)
> > 
> >   resetting ...
> > 
> > I tested with AM62x SK EVM E3. I'll try to apply your two missing
> > patches and test again.
> 
> Are you using a board with PCB revision 'PROC114E3'? If so this board is
> known as 'Third prototype, early release revision of the AM62x SK EVM'
> and should have GP silicon. Which means you must have re-added...
> 
> BR2_TARGET_TI_K3_R5_LOADER_TIBOOT3_BIN="tiboot3-am62x-gp-evm.bin
> 
> ...to your .config?

Hi,

Yes, I have a PROC114E3.

I tested the same way I did V10, but missed

  [PATCH v12 16/16] package/ti-k3: switch ti_am6{2, 4}x_sk_defconfig to HS-FS by default

which was new in V11/12. I now manually set 

  BR2_TARGET_TI_K3_R5_LOADER_TIBOOT3_BIN="tiboot3-am62x-gp-evm.bin"

and it's booting fine. Thank you!

Also thanks for testing with the other hardware revisions!

Best,
Gero

> 
> I don't have a PROC114E3 board but the board I used to test the GP
> variant today is a PROC114E2, and it worked. But neither of those boards
> is considered "production".
> 
> Also just for refernce, an SK-AM62 PCB revision history can be found in
> Table 1-1 in the AM62x SK EVM User's Guide [1].
> 
> 
> --
> Andreas Dannenberg
> Texas Instruments Inc
> 
> 
> [1] https://www.ti.com/lit/pdf/spruj40 
> 
> 
> 
> 
> > Best,
> > Gero
> > 
> > > > Best regards,
> > > > Romain
> > > >
> > [...]
> > 
> > -- 
> > 
> > 
> > 
> > –––
> > 
> > 
> > grandcentrix GmbH | A Vodafone Company · Holzmarkt 1 · 50676 
> > *Cologne* | Phoenixseestrasse 18 · 44263 *Dortmund* · Germany
> > | in 
> > <https://www.linkedin.com/company/grandcentrix> | phone: +49-221-677-860-0 
> > | email: hello@grandcentrix.net <mailto:hello@grandcentrix.net>
> > 
> > 
> > grandcentrix cares about privacy 
> > <https://grandcentrix.net/de/pages/privacymail/>
> > 
> > Amtsgericht Köln | HRB  
> > 70119 | Geschäftsführer: M. Krömer,  R. Hänel | USt.-IdNr.: DE266333969
> > 
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
Romain Naour April 10, 2024, 9:30 p.m. UTC | #10
Hi Dario, All,

Le 10/04/2024 à 09:34, Dario Binacchi a écrit :
> Hi Romain, All
> 
> On Tue, Apr 9, 2024 at 11:17 PM Romain Naour <romain.naour@smile.fr> wrote:
>>
>> Hello Arnout, All,
>>
>> Le 08/04/2024 à 15:47, Arnout Vandecappelle a écrit :
>>>
>>> On 07/04/2024 22:30, Arnout Vandecappelle wrote:
>>>>
>>>>
>>>> On 07/04/2024 12:34, Romain Naour wrote:
>>>>> This series aims initially to fix AM62x-SK HS-FS devices but doing so
>>>>> would requires adding a TI legacy tool "ti-k3-core-secdev" into Buildroot.
>>>>> ti-k3-core-secdev is replaced by u-boot's binman tool since v2023.10 release
>>>>> of u-boot.
>>>>>
>>>>> Instead, we bump the BSP to use the latest u-boot release (2024.01) to use
>>>>> binman. Doing so requires to rework the TI K3 SoC support in Buildroot.
>>>>>
>>>>> This new version (v12) of this series remove the ti-k3 package and
>>>>> all SOC and SECTYPE options. As suggested by Michael Walle, copy the
>>>>> default tiboot3.bin and sysfw.itb (if any) if no custom file name is
>>>>> provided on the defconfig. Since such file name can be customized,
>>>>> the user must provide the complete firmware name if not using the
>>>>> default one.
>>>>>
>>>>> http://lists.busybox.net/pipermail/buildroot/2024-April/688943.html
>>>>>
>>>>> With the advice of Andreas Dannenberg (TI K3 architect), we switch
>>>>> AM62x/AM62Ax/AM64x to HS-FS by default.
>>>>>
>>>>> Tests performed on earlier revision of this series:
>>>>>
>>>>> * compiled ti_am62x_sk_defconfig
>>>>>    * success
>>>>> * booted on AM62x SK EVM (E3)
>>>>>    * success
>>>>>    * no obvious errors in dmesg
>>>>>
>>>>> Tested-by: Gero Schwäricke <gero.schwaericke@grandcentrix.net>
>>>>>
>>>>> Dario Binacchi (10):
>>>>>    boot/ti-k3-r5-loader: drop hash for version 2022.10
>>>>>    boot/ti-k3-r5-loader: add BR2_TARGET_TI_K3_R5_LOADER_USE_BINMAN option
>>>>>    boot/uboot: add BR2_TARGET_UBOOT_USE_BINMAN option
>>>>>    boot/ti-k3-r5-loader: install tiboot3.bin and sysfw.itb to
>>>>>      BINARIES_DIR
>>>>>    configs/ti_am62x_sk_defconfig: bump U-Boot version to 2024.01
>>>>>    configs/ti_am62x_sk_defconfig: bump Linux version to 6.6.18
>>>>>    board/ti/am62x-sk: generalize post-build.sh
>>>>>    board/ti/am62x-sk: move post-build.sh to board/ti/common/am6xx
>>>>>    configs/ti_am64x_sk_defconfig: bump U-Boot version to 2024.01
>>>>>    configs/ti_am64x_sk_defconfig: bump Linux version to 6.6.18
>>>>>
>>>>> Romain Naour (6):
>>>>>    board/ti/am6{2,4}x-sk: add arm-trusted-firmware v2.7 hash
>>>>>    boot/uboot: rename TI_K3_DM option to cover further TI K3 SoCs support
>>>>>    boot/uboot: remove BR2_TARGET_UBOOT_TI_K3_DM_SOCNAME
>>>>>    boot/ti-k3-image-gen: remove package
>>>>>    boot/ti-k3-r5-loader: remove BR2_TARGET_TI_K3_R5_LOADER_USE_BINMAN
>>>>>    package/ti-k3: switch AM62x/AM62Ax/AM64x to HS-FS by default
>>>>
>>>>  Patches 1-5 applied to master. And there I stopped, due to the SWSFW typo. I
>>>> could have fixed it up myself but it's really every patch that needs to be
>>>> updated...
>>>
>>>
>>>  I also reviewed the rest of the series with minor comments, so you can apply
>>> them directly (with my Reviewed-by: Arnout Vandecappelle <arnout@mind.be>)
>>
>> Thanks, the series is merged.
>>
>> Thanks to Dario and Michael for the initial work on the HS-FS topic!
>>
>> The initial series showed that it was necessary to rework heavily the TI K3 SoC
>> related packages in Buildroot. This was the opportinity to anticipate on the
>> addition of new TI K3 SoC support.
>>
>> Thanks to Andreas and Bryan from TI for the review and fine details about TI K3
>> SoC familly and the runtime testing.
>>
>> Thanks to all testers and reviewers.
> 
> I think my two patches for version 10 were ultimately lost:
> 
> [v10,05/12] package/ti-k3: disable HS-FS for AM65 SOC
> [v10,04/12] package/ti-k3: move TI_K3_{SECTYPE, SOC} out of the image-gen scope

See the discussion with Heiko and Michael Walle.
http://lists.busybox.net/pipermail/buildroot/2024-April/688953.html

The ti-k3 package is not needed if we let the user to provide the firmware name
he need.

> 
> Specifically, patch 4 is necessary for the proper creation of the
> image. Has version 12 actually been tested by anyone?
> I can assure you version 10 has been.

The ATF, uboot, kernel version were keep as is as you tested it already.
I checked if the right firmware was deployed in BINARIES_DIR.

> 
> Additionally, it seems that patch
> [v10,02/12] boot/ti-k3-r5-loader: set binman environment
> has been incorporated into your patch "boot/ti-k3-r5-loader: remove
> BR2_TARGET_TI_K3_R5_LOADER_USE_BINMAN"
> and I don't understand why.

I tried to explain in the commit log:

The BR2_TARGET_TI_K3_R5_LOADER_USE_BINMAN option is currently needed
since we are in the middle of the process to switch TI AM62 and AM64
board defconfig to binman. Keep BR2_TARGET_TI_K3_R5_LOADER_USE_BINMAN
disabled for them until the u-boot/ti-k3-r5-loader version bump to
2024.01.

Best regards,
Romain


> 
> Thanks and regards,
> Dario
> 
>>
>> Best regards,
>> Romain
>>
>>>
>>>
>>>  Regards,
>>>  Arnout
>>>
>>>
>>>>
>>>>
>>>>  Regards,
>>>>  Arnout
>>>>
>>>>>
>>>>>   Config.in.legacy                              | 15 ++++
>>>>>   DEVELOPERS                                    |  2 -
>>>>>   board/ti/am62x-sk/genimage.cfg                |  7 +-
>>>>>   .../arm-trusted-firmware.hash                 |  2 +
>>>>>   .../patches/linux-headers/linux-headers.hash  |  1 +
>>>>>   board/ti/am62x-sk/patches/linux/linux.hash    |  2 +
>>>>>   .../ti-k3-r5-loader/ti-k3-r5-loader.hash      |  2 +
>>>>>   board/ti/am64x-sk/genimage.cfg                |  7 +-
>>>>>   .../arm-trusted-firmware.hash                 |  2 +
>>>>>   .../patches/linux-headers/linux-headers.hash  |  1 +
>>>>>   board/ti/am64x-sk/patches/linux/linux.hash    |  2 +
>>>>>   .../ti-k3-r5-loader/ti-k3-r5-loader.hash      |  1 +
>>>>>   board/ti/common/am6xx/post-build.sh           | 58 ++++++++++++++
>>>>>   boot/Config.in                                |  1 -
>>>>>   boot/ti-k3-image-gen/Config.in                | 77 -------------------
>>>>>   boot/ti-k3-image-gen/ti-k3-image-gen.hash     |  3 -
>>>>>   boot/ti-k3-image-gen/ti-k3-image-gen.mk       | 54 -------------
>>>>>   boot/ti-k3-r5-loader/Config.in                | 33 ++++++++
>>>>>   boot/ti-k3-r5-loader/ti-k3-r5-loader.hash     |  1 -
>>>>>   boot/ti-k3-r5-loader/ti-k3-r5-loader.mk       | 40 +++++++++-
>>>>>   boot/uboot/Config.in                          | 35 +++++----
>>>>>   boot/uboot/uboot.mk                           | 12 ++-
>>>>>   configs/ti_am62x_sk_defconfig                 | 21 ++---
>>>>>   configs/ti_am64x_sk_defconfig                 | 20 +++--
>>>>>   24 files changed, 221 insertions(+), 178 deletions(-)
>>>>>   create mode 100644
>>>>> board/ti/am62x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash
>>>>>   create mode 120000 board/ti/am62x-sk/patches/linux-headers/linux-headers.hash
>>>>>   create mode 100644 board/ti/am62x-sk/patches/linux/linux.hash
>>>>>   create mode 100644
>>>>> board/ti/am62x-sk/patches/ti-k3-r5-loader/ti-k3-r5-loader.hash
>>>>>   create mode 100644
>>>>> board/ti/am64x-sk/patches/arm-trusted-firmware/arm-trusted-firmware.hash
>>>>>   create mode 120000 board/ti/am64x-sk/patches/linux-headers/linux-headers.hash
>>>>>   create mode 100644 board/ti/am64x-sk/patches/linux/linux.hash
>>>>>   create mode 100644
>>>>> board/ti/am64x-sk/patches/ti-k3-r5-loader/ti-k3-r5-loader.hash
>>>>>   create mode 100755 board/ti/common/am6xx/post-build.sh
>>>>>   delete mode 100644 boot/ti-k3-image-gen/Config.in
>>>>>   delete mode 100644 boot/ti-k3-image-gen/ti-k3-image-gen.hash
>>>>>   delete mode 100644 boot/ti-k3-image-gen/ti-k3-image-gen.mk
>>>>>
>>>>> --
>>>>> 2.44.0
>>>>>
>>>>> _______________________________________________
>>>>> buildroot mailing list
>>>>> buildroot@buildroot.org
>>>>> https://lists.buildroot.org/mailman/listinfo/buildroot
>>
> 
>
Romain Naour April 10, 2024, 9:38 p.m. UTC | #11
Hi Andreas, Gero, Dario, All,

Le 10/04/2024 à 10:24, Andreas Dannenberg via buildroot a écrit :
> Gero, Dario,
> 
> On Wed, Apr 10, 2024 at 10:00:06AM +0200, Gero Schwäricke via buildroot wrote:
>> On Wed, Apr 10, 2024 at 09:34:16AM +0200, Dario Binacchi wrote:
>>> Hi Romain, All
>>>
>>> On Tue, Apr 9, 2024 at 11:17 PM Romain Naour <romain.naour@smile.fr> wrote:
>>>>
>>>> Hello Arnout, All,
>> [...]
>>>>
>>>> Thanks, the series is merged.
>>>>
>>>> Thanks to Dario and Michael for the initial work on the HS-FS topic!
>>>>
>>>> The initial series showed that it was necessary to rework heavily the TI K3 SoC
>>>> related packages in Buildroot. This was the opportinity to anticipate on the
>>>> addition of new TI K3 SoC support.
>>>>
>>>> Thanks to Andreas and Bryan from TI for the review and fine details about TI K3
>>>> SoC familly and the runtime testing.
>>>>
>>>> Thanks to all testers and reviewers.
>>>
>>> I think my two patches for version 10 were ultimately lost:
>>>
>>> [v10,05/12] package/ti-k3: disable HS-FS for AM65 SOC
>>> [v10,04/12] package/ti-k3: move TI_K3_{SECTYPE, SOC} out of the image-gen scope
>>>
>>> Specifically, patch 4 is necessary for the proper creation of the
>>> image. Has version 12 actually been tested by anyone?
>>> I can assure you version 10 has been.
>>>
>>> Additionally, it seems that patch
>>> [v10,02/12] boot/ti-k3-r5-loader: set binman environment
>>> has been incorporated into your patch "boot/ti-k3-r5-loader: remove
>>> BR2_TARGET_TI_K3_R5_LOADER_USE_BINMAN"
>>> and I don't understand why.
>>>
>>> Thanks and regards,
>>> Dario
>>
>> Hi Dario,
>>
>> I can confirm that something is amiss, maybe it would have been better
>> to await more tests with patch V12.
> 
> I just tested top-of-master w/o any additional patches on SK-AM62 (with
> GP silicon) and SK-AM62B (production board, with HS-FS silicon) and it
> worked like a champ. Here's the beginning of the boot using SK-AM62...
> 
> <...snip...>
> U-Boot SPL 2024.01 (Apr 09 2024 - 20:11:30 -0500)
> SYSFW ABI: 3.1 (firmware rev 0x0008 '8.6.4--v08.06.04 (Chill Capybar')
> SPL initial stack usage: 13368 bytes
> Trying to boot from MMC2
> Authentication passed
> Authentication passed
> Authentication passed
> Authentication passed
> Authentication passed
> Starting ATF on ARM64 core...
> 
> NOTICE:  BL31: v2.7(release):v2.7
> NOTICE:  BL31: Built : 20:08:16, Apr  9 2024
> I/TC:
> I/TC: OP-TEE version: Unknown_4.0 (gcc version 12.3.0 (Buildroot
> 2024.02-416-gd01e13c4d4)) #1 Wed Apr 10 01:08:14 UTC 2024 aarch64
> I/TC: WARNING: This OP-TEE configuration might be insecure!
> I/TC: WARNING: Please check
> https://optee.readthedocs.io/en/latest/architecture/porting_guidelines.html
> I/TC: Primary CPU initializing
> I/TC: SYSFW ABI: 3.1 (firmware rev 0x0008 '8.6.4--v08.06.04 (Chill
> Capybar')
> I/TC: HUK Initialized
> I/TC: Activated SA2UL device
> I/TC: Enabled firewalls for SA2UL TRNG device
> I/TC: SA2UL TRNG initialized
> I/TC: SA2UL Drivers initialized
> I/TC: Primary CPU switching to normal world boot
> 
> U-Boot SPL 2024.01 (Apr 09 2024 - 20:11:48 -0500)
> SYSFW ABI: 3.1 (firmware rev 0x0008 '8.6.4--v08.06.04 (Chill Capybar')
> SPL initial stack usage: 1872 bytes
> Trying to boot from MMC2
> Authentication passed
> Authentication passed
> 
> 
> U-Boot 2024.01 (Apr 09 2024 - 20:11:48 -0500)
> 
> SoC:   AM62X SR1.0 HS-FS
> Model: Texas Instruments AM625 SK
> DRAM:  2 GiB
> Core:  56 devices, 23 uclasses, devicetree: separate
> MMC:   mmc@fa10000: 0, mmc@fa00000: 1
> Loading Environment from nowhere... OK
> In:    serial@2800000
> Out:   serial@2800000
> Err:   serial@2800000
> Net:   eth0: ethernet@8000000port@1
> Hit any key to stop autoboot:  0
> <...snip...>
> 
> 
>> At least my current test of ti_am62x_sk_defconfig on master failed to boot:
>>
>>   U-Boot SPL 2024.01 (Apr 10 2024 - 09:32:17 +0200)
>>   k3_system_controller sysctrler: k3_sysctrler_start: Boot Notification response failed. ret = -110
>>   Firmware init failed on rproc (-110)
>>
>>   resetting ...
>>
>> I tested with AM62x SK EVM E3. I'll try to apply your two missing
>> patches and test again.
> 
> Are you using a board with PCB revision 'PROC114E3'? If so this board is
> known as 'Third prototype, early release revision of the AM62x SK EVM'
> and should have GP silicon. Which means you must have re-added...
> 
> BR2_TARGET_TI_K3_R5_LOADER_TIBOOT3_BIN="tiboot3-am62x-gp-evm.bin
> 
> ...to your .config?
> 
> I don't have a PROC114E3 board but the board I used to test the GP
> variant today is a PROC114E2, and it worked. But neither of those boards
> is considered "production".
> 
> Also just for refernce, an SK-AM62 PCB revision history can be found in
> Table 1-1 in the AM62x SK EVM User's Guide [1].

Thanks for the additional testing Andreas!

Gero, if you are using an early hardware revision of the SK-AM62 you must re-add:

  BR2_TARGET_TI_K3_R5_LOADER_TIBOOT3_BIN="tiboot3-am62x-gp-evm.bin"

I added a new comment in board/ti/am62x-sk/readme.txt [1] that refer to the TI
E2E forum post [2].

[1]
https://gitlab.com/buildroot.org/buildroot/-/blob/master/board/ti/am62x-sk/readme.txt?ref_type=heads&plain=1#L20

[2]
https://e2e.ti.com/support/processors-group/processors/f/processors-forum/1210443/faq-am625-generating-sitara-am62x-am62ax-am64x-gp-device-bootable-mmc-sd-card-images-using-sdk-v8-6-and-yocto

Best regards,
Romain

> 
> 
> --
> Andreas Dannenberg
> Texas Instruments Inc
> 
> 
> [1] https://www.ti.com/lit/pdf/spruj40 
> 
> 
> 
> 
>> Best,
>> Gero
>>
>>>> Best regards,
>>>> Romain
>>>>
>> [...]
>>
>> -- 
>>
>>
>>
>> –––
>>
>>
>> grandcentrix GmbH | A Vodafone Company · Holzmarkt 1 · 50676 
>> *Cologne* | Phoenixseestrasse 18 · 44263 *Dortmund* · Germany
>> | in 
>> <https://www.linkedin.com/company/grandcentrix> | phone: +49-221-677-860-0 
>> | email: hello@grandcentrix.net <mailto:hello@grandcentrix.net>
>>
>>
>> grandcentrix cares about privacy 
>> <https://grandcentrix.net/de/pages/privacymail/>
>>
>> Amtsgericht Köln | HRB  
>> 70119 | Geschäftsführer: M. Krömer,  R. Hänel | USt.-IdNr.: DE266333969
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot@buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot