mbox series

[0/3] grpc-related fixes

Message ID 20210203124325.18843-1-patrickdepinguin@gmail.com
Headers show
Series grpc-related fixes | expand

Message

Thomas De Schampheleire Feb. 3, 2021, 12:43 p.m. UTC 
From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>

Commit fedf3318e3fd3c9ba57389ed2b36472f1a772b9e removed an obsolete patch on
grpc, but this had the side effect that building collectd after grpc no longer
succeeded, because grpc_cpp_plugin from the target was executed.

During investigation of this issue, a number of related problems were found.
This series addresses these problems.

Thomas De Schampheleire (3):
  package/collectd: stop passing '--with-libgrpc++'
  package/grpc: fix cross-compilation with
    gRPC_BUILD_GRPC_CPP_PLUGIN=OFF
  package/grpc: disable unnecessary build plugins

 package/collectd/collectd.mk                  |  3 --
 ...ix-cross-compilation-with-gRPC_BUILD.patch | 43 +++++++++++++++++++
 package/grpc/grpc.mk                          |  9 +++-
 3 files changed, 51 insertions(+), 4 deletions(-)
 create mode 100644 package/grpc/0001-CMakeLists.txt-fix-cross-compilation-with-gRPC_BUILD.patch

Comments

Yann E. MORIN Feb. 3, 2021, 10:02 p.m. UTC | #1 
Thomas, All,

On 2021-02-03 13:43 +0100, Thomas De Schampheleire spake thusly:
> From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> 
> Commit fedf3318e3fd3c9ba57389ed2b36472f1a772b9e removed an obsolete patch on
> grpc, but this had the side effect that building collectd after grpc no longer
> succeeded, because grpc_cpp_plugin from the target was executed.
> 
> During investigation of this issue, a number of related problems were found.
> This series addresses these problems.

Series applied to master, thanks.

> Thomas De Schampheleire (3):
>   package/collectd: stop passing '--with-libgrpc++'
>   package/grpc: fix cross-compilation with
>     gRPC_BUILD_GRPC_CPP_PLUGIN=OFF
>   package/grpc: disable unnecessary build plugins

I'll further reply to this last patch, though, because I have some
questions and suggestions.

Regards,
Yann E. MORIN.

>  package/collectd/collectd.mk                  |  3 --
>  ...ix-cross-compilation-with-gRPC_BUILD.patch | 43 +++++++++++++++++++
>  package/grpc/grpc.mk                          |  9 +++-
>  3 files changed, 51 insertions(+), 4 deletions(-)
>  create mode 100644 package/grpc/0001-CMakeLists.txt-fix-cross-compilation-with-gRPC_BUILD.patch
> 
> -- 
> 2.26.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot