mbox series

[0/2] autotools: do not overwrite first include path

Message ID 20200204124013.17340-1-heiko.thiery@gmail.com
Headers show
Series autotools: do not overwrite first include path | expand

Message

Heiko Thiery Feb. 4, 2020, 12:40 p.m. UTC
The first patch fixes the issue with the autotools package.
For a detailed explanation take a look into the commit message.

The second patch removes the hooks that were introduced to workaround
the issue that is fixed with the first patch.

Heiko Thiery (1):
  remove the hook for creating the m4 directory

Michael Walle (1):
  autotools: do not overwrite first include path

 package/atest/atest.mk                                    | 6 ------
 package/autoconf/autoconf.mk                              | 6 +++---
 package/automake/automake.mk                              | 4 +++-
 package/bayer2rgb-neon/bayer2rgb-neon.mk                  | 6 ------
 package/bluez-alsa/bluez-alsa.mk                          | 6 ------
 package/davici/davici.mk                                  | 5 -----
 package/dropwatch/dropwatch.mk                            | 6 ------
 package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk      | 7 -------
 .../gst1-plugins-bayer2rgb-neon.mk                        | 5 -----
 package/gutenprint/gutenprint.mk                          | 7 -------
 package/irqbalance/irqbalance.mk                          | 7 -------
 package/jamvm/jamvm.mk                                    | 7 -------
 package/janus-gateway/janus-gateway.mk                    | 5 -----
 package/lcdapi/lcdapi.mk                                  | 6 ------
 package/libdmtx/libdmtx.mk                                | 7 -------
 package/libiscsi/libiscsi.mk                              | 6 ------
 package/libpam-nfc/libpam-nfc.mk                          | 6 ------
 package/libsoundtouch/libsoundtouch.mk                    | 5 -----
 package/libva-utils/libva-utils.mk                        | 6 ------
 package/ltrace/ltrace.mk                                  | 5 -----
 package/mfoc/mfoc.mk                                      | 6 ------
 package/minicom/minicom.mk                                | 6 ------
 package/musl-fts/musl-fts.mk                              | 5 -----
 package/open-lldp/open-lldp.mk                            | 8 --------
 package/openpgm/openpgm.mk                                | 8 --------
 package/pdbg/pdbg.mk                                      | 5 -----
 package/sdbusplus/sdbusplus.mk                            | 6 ------
 package/speexdsp/speexdsp.mk                              | 6 ------
 package/sysprof/sysprof.mk                                | 6 ------
 package/tesseract-ocr/tesseract-ocr.mk                    | 7 -------
 30 files changed, 6 insertions(+), 175 deletions(-)

Comments

Yann E. MORIN Feb. 4, 2020, 1:13 p.m. UTC | #1
Heiko, All,
On 2020-02-04 13:40 +0100, Heiko Thiery spake thusly:
> The first patch fixes the issue with the autotools package.
> For a detailed explanation take a look into the commit message.
> 
> The second patch removes the hooks that were introduced to workaround
> the issue that is fixed with the first patch.
> 
> Heiko Thiery (1):
>   remove the hook for creating the m4 directory
> 
> Michael Walle (1):
>   autotools: do not overwrite first include path

Series applied to master, thanks! :-)

I just slightly reword the commit logs with a little bit of extra
details.

Regards,
Yann E. MORIN.

>  package/atest/atest.mk                                    | 6 ------
>  package/autoconf/autoconf.mk                              | 6 +++---
>  package/automake/automake.mk                              | 4 +++-
>  package/bayer2rgb-neon/bayer2rgb-neon.mk                  | 6 ------
>  package/bluez-alsa/bluez-alsa.mk                          | 6 ------
>  package/davici/davici.mk                                  | 5 -----
>  package/dropwatch/dropwatch.mk                            | 6 ------
>  package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk      | 7 -------
>  .../gst1-plugins-bayer2rgb-neon.mk                        | 5 -----
>  package/gutenprint/gutenprint.mk                          | 7 -------
>  package/irqbalance/irqbalance.mk                          | 7 -------
>  package/jamvm/jamvm.mk                                    | 7 -------
>  package/janus-gateway/janus-gateway.mk                    | 5 -----
>  package/lcdapi/lcdapi.mk                                  | 6 ------
>  package/libdmtx/libdmtx.mk                                | 7 -------
>  package/libiscsi/libiscsi.mk                              | 6 ------
>  package/libpam-nfc/libpam-nfc.mk                          | 6 ------
>  package/libsoundtouch/libsoundtouch.mk                    | 5 -----
>  package/libva-utils/libva-utils.mk                        | 6 ------
>  package/ltrace/ltrace.mk                                  | 5 -----
>  package/mfoc/mfoc.mk                                      | 6 ------
>  package/minicom/minicom.mk                                | 6 ------
>  package/musl-fts/musl-fts.mk                              | 5 -----
>  package/open-lldp/open-lldp.mk                            | 8 --------
>  package/openpgm/openpgm.mk                                | 8 --------
>  package/pdbg/pdbg.mk                                      | 5 -----
>  package/sdbusplus/sdbusplus.mk                            | 6 ------
>  package/speexdsp/speexdsp.mk                              | 6 ------
>  package/sysprof/sysprof.mk                                | 6 ------
>  package/tesseract-ocr/tesseract-ocr.mk                    | 7 -------
>  30 files changed, 6 insertions(+), 175 deletions(-)
> 
> -- 
> 2.20.1
>
Peter Korsgaard Feb. 8, 2020, 7:56 a.m. UTC | #2
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Heiko, All,
 > On 2020-02-04 13:40 +0100, Heiko Thiery spake thusly:
 >> The first patch fixes the issue with the autotools package.
 >> For a detailed explanation take a look into the commit message.
 >> 
 >> The second patch removes the hooks that were introduced to workaround
 >> the issue that is fixed with the first patch.
 >> 
 >> Heiko Thiery (1):
 >> remove the hook for creating the m4 directory
 >> 
 >> Michael Walle (1):
 >> autotools: do not overwrite first include path

 > Series applied to master, thanks! :-)

 > I just slightly reword the commit logs with a little bit of extra
 > details.

It unfortunately seems to cause some breakage :/

E.G. sdl_mixer fails with an autools-related issues since this got
applied:

libtool: Version mismatch error.  This is libtool 2.4.6, but the
libtool: definition of this LT_INIT comes from libtool 2.2.6.
libtool: You should recreate aclocal.m4 with macros from libtool 2.4.6
libtool: and run autoconf again.

http://autobuild.buildroot.net/?reason=sdl_mixer-1.2.12

Care to take a look?
Yann E. MORIN Feb. 8, 2020, 6:40 p.m. UTC | #3
Peter, All,

On 2020-02-08 08:56 +0100, Peter Korsgaard spake thusly:
> >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> 
>  > Heiko, All,
>  > On 2020-02-04 13:40 +0100, Heiko Thiery spake thusly:
>  >> The first patch fixes the issue with the autotools package.
>  >> For a detailed explanation take a look into the commit message.
>  >> 
>  >> The second patch removes the hooks that were introduced to workaround
>  >> the issue that is fixed with the first patch.
>  >> 
>  >> Heiko Thiery (1):
>  >> remove the hook for creating the m4 directory
>  >> 
>  >> Michael Walle (1):
>  >> autotools: do not overwrite first include path
> 
>  > Series applied to master, thanks! :-)
> 
>  > I just slightly reword the commit logs with a little bit of extra
>  > details.
> 
> It unfortunately seems to cause some breakage :/
> 
> E.G. sdl_mixer fails with an autools-related issues since this got
> applied:
> 
> libtool: Version mismatch error.  This is libtool 2.4.6, but the
> libtool: definition of this LT_INIT comes from libtool 2.2.6.
> libtool: You should recreate aclocal.m4 with macros from libtool 2.4.6
> libtool: and run autoconf again.
> 
> http://autobuild.buildroot.net/?reason=sdl_mixer-1.2.12
> 
> Care to take a look?

Patch on the list. I'll test sdl2_mixer now, it should have the same
issue, since that code has not changed from the 1.2 era (even if our
autobuilders do not yet report a single failure...).

Regards,
Yann E. MORIN.
Heiko Thiery Feb. 8, 2020, 6:58 p.m. UTC | #4
Hi Yann, All,

Am Sa., 8. Feb. 2020 um 19:40 Uhr schrieb Yann E. MORIN
<yann.morin.1998@free.fr>:
>
> Peter, All,
>
> On 2020-02-08 08:56 +0100, Peter Korsgaard spake thusly:
> > >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> >
> >  > Heiko, All,
> >  > On 2020-02-04 13:40 +0100, Heiko Thiery spake thusly:
> >  >> The first patch fixes the issue with the autotools package.
> >  >> For a detailed explanation take a look into the commit message.
> >  >>
> >  >> The second patch removes the hooks that were introduced to workaround
> >  >> the issue that is fixed with the first patch.
> >  >>
> >  >> Heiko Thiery (1):
> >  >> remove the hook for creating the m4 directory
> >  >>
> >  >> Michael Walle (1):
> >  >> autotools: do not overwrite first include path
> >
> >  > Series applied to master, thanks! :-)
> >
> >  > I just slightly reword the commit logs with a little bit of extra
> >  > details.
> >
> > It unfortunately seems to cause some breakage :/
> >
> > E.G. sdl_mixer fails with an autools-related issues since this got
> > applied:
> >
> > libtool: Version mismatch error.  This is libtool 2.4.6, but the
> > libtool: definition of this LT_INIT comes from libtool 2.2.6.
> > libtool: You should recreate aclocal.m4 with macros from libtool 2.4.6
> > libtool: and run autoconf again.
> >
> > http://autobuild.buildroot.net/?reason=sdl_mixer-1.2.12
> >
> > Care to take a look?
>
> Patch on the list. I'll test sdl2_mixer now, it should have the same
> issue, since that code has not changed from the 1.2 era (even if our
> autobuilders do not yet report a single failure...).

That was fast .. no chance for me to take a look ;-/

> Regards,
> Yann E. MORIN.
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'