| Message ID | 20191227144324.84759-1-giulio.benetti@benettiengineering.com |
|---|---|
| Headers | show |
| Series | NSPR cleanup | expand |
Giulio, All, On 2019-12-27 15:43 +0100, Giulio Benetti spake thusly: > This patchset makes libnspr available for every architecture, before > Xtensa and Arc architectures were not supported. By doing this we can then > remove additional check in Config.in files with > 'depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT' that becomes useless. > > Giulio Benetti (3): > package/libnspr: allow building for Arc Architecture I've applied that one... > package/libnspr: enable building with xtensa > package/libnspr: remove BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT .. but those two ones are a feature patch. Let's at least wait for upstream to reply/apply it before we can carry it. As such, I've marked them as "Awaiting Upstream" (which is basically equivalanet to a reject, sorry). Regards, Yann E. MORIN. > > package/ecryptfs-utils/Config.in | 2 -- > ...6092_Add_support_for_building_xtensa.patch | 33 +++++++++++++++++++ > package/libnspr/Config.in | 8 ----- > package/libnss/Config.in | 2 -- > package/spidermonkey/Config.in | 1 - > 5 files changed, 33 insertions(+), 13 deletions(-) > create mode 100644 package/libnspr/0001-Bug_1606092_Add_support_for_building_xtensa.patch > > -- > 2.20.1 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Hi Yann, All, On 12/29/19 10:57 AM, Yann E. MORIN wrote: > Giulio, All, > > On 2019-12-27 15:43 +0100, Giulio Benetti spake thusly: >> This patchset makes libnspr available for every architecture, before >> Xtensa and Arc architectures were not supported. By doing this we can then >> remove additional check in Config.in files with >> 'depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT' that becomes useless. >> >> Giulio Benetti (3): >> package/libnspr: allow building for Arc Architecture > > I've applied that one... > >> package/libnspr: enable building with xtensa >> package/libnspr: remove BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT > > .. but those two ones are a feature patch. Let's at least wait for > upstream to reply/apply it before we can carry it. As such, I've marked > them as "Awaiting Upstream" (which is basically equivalanet to a reject, > sorry). Patch: "package/libnspr: enable building with xtensa" contains a patch that is equal to previous patch I've already upstream to support microblaze, nios-II and nds32. So Xtensa should do nothing different from those 3 architectures and endianness is taken into account too. So if upstream already trusted it: https://bugzilla.mozilla.org/show_bug.cgi?id=1578363 they should trust the same this new one. Thanks for reviewing and Kind regards
Hi Yann, On 12/29/19 10:57 AM, Yann E. MORIN wrote: > Giulio, All, > > On 2019-12-27 15:43 +0100, Giulio Benetti spake thusly: >> This patchset makes libnspr available for every architecture, before >> Xtensa and Arc architectures were not supported. By doing this we can then >> remove additional check in Config.in files with >> 'depends on BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT' that becomes useless. >> >> Giulio Benetti (3): >> package/libnspr: allow building for Arc Architecture > > I've applied that one... > >> package/libnspr: enable building with xtensa >> package/libnspr: remove BR2_PACKAGE_LIBNSPR_ARCH_SUPPORT > > .. but those two ones are a feature patch. Let's at least wait for > upstream to reply/apply it before we can carry it. As such, I've marked > them as "Awaiting Upstream" (which is basically equivalanet to a reject, > sorry). Patch contained in "package/libnspr: enable building with xtensa" has been upstreamed: https://bugzilla.mozilla.org/show_bug.cgi?id=1606092 https://hg.mozilla.org/projects/nspr/rev/ef5d8d008815e8367e684149f88b43f5ae53e1d7 Best regards