diff mbox series

[next] tpm2-tss: depend on shared libraries

Message ID 20181119044123.19463-1-casantos@datacom.com.br
State Superseded, archived
Headers show
Series [next] tpm2-tss: depend on shared libraries | expand

Commit Message

Carlos Santos Nov. 19, 2018, 4:41 a.m. UTC
The code includes dlfcn.h even if --enable-static and --disable-shared
are passed to configure. There is an "#ifndef NO_DL ... #endif" wrapper
but NO_DL is never defined and adding "-DNO_DL" to CFLAGS causes other
compilation errors.

Fixes:
  http://autobuild.buildroot.net/results/cfc3bfef5e93329bf944a57947086d9ddc4fece3

Signed-off-by: Carlos Santos <casantos@datacom.com.br>
---
 package/tpm2-tss/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Thomas Petazzoni Nov. 19, 2018, 8:59 p.m. UTC | #1
Hello Carlos,

On Mon, 19 Nov 2018 02:41:23 -0200, Carlos Santos wrote:
> The code includes dlfcn.h even if --enable-static and --disable-shared
> are passed to configure. There is an "#ifndef NO_DL ... #endif" wrapper
> but NO_DL is never defined and adding "-DNO_DL" to CFLAGS causes other
> compilation errors.
> 
> Fixes:
>   http://autobuild.buildroot.net/results/cfc3bfef5e93329bf944a57947086d9ddc4fece3
> 
> Signed-off-by: Carlos Santos <casantos@datacom.com.br>

You need to propagate this dependency to the reverse dependencies of
tpm2-tss.

Thanks!

Thomas
Carlos Santos Nov. 20, 2018, 10:16 a.m. UTC | #2
Superseded-by: https://patchwork.ozlabs.org/patch/1000367/
diff mbox series

Patch

diff --git a/package/tpm2-tss/Config.in b/package/tpm2-tss/Config.in
index 4e299eccc1..26a120c46b 100644
--- a/package/tpm2-tss/Config.in
+++ b/package/tpm2-tss/Config.in
@@ -1,5 +1,6 @@ 
 config BR2_PACKAGE_TPM2_TSS
 	bool "tpm2-tss"
+	depends on !BR2_STATIC_LIBS # dlfcn.h
 	select BR2_PACKAGE_LIBURIPARSER
 	select BR2_PACKAGE_OPENSSL
 	help
@@ -30,3 +31,6 @@  config BR2_PACKAGE_TPM2_TSS
 	    Microsoft software TPM2 simulator.
 
 	  https://github.com/tpm2-software/tpm2-tss
+
+comment "tpm2-tss needs a toolchain w/ dynamic library"
+	depends BR2_STATIC_LIBS