diff mbox series

[OpenWrt-Devel,v4,1/2] kernel: revert bad module stripping patch

Message ID 20181104213348.22891-1-daniel.santos@pobox.com
State Superseded
Delegated to: Petr Štetiar
Headers show
Series [OpenWrt-Devel,v4,1/2] kernel: revert bad module stripping patch | expand

Commit Message

Daniel Santos Nov. 4, 2018, 9:33 p.m. UTC 
This patch is wrong in several regards.  1.) It violates the the
principle of least astonishment, 2.) it makes a radical change to the
kernel build without informing the user, 3.) it makes the change without
obtaining user consent, thus violating the spirit of free and open
source software, and 4.) it not only breaks debugging, but other
features such as kmemleak.

Signed-off-by: Daniel Santos <daniel.santos@pobox.com>
---
 .../generic/hack-4.14/202-reduce_module_size.patch | 24 ----------------------
 .../generic/hack-4.9/202-reduce_module_size.patch  | 24 ----------------------
 2 files changed, 48 deletions(-)
 delete mode 100644 target/linux/generic/hack-4.14/202-reduce_module_size.patch
 delete mode 100644 target/linux/generic/hack-4.9/202-reduce_module_size.patch
diff mbox series

Patch

diff --git a/target/linux/generic/hack-4.14/202-reduce_module_size.patch b/target/linux/generic/hack-4.14/202-reduce_module_size.patch
deleted file mode 100644
index 2cbb6add9a..0000000000
--- a/target/linux/generic/hack-4.14/202-reduce_module_size.patch
+++ /dev/null
@@ -1,24 +0,0 @@ 
-From fd66884da2f96d2a7ea73f58b1b86251b959a913 Mon Sep 17 00:00:00 2001
-From: Felix Fietkau <nbd@nbd.name>
-Date: Fri, 7 Jul 2017 16:56:19 +0200
-Subject: kernel: strip unnecessary symbol table information from kernel modules
-
-reduces default squashfs size on ar71xx by about 4k
-
-lede-commit: 058d331a39077f159ca8922f1f422a1346d6aa67
-Signed-off-by: Felix Fietkau <nbd@nbd.name>
----
- Makefile | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
---- a/Makefile
-+++ b/Makefile
-@@ -425,7 +425,7 @@ KBUILD_AFLAGS_KERNEL :=
- KBUILD_CFLAGS_KERNEL :=
- KBUILD_AFLAGS_MODULE  := -DMODULE
- KBUILD_CFLAGS_MODULE  := -DMODULE
--KBUILD_LDFLAGS_MODULE := -T $(srctree)/scripts/module-common.lds
-+KBUILD_LDFLAGS_MODULE = -T $(srctree)/scripts/module-common.lds $(if $(CONFIG_PROFILING),,-s)
- GCC_PLUGINS_CFLAGS :=
- 
- export ARCH SRCARCH SUBARCH CONFIG_SHELL HOSTCC HOSTCFLAGS CROSS_COMPILE AS LD
diff --git a/target/linux/generic/hack-4.9/202-reduce_module_size.patch b/target/linux/generic/hack-4.9/202-reduce_module_size.patch
deleted file mode 100644
index f744b945fe..0000000000
--- a/target/linux/generic/hack-4.9/202-reduce_module_size.patch
+++ /dev/null
@@ -1,24 +0,0 @@ 
-From fd66884da2f96d2a7ea73f58b1b86251b959a913 Mon Sep 17 00:00:00 2001
-From: Felix Fietkau <nbd@nbd.name>
-Date: Fri, 7 Jul 2017 16:56:19 +0200
-Subject: kernel: strip unnecessary symbol table information from kernel modules
-
-reduces default squashfs size on ar71xx by about 4k
-
-lede-commit: 058d331a39077f159ca8922f1f422a1346d6aa67
-Signed-off-by: Felix Fietkau <nbd@nbd.name>
----
- Makefile | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
---- a/Makefile
-+++ b/Makefile
-@@ -403,7 +403,7 @@ KBUILD_AFLAGS_KERNEL :=
- KBUILD_CFLAGS_KERNEL :=
- KBUILD_AFLAGS_MODULE  := -DMODULE
- KBUILD_CFLAGS_MODULE  := -DMODULE
--KBUILD_LDFLAGS_MODULE := -T $(srctree)/scripts/module-common.lds
-+KBUILD_LDFLAGS_MODULE = -T $(srctree)/scripts/module-common.lds $(if $(CONFIG_PROFILING),,-s)
- GCC_PLUGINS_CFLAGS :=
- 
- # Read KERNELRELEASE from include/config/kernel.release (if it exists)