| Message ID | 1540068491-14760-1-git-send-email-andrew@lunn.ch |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: ethernet:fec: Consistently use SPEED_ prefix | expand |
On 20.10.2018 23:48, Andrew Lunn wrote: > All other calls to phy_set_max_speed() use the SPEED_ prefix. Make the > FEC driver follow this common pattern. This makes no different to Difference. > generated code since SPEED_1000 is 1000, and SPEED_100 is 100. > > Reported-by: Corentin Labbe <clabbe@baylibre.com> > Signed-off-by: Andrew Lunn <andrew@lunn.ch> [...] MBR, Sergei
From: netdev-owner@vger.kernel.org <netdev-owner@vger.kernel.org> > All other calls to phy_set_max_speed() use the SPEED_ prefix. Make the > FEC driver follow this common pattern. This makes no different to > generated code since SPEED_1000 is 1000, and SPEED_100 is 100. > Please also add more information that was introduced by commit: 58056c1e1b0e ("net: ethernet: Use phy_set_max_speed() to limit advertised speed ") Andy > Reported-by: Corentin Labbe <clabbe@baylibre.com> > Signed-off-by: Andrew Lunn <andrew@lunn.ch> > --- > drivers/net/ethernet/freescale/fec_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/freescale/fec_main.c > b/drivers/net/ethernet/freescale/fec_main.c > index 6db69ba30dcd..b067eaf8b792 100644 > --- a/drivers/net/ethernet/freescale/fec_main.c > +++ b/drivers/net/ethernet/freescale/fec_main.c > @@ -1948,7 +1948,7 @@ static int fec_enet_mii_probe(struct > net_device *ndev) > > /* mask with MAC supported features */ > if (fep->quirks & FEC_QUIRK_HAS_GBIT) { > - phy_set_max_speed(phy_dev, 1000); > + phy_set_max_speed(phy_dev, SPEED_1000); > phy_remove_link_mode(phy_dev, > ETHTOOL_LINK_MODE_1000baseT_Half_BIT); > #if !defined(CONFIG_M5272) > @@ -1956,7 +1956,7 @@ static int fec_enet_mii_probe(struct > net_device *ndev) #endif > } > else > - phy_set_max_speed(phy_dev, 100); > + phy_set_max_speed(phy_dev, SPEED_100); > > fep->link = 0; > fep->full_duplex = 0; > -- > 2.19.0
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 6db69ba30dcd..b067eaf8b792 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -1948,7 +1948,7 @@ static int fec_enet_mii_probe(struct net_device *ndev) /* mask with MAC supported features */ if (fep->quirks & FEC_QUIRK_HAS_GBIT) { - phy_set_max_speed(phy_dev, 1000); + phy_set_max_speed(phy_dev, SPEED_1000); phy_remove_link_mode(phy_dev, ETHTOOL_LINK_MODE_1000baseT_Half_BIT); #if !defined(CONFIG_M5272) @@ -1956,7 +1956,7 @@ static int fec_enet_mii_probe(struct net_device *ndev) #endif } else - phy_set_max_speed(phy_dev, 100); + phy_set_max_speed(phy_dev, SPEED_100); fep->link = 0; fep->full_duplex = 0;
All other calls to phy_set_max_speed() use the SPEED_ prefix. Make the FEC driver follow this common pattern. This makes no different to generated code since SPEED_1000 is 1000, and SPEED_100 is 100. Reported-by: Corentin Labbe <clabbe@baylibre.com> Signed-off-by: Andrew Lunn <andrew@lunn.ch> --- drivers/net/ethernet/freescale/fec_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)