| Message ID | 1540068088-14446-1-git-send-email-andrew@lunn.ch |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] net: phy: phy_support_sym_pause: Clear Asym Pause | expand |
On Sat, Oct 20, 2018 at 10:41:28PM +0200, Andrew Lunn wrote: > When indicating the MAC supports Symmetric Pause, clear the Asymmetric > Pause bit, which could of been already set is the PHY supports it. > > Reported-by: Labbe Corentin <clabbe@baylibre.com> > Fixes: c306ad36184f ("net: ethernet: Add helper for MACs which support pause") > Signed-off-by: Andrew Lunn <andrew@lunn.ch> > --- > drivers/net/phy/phy_device.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c > index 43cb08dcce81..ab33d1777132 100644 > --- a/drivers/net/phy/phy_device.c > +++ b/drivers/net/phy/phy_device.c > @@ -1940,6 +1940,7 @@ EXPORT_SYMBOL(phy_remove_link_mode); > */ > void phy_support_sym_pause(struct phy_device *phydev) > { > + phydev->supported &= ~SUPPORTED_Asym_Pause; > phydev->supported |= SUPPORTED_Pause; > phydev->advertising = phydev->supported; > } > -- > 2.19.0 > Thanks, it made my imx6q-sabrelite works again with next-20181019. Tested-by: Corentin Labbe <clabbe@baylibre.com> For completeness, this is the ethtool output which confirm it. ethtool version 4.16 Settings for eth0: Supported ports: [ TP MII ] Supported link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Full Supported pause frame use: Symmetric Supports auto-negotiation: Yes Supported FEC modes: Not reported Advertised link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Full Advertised pause frame use: Symmetric Advertised auto-negotiation: Yes Advertised FEC modes: Not reported Link partner advertised link modes: 10baseT/Half 10baseT/Full 100baseT/Half 100baseT/Full 1000baseT/Half 1000baseT/Full Link partner advertised pause frame use: Symmetric Receive-only Link partner advertised auto-negotiation: Yes Link partner advertised FEC modes: Not reported Speed: 1000Mb/s Duplex: Full Port: MII PHYAD: 6 Transceiver: internal Auto-negotiation: on Supports Wake-on: d Wake-on: d Link detected: yes
Hello! On 20.10.2018 23:41, Andrew Lunn wrote: > When indicating the MAC supports Symmetric Pause, clear the Asymmetric > Pause bit, which could of been already set is the PHY supports it. Could've been, s/is/if/. > Reported-by: Labbe Corentin <clabbe@baylibre.com> > Fixes: c306ad36184f ("net: ethernet: Add helper for MACs which support pause") > Signed-off-by: Andrew Lunn <andrew@lunn.ch> [...] MBR, Sergei
From: Andrew Lunn <andrew@lunn.ch> Date: Sat, 20 Oct 2018 22:41:28 +0200 > When indicating the MAC supports Symmetric Pause, clear the Asymmetric > Pause bit, which could of been already set is the PHY supports it. > > Reported-by: Labbe Corentin <clabbe@baylibre.com> > Fixes: c306ad36184f ("net: ethernet: Add helper for MACs which support pause") > Signed-off-by: Andrew Lunn <andrew@lunn.ch> Applied.
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 43cb08dcce81..ab33d1777132 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -1940,6 +1940,7 @@ EXPORT_SYMBOL(phy_remove_link_mode); */ void phy_support_sym_pause(struct phy_device *phydev) { + phydev->supported &= ~SUPPORTED_Asym_Pause; phydev->supported |= SUPPORTED_Pause; phydev->advertising = phydev->supported; }
When indicating the MAC supports Symmetric Pause, clear the Asymmetric Pause bit, which could of been already set is the PHY supports it. Reported-by: Labbe Corentin <clabbe@baylibre.com> Fixes: c306ad36184f ("net: ethernet: Add helper for MACs which support pause") Signed-off-by: Andrew Lunn <andrew@lunn.ch> --- drivers/net/phy/phy_device.c | 1 + 1 file changed, 1 insertion(+)