| Message ID | 20181020202219.24489-1-fontaine.fabrice@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] postgresql: disable spinlock support for riscv64 | expand |
Hello, +Mark Corbin in Cc. On Sat, 20 Oct 2018 22:22:19 +0200, Fabrice Fontaine wrote: > Fixes: > - http://autobuild.buildroot.org/results/deebc4b8f615e1216279d6587e91f5654da2ad68 > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > -ifeq ($(BR2_arcle)$(BR2_arceb)$(BR2_microblazeel)$(BR2_microblazebe)$(BR2_or1k)$(BR2_nios2)$(BR2_xtensa),y) > +ifeq ($(BR2_arcle)$(BR2_arceb)$(BR2_microblazeel)$(BR2_microblazebe)$(BR2_or1k)$(BR2_nios2)$(BR2_RISCV_64)$(BR2_xtensa),y) Any reason for doing that only for riscv64 and not for RISC-V entirely ? Does PostgreSQL has a spinlock implementation for RISC-V 32 but not RISC-V 64 ? Thanks, Thomas
Hello Thomas On 20/10/2018 22:58, Thomas Petazzoni wrote: > Hello, > > +Mark Corbin in Cc. > > On Sat, 20 Oct 2018 22:22:19 +0200, Fabrice Fontaine wrote: >> Fixes: >> - http://autobuild.buildroot.org/results/deebc4b8f615e1216279d6587e91f5654da2ad68 >> >> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> >> -ifeq ($(BR2_arcle)$(BR2_arceb)$(BR2_microblazeel)$(BR2_microblazebe)$(BR2_or1k)$(BR2_nios2)$(BR2_xtensa),y) >> +ifeq ($(BR2_arcle)$(BR2_arceb)$(BR2_microblazeel)$(BR2_microblazebe)$(BR2_or1k)$(BR2_nios2)$(BR2_RISCV_64)$(BR2_xtensa),y) > Any reason for doing that only for riscv64 and not for RISC-V > entirely ? Does PostgreSQL has a spinlock implementation for RISC-V 32 > but not RISC-V 64 ? PostgreSQL does not have any support for RISC-V architecture, so I it makes sense to use BR2_riscv here instead of BR2_RISCV_64. Regards Mark > > Thanks, > > Thomas
Hello, On Sat, 20 Oct 2018 22:22:19 +0200, Fabrice Fontaine wrote: > Fixes: > - http://autobuild.buildroot.org/results/deebc4b8f615e1216279d6587e91f5654da2ad68 > > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> > --- > package/postgresql/postgresql.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I've changed the condition to use BR2_riscv instead of BR2_RISCV_64, and then applied. Thanks! Thomas
diff --git a/package/postgresql/postgresql.mk b/package/postgresql/postgresql.mk index 540e1540ca..8b3fd6f439 100644 --- a/package/postgresql/postgresql.mk +++ b/package/postgresql/postgresql.mk @@ -29,7 +29,7 @@ ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y) POSTGRESQL_CONF_OPTS += --disable-thread-safety endif -ifeq ($(BR2_arcle)$(BR2_arceb)$(BR2_microblazeel)$(BR2_microblazebe)$(BR2_or1k)$(BR2_nios2)$(BR2_xtensa),y) +ifeq ($(BR2_arcle)$(BR2_arceb)$(BR2_microblazeel)$(BR2_microblazebe)$(BR2_or1k)$(BR2_nios2)$(BR2_RISCV_64)$(BR2_xtensa),y) POSTGRESQL_CONF_OPTS += --disable-spinlocks endif
Fixes: - http://autobuild.buildroot.org/results/deebc4b8f615e1216279d6587e91f5654da2ad68 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> --- package/postgresql/postgresql.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)