| Message ID | 20181019133835.16494-5-berrange@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add a standard authorization framework | expand |
On Fri, Oct 19, 2018 at 5:43 PM Daniel P. Berrangé <berrange@redhat.com> wrote: > > Various functions accepting 'char *' string parameters were missing > 'const' qualifiers. > > Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > hw/usb/dev-mtp.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c > index f026419e47..ccbe25820b 100644 > --- a/hw/usb/dev-mtp.c > +++ b/hw/usb/dev-mtp.c > @@ -372,7 +372,7 @@ static const USBDesc desc = { > /* ----------------------------------------------------------------------- */ > > static MTPObject *usb_mtp_object_alloc(MTPState *s, uint32_t handle, > - MTPObject *parent, char *name) > + MTPObject *parent, const char *name) > { > MTPObject *o = g_new0(MTPObject, 1); > > @@ -454,7 +454,7 @@ static MTPObject *usb_mtp_object_lookup(MTPState *s, uint32_t handle) > } > > static MTPObject *usb_mtp_add_child(MTPState *s, MTPObject *o, > - char *name) > + const char *name) > { > MTPObject *child = > usb_mtp_object_alloc(s, s->next_handle++, o, name); > @@ -473,7 +473,7 @@ static MTPObject *usb_mtp_add_child(MTPState *s, MTPObject *o, > } > > static MTPObject *usb_mtp_object_lookup_name(MTPObject *parent, > - char *name, int len) > + const char *name, int len) > { > MTPObject *iter; > > @@ -640,7 +640,7 @@ static void usb_mtp_inotify_cleanup(MTPState *s) > } > } > > -static int usb_mtp_add_watch(int inotifyfd, char *path) > +static int usb_mtp_add_watch(int inotifyfd, const char *path) > { > uint32_t mask = IN_CREATE | IN_DELETE | IN_MODIFY; > > -- > 2.17.2 > >
diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index f026419e47..ccbe25820b 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -372,7 +372,7 @@ static const USBDesc desc = { /* ----------------------------------------------------------------------- */ static MTPObject *usb_mtp_object_alloc(MTPState *s, uint32_t handle, - MTPObject *parent, char *name) + MTPObject *parent, const char *name) { MTPObject *o = g_new0(MTPObject, 1); @@ -454,7 +454,7 @@ static MTPObject *usb_mtp_object_lookup(MTPState *s, uint32_t handle) } static MTPObject *usb_mtp_add_child(MTPState *s, MTPObject *o, - char *name) + const char *name) { MTPObject *child = usb_mtp_object_alloc(s, s->next_handle++, o, name); @@ -473,7 +473,7 @@ static MTPObject *usb_mtp_add_child(MTPState *s, MTPObject *o, } static MTPObject *usb_mtp_object_lookup_name(MTPObject *parent, - char *name, int len) + const char *name, int len) { MTPObject *iter; @@ -640,7 +640,7 @@ static void usb_mtp_inotify_cleanup(MTPState *s) } } -static int usb_mtp_add_watch(int inotifyfd, char *path) +static int usb_mtp_add_watch(int inotifyfd, const char *path) { uint32_t mask = IN_CREATE | IN_DELETE | IN_MODIFY;