| Message ID | 20181019070622.26661-2-linus.walleij@linaro.org |
|---|---|
| State | Superseded |
| Delegated to: | Boris Brezillon |
| Headers | show |
| Series | [1/3] mtd: Move Redboot partition parser | expand |
Hi, now just to forestall possible predictable bikeshedding on the devicetree list before it happens: On Fri, Oct 19, 2018 at 9:06 AM Linus Walleij <linus.walleij@linaro.org> wrote: > +RedBoot FLASH Image System (FIS) Partitions This expansion of the acronym including using capital letters in FLASH comes from the eCOS source code for RedBoot: https://sourceware.org/viewvc/ecos/packages/redboot/current/src/flash.c?view=markup > +- compatible : (required) must be "redboot-fis" There is no vendor here because the source code was owned by Cygnus Solutions, Redhat and now Free Software Foundation. https://en.wikipedia.org/wiki/ECos We have no (AFAICT) policy for whether stuff that just change vendor all the time should be named after the inventing (first) company "cygnus,*", current owner "fsf,*" or the one that made most changes to the source code "redhat,*". I do not think we should care, and just name it "redboot-fis" for it's historical value and widespread acceptance so this is a conscious naming scheme. If one of the OF maintainers says they want it a certain way I will change it without discussion, I just want this supported. Yours, Linus Walleij
On Fri, 19 Oct 2018 09:27:24 +0200 Linus Walleij <linus.walleij@linaro.org> wrote: > Hi, > > now just to forestall possible predictable bikeshedding on the devicetree > list before it happens: > > On Fri, Oct 19, 2018 at 9:06 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > > +RedBoot FLASH Image System (FIS) Partitions > > This expansion of the acronym including using capital letters in > FLASH comes from the eCOS source code for RedBoot: > https://sourceware.org/viewvc/ecos/packages/redboot/current/src/flash.c?view=markup > > > +- compatible : (required) must be "redboot-fis" > > There is no vendor here because the source code was owned by > Cygnus Solutions, Redhat and now Free Software Foundation. > https://en.wikipedia.org/wiki/ECos > > We have no (AFAICT) policy for whether stuff that just change vendor > all the time should be named after the inventing (first) company "cygnus,*", > current owner "fsf,*" or the one that made most changes to the source > code "redhat,*". I do not think we should care, and just name it > "redboot-fis" for it's historical value and widespread acceptance so this > is a conscious naming scheme. > > If one of the OF maintainers says they want it a certain way I will change > it without discussion, I just want this supported. If you send a new version, don't forget to update the subject prefix ("dt-bindings: mtd: ...") :-).
On Fri, Oct 19, 2018 at 09:27:24AM +0200, Linus Walleij wrote: > Hi, > > now just to forestall possible predictable bikeshedding on the devicetree > list before it happens: > > On Fri, Oct 19, 2018 at 9:06 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > > +RedBoot FLASH Image System (FIS) Partitions > > This expansion of the acronym including using capital letters in > FLASH comes from the eCOS source code for RedBoot: > https://sourceware.org/viewvc/ecos/packages/redboot/current/src/flash.c?view=markup > > > +- compatible : (required) must be "redboot-fis" > > There is no vendor here because the source code was owned by > Cygnus Solutions, Redhat and now Free Software Foundation. > https://en.wikipedia.org/wiki/ECos > > We have no (AFAICT) policy for whether stuff that just change vendor > all the time should be named after the inventing (first) company "cygnus,*", > current owner "fsf,*" or the one that made most changes to the source > code "redhat,*". I do not think we should care, and just name it > "redboot-fis" for it's historical value and widespread acceptance so this > is a conscious naming scheme. > > If one of the OF maintainers says they want it a certain way I will change > it without discussion, I just want this supported. It's all fine for me. I was only going to comment is Redboot still a thing? :) Rob
On Fri, 19 Oct 2018 09:06:21 +0200, Linus Walleij wrote: > This adds device tree bindings for the RedBoot FIS partition > format. > > Cc: devicetree@vger.kernel.org > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > .../bindings/mtd/partitions/redboot-fis.txt | 27 +++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/partitions/redboot-fis.txt > Reviewed-by: Rob Herring <robh@kernel.org>
On Thu, Oct 25, 2018 at 9:08 PM Rob Herring <robh@kernel.org> wrote: > It's all fine for me. Thanks. > I was only going to comment is Redboot still a thing? :) Yep. What I've learned recently is that some of the stuff we support has way longer lifecycles than we expected. There are brand new devices shipping using the RedBoot partition table as we speak. It seems to be coming from places like Taiwan. Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/mtd/partitions/redboot-fis.txt b/Documentation/devicetree/bindings/mtd/partitions/redboot-fis.txt new file mode 100644 index 000000000000..fd0ebe4e3415 --- /dev/null +++ b/Documentation/devicetree/bindings/mtd/partitions/redboot-fis.txt @@ -0,0 +1,27 @@ +RedBoot FLASH Image System (FIS) Partitions +=========================================== + +The FLASH Image System (FIS) directory is a flash description +format closely associated with the RedBoot boot loader. + +It uses one single flash eraseblock in the flash to store an index of +all images in the flash. + +This block size will vary depending on flash but is typically +32 KB in size. + +Required properties: +- compatible : (required) must be "redboot-fis" +- fis-index-block : (required) a index to the eraseblock containing + the FIS directory on this device. On a flash memory with 32KB + eraseblocks, 0 means the first eraseblock at 0x00000000, 1 means the + second eraseblock at 0x00008000 and so on. + +Example: + +flash@0 { + partitions { + compatible = "redboot-fis"; + fis-index-block = <0>; + }; +};
This adds device tree bindings for the RedBoot FIS partition format. Cc: devicetree@vger.kernel.org Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- .../bindings/mtd/partitions/redboot-fis.txt | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/mtd/partitions/redboot-fis.txt