diff mbox series

[U-Boot] arm: ti: boot: Remove environment partition

Message ID 20181018194717.8303-1-semen.protsenko@linaro.org
State Accepted
Commit 88d60db01168c743b4ae4152150a43a3df43c1c0
Delegated to: Tom Rini
Headers show
Series [U-Boot] arm: ti: boot: Remove environment partition | expand

Commit Message

Sam Protsenko Oct. 18, 2018, 7:47 p.m. UTC
Remove "environment" partition and do not read it when booting Android
from eMMC. We don't use this partition anymore, so this is just an
unintentional leftover.

Earlier we were reading dtb file from "environment" partition to feed it
further to kernel. Now we are using dtb from FIT image ("boot" partition
contains boot_fit.img image), which can be seen from this command:

    bootm ${loadaddr}#${fdtfile}

where "#" character means we have FIT image in ${loadaddr} RAM address.

Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
---
 include/environment/ti/boot.h | 3 ---
 1 file changed, 3 deletions(-)

Comments

Praneeth Bajjuri Oct. 18, 2018, 8:02 p.m. UTC | #1
On 10/18/2018 2:47 PM, Sam Protsenko wrote:
> Remove "environment" partition and do not read it when booting Android
> from eMMC. We don't use this partition anymore, so this is just an
> unintentional leftover.
> 
> Earlier we were reading dtb file from "environment" partition to feed it
> further to kernel. Now we are using dtb from FIT image ("boot" partition
> contains boot_fit.img image), which can be seen from this command:
> 
>      bootm ${loadaddr}#${fdtfile}
> 
> where "#" character means we have FIT image in ${loadaddr} RAM address.
> 
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>

Acked-by: Praneeth Bajjuri <praneeth@ti.com>

> ---
>   include/environment/ti/boot.h | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/include/environment/ti/boot.h b/include/environment/ti/boot.h
> index 2893cd4287..560753ae4c 100644
> --- a/include/environment/ti/boot.h
> +++ b/include/environment/ti/boot.h
> @@ -35,7 +35,6 @@
>   	"uuid_disk=${uuid_gpt_disk};" \
>   	"name=xloader,start=128K,size=256K,uuid=${uuid_gpt_xloader};" \
>   	"name=bootloader,size=1792K,uuid=${uuid_gpt_bootloader};" \
> -	"name=environment,size=128K,uuid=${uuid_gpt_environment};" \
>   	"name=misc,size=128K,uuid=${uuid_gpt_misc};" \
>   	"name=reserved,size=256K,uuid=${uuid_gpt_reserved};" \
>   	"name=efs,size=16M,uuid=${uuid_gpt_efs};" \
> @@ -92,8 +91,6 @@
>   		"mmc dev $mmcdev; " \
>   		"mmc rescan; " \
>   		AVB_VERIFY_CHECK \
> -		"part start mmc ${mmcdev} environment fdt_start; " \
> -		"part size mmc ${mmcdev} environment fdt_size; " \
>   		"part start mmc ${mmcdev} boot boot_start; " \
>   		"part size mmc ${mmcdev} boot boot_size; " \
>   		"mmc read ${fdtaddr} ${fdt_start} ${fdt_size}; " \
>
Tom Rini Oct. 22, 2018, 5:25 p.m. UTC | #2
On Thu, Oct 18, 2018 at 10:47:17PM +0300, Sam Protsenko wrote:

> Remove "environment" partition and do not read it when booting Android
> from eMMC. We don't use this partition anymore, so this is just an
> unintentional leftover.
> 
> Earlier we were reading dtb file from "environment" partition to feed it
> further to kernel. Now we are using dtb from FIT image ("boot" partition
> contains boot_fit.img image), which can be seen from this command:
> 
>     bootm ${loadaddr}#${fdtfile}
> 
> where "#" character means we have FIT image in ${loadaddr} RAM address.
> 
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> Acked-by: Praneeth Bajjuri <praneeth@ti.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/include/environment/ti/boot.h b/include/environment/ti/boot.h
index 2893cd4287..560753ae4c 100644
--- a/include/environment/ti/boot.h
+++ b/include/environment/ti/boot.h
@@ -35,7 +35,6 @@ 
 	"uuid_disk=${uuid_gpt_disk};" \
 	"name=xloader,start=128K,size=256K,uuid=${uuid_gpt_xloader};" \
 	"name=bootloader,size=1792K,uuid=${uuid_gpt_bootloader};" \
-	"name=environment,size=128K,uuid=${uuid_gpt_environment};" \
 	"name=misc,size=128K,uuid=${uuid_gpt_misc};" \
 	"name=reserved,size=256K,uuid=${uuid_gpt_reserved};" \
 	"name=efs,size=16M,uuid=${uuid_gpt_efs};" \
@@ -92,8 +91,6 @@ 
 		"mmc dev $mmcdev; " \
 		"mmc rescan; " \
 		AVB_VERIFY_CHECK \
-		"part start mmc ${mmcdev} environment fdt_start; " \
-		"part size mmc ${mmcdev} environment fdt_size; " \
 		"part start mmc ${mmcdev} boot boot_start; " \
 		"part size mmc ${mmcdev} boot boot_size; " \
 		"mmc read ${fdtaddr} ${fdt_start} ${fdt_size}; " \