diff mbox series

[iproute] tc: Remove pointless assignments in batch()

Message ID 20181018134848.1298-1-phil@nwl.cc
State Accepted, archived
Delegated to: stephen hemminger
Headers show
Series [iproute] tc: Remove pointless assignments in batch() | expand

Commit Message

Phil Sutter Oct. 18, 2018, 1:48 p.m. UTC 
All these assignments are later overwritten without reading in between,
so just drop them.

Fixes: 485d0c6001c4a ("tc: Add batchsize feature for filter and actions")
Signed-off-by: Phil Sutter <phil@nwl.cc>
---
 tc/tc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Stephen Hemminger Oct. 22, 2018, 5:08 p.m. UTC | #1 
On Thu, 18 Oct 2018 15:48:48 +0200
Phil Sutter <phil@nwl.cc> wrote:

> All these assignments are later overwritten without reading in between,
> so just drop them.
> 
> Fixes: 485d0c6001c4a ("tc: Add batchsize feature for filter and actions")
> Signed-off-by: Phil Sutter <phil@nwl.cc>

Applied
diff mbox series

Patch

diff --git a/tc/tc.c b/tc/tc.c
index c493d5e92e0dd..eacd5c08573d4 100644
--- a/tc/tc.c
+++ b/tc/tc.c
@@ -325,11 +325,11 @@  static int batch(const char *name)
 	struct batch_buf *head = NULL, *tail = NULL, *buf_pool = NULL;
 	char *largv[100], *largv_next[100];
 	char *line, *line_next = NULL;
-	bool bs_enabled_next = false;
 	bool bs_enabled = false;
 	bool lastline = false;
 	int largc, largc_next;
 	bool bs_enabled_saved;
+	bool bs_enabled_next;
 	int batchsize = 0;
 	size_t len = 0;
 	int ret = 0;
@@ -358,7 +358,6 @@  static int batch(const char *name)
 		goto Exit;
 	largc = makeargs(line, largv, 100);
 	bs_enabled = batchsize_enabled(largc, largv);
-	bs_enabled_saved = bs_enabled;
 	do {
 		if (getcmdline(&line_next, &len, stdin) == -1)
 			lastline = true;
@@ -394,7 +393,6 @@  static int batch(const char *name)
 		len = 0;
 		bs_enabled_saved = bs_enabled;
 		bs_enabled = bs_enabled_next;
-		bs_enabled_next = false;
 
 		if (largc == 0) {
 			largc = largc_next;